Update patch set 1

Patch Set 1: (5 comments) minor issues Patch-set: 1
2015-02-03 18:59:30 +00:00 · 2015-02-03 18:59:30 +00:00 · 92b5159f77
commit 92b5159f77
parent a47e50d6f9
1 changed files with 119 additions and 0 deletions
--- a/119
+++ b/119
@ -0,0 +1,119 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "da86d52c_506490e4",
+        "filename": "nova_powervm/virt/powervm/localdisk.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 123,
+      "author": {
+        "id": 14070
+      },
+      "writtenOn": "2015-02-03T18:59:30Z",
+      "side": 1,
+      "message": "Maybe a nit, but every loop iteration is \u0027finding\u0027 the vdisks and constructing the list wrapper object to return before requesting removal of one item.  Would be more efficient to assign vg.virtual_disks to a local var outside of the loop.",
+      "range": {
+        "startLine": 123,
+        "startChar": 12,
+        "endLine": 123,
+        "endChar": 28
+      },
+      "revId": "313e67b456e04359f4fd84f31a074e15a9cf6667",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "da86d52c_6721d7fa",
+        "filename": "nova_powervm/virt/powervm/localdisk.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 133,
+      "author": {
+        "id": 14070
+      },
+      "writtenOn": "2015-02-03T18:59:30Z",
+      "side": 1,
+      "message": "which part of this is quick?  You\u0027re not using \u0027quick properties\u0027.",
+      "range": {
+        "startLine": 133,
+        "startChar": 10,
+        "endLine": 133,
+        "endChar": 15
+      },
+      "revId": "313e67b456e04359f4fd84f31a074e15a9cf6667",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "da86d52c_073adb35",
+        "filename": "nova_powervm/virt/powervm/localdisk.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 141,
+      "author": {
+        "id": 14070
+      },
+      "writtenOn": "2015-02-03T18:59:30Z",
+      "side": 1,
+      "message": "ditto above",
+      "range": {
+        "startLine": 141,
+        "startChar": 12,
+        "endLine": 141,
+        "endChar": 32
+      },
+      "revId": "313e67b456e04359f4fd84f31a074e15a9cf6667",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "da86d52c_c71c437a",
+        "filename": "nova_powervm/virt/powervm/media.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 214,
+      "author": {
+        "id": 14070
+      },
+      "writtenOn": "2015-02-03T18:59:30Z",
+      "side": 1,
+      "message": "seems like this could be factored out into a common util.",
+      "range": {
+        "startLine": 213,
+        "startChar": 0,
+        "endLine": 214,
+        "endChar": 0
+      },
+      "revId": "313e67b456e04359f4fd84f31a074e15a9cf6667",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "da86d52c_5adcaa12",
+        "filename": "nova_powervm/virt/powervm/tasks/destroy.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 30,
+      "author": {
+        "id": 14070
+      },
+      "writtenOn": "2015-02-03T18:59:30Z",
+      "side": 1,
+      "message": "param not documented.  (pretty obvious, but still)",
+      "range": {
+        "startLine": 30,
+        "startChar": 40,
+        "endLine": 30,
+        "endChar": 49
+      },
+      "revId": "313e67b456e04359f4fd84f31a074e15a9cf6667",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}