Add missing tasks tests

This adds missing tests for vm.Get, vm.UpdateIBMiSettings and
storage.SaveBDM tasks.

Change-Id: Icd36070574ead6fe0724e755f32764b1b24d94f2

nova_powervm/tests/virt/powervm/tasks/test_storage.py

@@ -349,6 +349,17 @@ class TestStorage(test.NoDBTestCase):
             tf_stg.FindDisk(disk_dvr, context, instance, disk_type)
         tf.assert_called_once_with(name='find_disk', provides='disk_dev_info')
 
+    def test_save_bdm(self):
+        mock_bdm = mock.Mock(volume_id=1)
+        save_bdm = tf_stg.SaveBDM(mock_bdm, 'instance')
+        save_bdm.execute()
+        mock_bdm.save.assert_called_once_with()
+
+        # Validate args on taskflow.task.Task instantiation
+        with mock.patch('taskflow.task.Task.__init__') as tf:
+            tf_stg.SaveBDM(mock_bdm, 'instance')
+        tf.assert_called_once_with(name='save_bdm_1')
+
     def test_extend_disk(self):
         disk_dvr = mock.Mock()
         instance = mock.Mock()

nova_powervm/tests/virt/powervm/tasks/test_vm.py

@@ -34,6 +34,18 @@ class TestVMTasks(test.NoDBTestCase):
         self.apt = mock.Mock()
         self.instance = mock.Mock(uuid='fake-uuid')
 
+    @mock.patch('nova_powervm.virt.powervm.vm.get_instance_wrapper',
+                autospec=True)
+    def test_get(self, mock_inst_wrap):
+        get = tf_vm.Get(self.apt, 'host_uuid', self.instance)
+        get.execute()
+        mock_inst_wrap.assert_called_once_with(self.apt, self.instance)
+
+        # Validate args on taskflow.task.Task instantiation
+        with mock.patch('taskflow.task.Task.__init__') as tf:
+            tf_vm.Get(self.apt, 'host_uuid', self.instance)
+        tf.assert_called_once_with(name='get_vm', provides='lpar_wrap')
+
     @mock.patch('pypowervm.utils.transaction.FeedTask', autospec=True)
     @mock.patch('pypowervm.tasks.partition.build_active_vio_feed_task',
                 autospec=True)
@@ -240,3 +252,16 @@ class TestVMTasks(test.NoDBTestCase):
         with mock.patch('taskflow.task.Task.__init__') as tf:
             tf_vm.DeleteNvram(nvram_mgr, self.instance)
         tf.assert_called_once_with(name='delete_nvram')
+
+    @mock.patch('nova_powervm.virt.powervm.vm.update_ibmi_settings',
+                autospec=True)
+    def test_update_ibmi_settings(self, mock_update):
+        update = tf_vm.UpdateIBMiSettings(self.apt, self.instance, 'boot_type')
+        update.execute()
+        mock_update.assert_called_once_with(self.apt, self.instance,
+                                            'boot_type')
+
+        # Validate args on taskflow.task.Task instantiation
+        with mock.patch('taskflow.task.Task.__init__') as tf:
+            tf_vm.UpdateIBMiSettings(self.apt, self.instance, 'boot_type')
+        tf.assert_called_once_with(name='update_ibmi_settings')