# Copyright IBM Corp. and contributors # # All Rights Reserved. # # Licensed under the Apache License, Version 2.0 (the "License"); you may # not use this file except in compliance with the License. You may obtain # a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an "AS IS" BASIS, WITHOUT # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # License for the specific language governing permissions and limitations # under the License. from __future__ import absolute_import import collections import contextlib import logging import fixtures import mock from nova import block_device as nova_block_device from nova.compute import provider_tree from nova.compute import task_states from nova import conf as cfg from nova import exception as exc from nova import objects from nova.objects import base as obj_base from nova.objects import block_device as bdmobj from nova import test from nova.virt import block_device as nova_virt_bdm from nova.virt import driver as virt_driver from nova.virt import fake from nova.virt import hardware from nova.virt.powervm_ext import driver from oslo_serialization import jsonutils from oslo_utils.fixture import uuidsentinel as uuids from pypowervm import adapter as pvm_adp from pypowervm import const as pvm_const from pypowervm import exceptions as pvm_exc from pypowervm.helpers import log_helper as log_hlp from pypowervm.helpers import vios_busy as vio_hlp from pypowervm.utils import transaction as pvm_tx from pypowervm.wrappers import logical_partition as pvm_lpar from pypowervm.wrappers import virtual_io_server as pvm_vios from nova_powervm.tests.virt import powervm from nova_powervm.tests.virt.powervm import fixtures as fx from nova_powervm.virt.powervm import exception as p_exc from nova_powervm.virt.powervm import live_migration as lpm from nova_powervm.virt.powervm import vm CONF = cfg.CONF LOG = logging.getLogger(__name__) logging.basicConfig() @mock.patch('nova_powervm.virt.powervm.mgmt.mgmt_uuid', new=mock.Mock()) class TestPowerVMDriverInit(test.NoDBTestCase): """A test class specifically for the driver setup. Handles testing the configuration of the agent with the backing REST API. """ def test_driver_capabilities_defaults(self): """Test the default capabilities.""" test_driver = driver.PowerVMDriver(fake.FakeVirtAPI()) self.assertFalse( test_driver.capabilities['supports_migrate_to_same_host']) self.assertTrue(test_driver.capabilities['supports_attach_interface']) self.assertFalse(test_driver.capabilities['supports_device_tagging']) self.assertFalse( test_driver.capabilities['supports_tagged_attach_interface']) self.assertFalse( test_driver.capabilities['supports_tagged_attach_volume']) self.assertTrue(test_driver.capabilities['supports_extend_volume']) self.assertFalse(test_driver.capabilities['supports_multiattach']) self.assertTrue(test_driver.capabilities['supports_evacuate']) self.assertNotIn('has_imagecache', test_driver.capabilities) self.assertEqual(8, len(test_driver.capabilities)) @mock.patch('pypowervm.tasks.storage.find_vg', new=mock.Mock(return_value=(mock.Mock(), mock.Mock()))) def test_driver_capabilities_from_localdisk_adapter(self): """Test dynamic capabilities from localdisk adapter.""" self.flags(disk_driver='localdisk', group='powervm') self.flags(volume_group_name='foovg', group='powervm') test_driver = driver.PowerVMDriver(fake.FakeVirtAPI()) test_driver.adapter = mock.Mock() test_driver.host_uuid = mock.Mock() test_driver._setup_disk_adapter() # Localdisk driver has the image cache capability self.assertTrue(test_driver.capabilities['has_imagecache']) self.assertEqual(9, len(test_driver.capabilities)) @mock.patch('nova_powervm.virt.powervm.disk.ssp.SSPDiskAdapter.' '_fetch_cluster', new=mock.Mock()) @mock.patch('nova_powervm.virt.powervm.disk.ssp.SSPDiskAdapter.' '_ssp', new=mock.Mock()) @mock.patch('nova_powervm.virt.powervm.disk.ssp.SSPDiskAdapter.' '_tier', new=mock.Mock()) def test_driver_capabilities_from_ssp_disk_adapter(self): """Test dynamic capabilities from SSP disk adapter.""" self.flags(disk_driver='ssp', group='powervm') test_driver = driver.PowerVMDriver(fake.FakeVirtAPI()) test_driver.adapter = mock.Mock() test_driver.host_uuid = mock.Mock() test_driver._setup_disk_adapter() # SSP driver doesn't have image cache capability self.assertFalse(test_driver.capabilities['has_imagecache']) self.assertEqual(9, len(test_driver.capabilities)) @mock.patch('nova_powervm.virt.powervm.event.PowerVMNovaEventHandler', autospec=True) @mock.patch('pypowervm.adapter.Adapter', autospec=True) @mock.patch('pypowervm.adapter.Session', autospec=True) def test_get_adapter(self, mock_session, mock_adapter, mock_evt_handler): # Set up the mocks. mock_evt_listener = (mock_session.return_value.get_event_listener. return_value) mock_evt_handler.return_value = 'evt_hdlr' # Setup and invoke drv = driver.PowerVMDriver(fake.FakeVirtAPI()) drv._get_adapter() # Assert the appropriate calls mock_session.assert_called_once_with(conn_tries=300) mock_adapter.assert_called_once_with( mock_session.return_value, helpers=[log_hlp.log_helper, vio_hlp.vios_busy_retry_helper]) mock_evt_listener.subscribe.assert_called_once_with('evt_hdlr') class TestPowerVMDriver(test.NoDBTestCase): def setUp(self): super(TestPowerVMDriver, self).setUp() self.flags(disk_driver='localdisk', group='powervm') self.flags(host='host1', my_ip='127.0.0.1') self.drv_fix = self.useFixture(fx.PowerVMComputeDriver()) self.drv = self.drv_fix.drv self.apt = self.drv.adapter self._setup_lpm() self.disk_dvr = self.drv.disk_dvr self.vol_fix = self.useFixture(fx.VolumeAdapter( 'nova_powervm.virt.powervm.volume.vscsi.PVVscsiFCVolumeAdapter')) self.vol_drv = self.vol_fix.drv self.iscsi_vol_fix = self.useFixture(fx.VolumeAdapter( 'nova_powervm.virt.powervm.volume.iscsi.IscsiVolumeAdapter')) self.iscsi_vol_drv = self.iscsi_vol_fix.drv self.crt_lpar = self.useFixture(fixtures.MockPatch( 'nova_powervm.virt.powervm.vm.create_lpar')).mock self.get_inst_wrap = self.useFixture(fixtures.MockPatch( 'nova_powervm.virt.powervm.vm.get_instance_wrapper')).mock self.build_tx_feed = self.useFixture(fixtures.MockPatch( 'pypowervm.tasks.partition.build_active_vio_feed_task')).mock self.stg_ftsk = pvm_tx.FeedTask( 'fake', [mock.Mock(spec=pvm_vios.VIOS, uuid='uuid')]) self.build_tx_feed.return_value = self.stg_ftsk self.scrub_stg = self.useFixture(fixtures.MockPatch( 'pypowervm.tasks.storage.add_lpar_storage_scrub_tasks')).mock self.san_lpar_name = self.useFixture(fixtures.MockPatch( 'pypowervm.util.sanitize_partition_name_for_api')).mock self.san_lpar_name.side_effect = lambda name: name self.validate_vopt = self.useFixture(fixtures.MockPatch( 'pypowervm.tasks.vopt.validate_vopt_repo_exists')).mock self.validate_vopt.return_value = None, None self.slot_mgr = self.useFixture(fixtures.MockPatch( 'nova_powervm.virt.powervm.slot.build_slot_mgr')).mock.return_value # Create an instance to test with self.inst = objects.Instance(**powervm.TEST_INST_SPAWNING) self.inst_ibmi = objects.Instance(**powervm.TEST_INST_SPAWNING) self.inst_ibmi.system_metadata = {'image_os_distro': 'ibmi'} def test_get_available_nodes(self): self.flags(host='hostname') self.assertEqual(['hostname'], self.drv.get_available_nodes('node')) def _setup_lpm(self): """Setup the lpm environment. This may have to be called directly by tests since the lpm code cleans up the dict entry on the last expected lpm method. """ self.lpm = mock.Mock() self.lpm_inst = mock.Mock() self.lpm_inst.uuid = 'inst1' self.drv.live_migrations = {'inst1': self.lpm} def test_driver_create(self): """Validates that a driver of the PowerVM type can be initialized.""" test_drv = driver.PowerVMDriver(fake.FakeVirtAPI()) self.assertIsNotNone(test_drv) def test_cleanup_host(self): self.drv.cleanup_host('fake_host') self.assertTrue( self.drv.session.get_event_listener.return_value.shutdown.called) @mock.patch('nova_powervm.virt.powervm.volume.iscsi.get_iscsi_initiators') def test_get_volume_connector(self, mock_initiators): """Tests that a volume connector can be built.""" initiators = [('1300C76F-9814-4A4D-B1F0-5B69352A7DEA', 'fake_iqn1'), ('7DBBE705-E4C4-4458-8223-3EBE07015CA9', 'fake_iqn2')] initiators = collections.OrderedDict(initiators) mock_initiators.return_value = initiators vol_connector = self.drv.get_volume_connector(mock.Mock()) self.assertIsNotNone(vol_connector['wwpns']) self.assertEqual(vol_connector['host'], CONF.host) self.assertEqual('fake_iqn1', vol_connector['initiator']) def test_setup_disk_adapter(self): # Ensure we can handle upper case option and we instantiate the class self.flags(disk_driver='LoCaLDisK', group='powervm') self.drv.disk_dvr = None self.drv._setup_disk_adapter() # The local disk driver has been mocked, so we just compare the name self.assertIn('LocalStorage()', str(self.drv.disk_dvr)) @mock.patch('nova_powervm.virt.powervm.nvram.manager.NvramManager', autospec=True) @mock.patch('oslo_utils.importutils.import_object', autospec=True) @mock.patch('nova.utils.spawn', autospec=True) def test_setup_rebuild_store(self, mock_spawn, mock_import, mock_mgr): self.flags(nvram_store='NoNe', group='powervm') self.drv._setup_rebuild_store() self.assertFalse(mock_import.called) self.assertFalse(mock_mgr.called) self.assertFalse(mock_spawn.called) self.flags(nvram_store='swift', group='powervm') self.drv._setup_rebuild_store() self.assertTrue(mock_import.called) self.assertTrue(mock_mgr.called) self.assertTrue(mock_spawn.called) self.assertIsNotNone(self.drv.store_api) @mock.patch.object(vm, 'get_lpars', autospec=True) @mock.patch.object(vm, 'get_instance', autospec=True) def test_nvram_host_startup(self, mock_get_inst, mock_get_lpars): mock_lpar_wrapper = mock.Mock() mock_lpar_wrapper.uuid = 'uuid_value' mock_get_lpars.return_value = [mock_lpar_wrapper, mock_lpar_wrapper, mock_lpar_wrapper] mock_get_inst.side_effect = [powervm.TEST_INST1, None, powervm.TEST_INST2] self.drv.nvram_mgr = mock.Mock() self.drv._nvram_host_startup() self.drv.nvram_mgr.store.assert_has_calls( [mock.call(powervm.TEST_INST1), mock.call(powervm.TEST_INST2)]) @mock.patch('nova_powervm.virt.powervm.vm.get_pvm_uuid', autospec=True) @mock.patch('nova_powervm.virt.powervm.vm.get_vm_qp', autospec=True) @mock.patch('nova_powervm.virt.powervm.vm._translate_vm_state', autospec=True) def test_get_info(self, mock_tx_state, mock_qp, mock_uuid): mock_tx_state.return_value = 'fake-state' self.assertEqual(hardware.InstanceInfo('fake-state'), self.drv.get_info('inst')) mock_uuid.assert_called_once_with('inst') mock_qp.assert_called_once_with( self.drv.adapter, mock_uuid.return_value, 'PartitionState') mock_tx_state.assert_called_once_with(mock_qp.return_value) @mock.patch('nova_powervm.virt.powervm.vm.get_lpar_names') def test_list_instances(self, mock_names): mock_names.return_value = ['one', 'two', 'three'] self.assertEqual(['one', 'two', 'three'], self.drv.list_instances()) mock_names.assert_called_once_with(self.drv.adapter) @mock.patch('nova_powervm.virt.powervm.vm.instance_exists') def test_instance_exists(self, mock_inst_exists): mock_inst_exists.side_effect = [True, False] self.assertTrue(self.drv.instance_exists(mock.Mock())) self.assertFalse(self.drv.instance_exists(mock.Mock())) def test_instance_on_disk(self): """Validates the instance_on_disk method.""" @mock.patch.object(self.drv, '_is_booted_from_volume') @mock.patch.object(self.drv, '_get_block_device_info') @mock.patch.object(self.disk_dvr, 'capabilities') @mock.patch.object(self.disk_dvr, 'get_disk_ref') def inst_on_disk(mock_disk_ref, mock_capb, mock_block, mock_boot): # Test boot from volume. mock_boot.return_value = True self.assertTrue(self.drv.instance_on_disk(self.inst)) mock_boot.return_value = False # Disk driver is shared storage and can find the disk mock_capb['shared_storage'] = True mock_disk_ref.return_value = 'disk_reference' self.assertTrue(self.drv.instance_on_disk(self.inst)) # Disk driver can't find it mock_disk_ref.return_value = None self.assertFalse(self.drv.instance_on_disk(self.inst)) # Disk driver exception mock_disk_ref.side_effect = ValueError('Bad disk') self.assertFalse(self.drv.instance_on_disk(self.inst)) mock_disk_ref.side_effect = None # Not on shared storage mock_capb['shared_storage'] = False self.assertFalse(self.drv.instance_on_disk(self.inst)) inst_on_disk() @mock.patch('pypowervm.tasks.power_opts.PowerOnOpts') @mock.patch('nova_powervm.virt.powervm.media.ConfigDrivePowerVM.' 'get_cfg_drv_name') @mock.patch('nova_powervm.virt.powervm.tasks.storage.' 'CreateAndConnectCfgDrive.execute') @mock.patch('nova_powervm.virt.powervm.tasks.storage.ConnectVolume' '.execute') @mock.patch('nova_powervm.virt.powervm.tasks.storage.CreateDiskForImg' '.execute') @mock.patch('nova.virt.powervm_ext.driver.PowerVMDriver.' '_is_booted_from_volume') @mock.patch('nova_powervm.virt.powervm.tasks.network.PlugMgmtVif.execute') @mock.patch('nova_powervm.virt.powervm.tasks.network.PlugVifs.execute') @mock.patch('nova.virt.configdrive.required_by') @mock.patch('nova_powervm.virt.powervm.vm.power_on') @mock.patch('nova_powervm.virt.powervm.driver.PowerVMDriver._vol_drv_iter') def test_spawn_ops(self, mock_vdi, mock_pwron, mock_cfg_drv, mock_plug_vifs, mock_plug_mgmt_vif, mock_boot_from_vol, mock_crt_disk_img, mock_conn_vol, mock_crt_cfg_drv, mock_cfg_name, mock_pwron_opts): """Validates the 'typical' spawn flow of the spawn of an instance. Uses a basic disk image, attaching networks and powering on. """ # Set up the mocks to the tasks. mock_cfg_drv.return_value = False mock_boot_from_vol.return_value = False mock_pwron_opts.return_value = 'fake-opts' # Invoke the method. self.drv.spawn('context', self.inst, powervm.IMAGE1, 'injected_files', 'admin_password', {}) # _vol_drv_iter not called from spawn because not recreate; but still # called from _add_volume_connection_tasks. mock_vdi.assert_called_once_with( self.inst, [], stg_ftsk=self.build_tx_feed.return_value) # Assert the correct tasks were called self.assertTrue(mock_plug_vifs.called) self.assertTrue(mock_plug_mgmt_vif.called) self.assertTrue(mock_crt_disk_img.called) self.crt_lpar.assert_called_with( self.apt, self.drv.host_wrapper, self.inst, nvram=None, slot_mgr=self.slot_mgr) mock_pwron.assert_called_once_with(self.apt, self.inst, opts='fake-opts') mock_cfg_name.assert_not_called() # Assert that tasks that are not supposed to be called are not called self.assertFalse(mock_conn_vol.called) self.assertFalse(mock_crt_cfg_drv.called) self.scrub_stg.assert_called_with(mock.ANY, self.stg_ftsk, lpars_exist=True) @mock.patch('pypowervm.tasks.power_opts.PowerOnOpts') @mock.patch('nova_powervm.virt.powervm.tasks.network.PlugMgmtVif.execute') @mock.patch('nova_powervm.virt.powervm.tasks.network.PlugVifs.execute') @mock.patch('nova_powervm.virt.powervm.media.ConfigDrivePowerVM.' 'get_cfg_drv_name') @mock.patch('nova_powervm.virt.powervm.media.ConfigDrivePowerVM.' 'create_cfg_drv_vopt') @mock.patch('nova.virt.configdrive.required_by') @mock.patch('nova_powervm.virt.powervm.vm.power_on') def test_spawn_with_cfg(self, mock_pwron, mock_cfg_drv, mock_cfg_vopt, mock_cfg_name, mock_plug_vifs, mock_plug_mgmt_vif, mock_pwron_opts): """Validates the PowerVM spawn w/ config drive operations.""" # Set up the mocks to the tasks. mock_cfg_drv.return_value = True mock_cfg_name.return_value = 'fake-name' self.flags(remove_vopt_media_on_boot=True, group='powervm') mock_opts = mock.MagicMock() mock_pwron_opts.return_value = mock_opts # Invoke the method. self.drv.spawn('context', self.inst, powervm.IMAGE1, 'injected_files', 'admin_password', {}) # Create LPAR was called self.crt_lpar.assert_called_with(self.apt, self.drv.host_wrapper, self.inst, nvram=None, slot_mgr=self.slot_mgr) # Config drive was called self.assertTrue(mock_cfg_vopt.called) self.assertTrue(self.validate_vopt.called) # Power on was called mock_pwron.assert_called_once_with(self.apt, self.inst, opts=mock_opts) mock_opts.remove_optical.assert_called_with('fake-name', time=60) mock_cfg_name.assert_called_with(self.inst) self.scrub_stg.assert_called_with(mock.ANY, self.stg_ftsk, lpars_exist=True) @mock.patch('nova.virt.block_device.DriverVolumeBlockDevice.save') @mock.patch('nova_powervm.virt.powervm.tasks.storage.CreateDiskForImg' '.execute') @mock.patch('nova.virt.powervm_ext.driver.PowerVMDriver.' '_is_booted_from_volume') @mock.patch('nova_powervm.virt.powervm.tasks.network.PlugMgmtVif.execute') @mock.patch('nova_powervm.virt.powervm.tasks.network.PlugVifs.execute') @mock.patch('nova.virt.configdrive.required_by') @mock.patch('nova_powervm.virt.powervm.vm.power_on') def test_spawn_with_bdms(self, mock_pwron, mock_cfg_drv, mock_plug_vifs, mock_plug_mgmt_vif, mock_boot_from_vol, mock_crt_img, mock_save): """Validates the PowerVM spawn. Specific Test: spawn of an image that has a disk image and block device mappings are passed into spawn which originated from either the image metadata itself or the create server request. In particular, test when the BDMs passed in do not have the root device for the instance. """ # Set up the mocks to the tasks. mock_cfg_drv.return_value = False mock_boot_from_vol.return_value = False # Create some fake BDMs block_device_info = self._fake_bdms() # Invoke the method. self.drv.spawn('context', self.inst, powervm.IMAGE1, 'injected_files', 'admin_password', {}, block_device_info=block_device_info) self.assertTrue(mock_boot_from_vol.called) # Since the root device is not in the BDMs we expect the image disk to # be created. self.assertTrue(mock_crt_img.called) # Create LPAR was called self.crt_lpar.assert_called_with(self.apt, self.drv.host_wrapper, self.inst, nvram=None, slot_mgr=self.slot_mgr) # Power on was called mock_pwron.assert_called_once_with(self.apt, self.inst, opts=mock.ANY) # Check that the connect volume was called self.assertEqual(2, self.vol_drv.connect_volume.call_count) # Make sure the save was invoked self.assertEqual(2, mock_save.call_count) self.scrub_stg.assert_called_with(mock.ANY, self.stg_ftsk, lpars_exist=True) @mock.patch('nova.virt.block_device.DriverVolumeBlockDevice.save') @mock.patch('nova_powervm.virt.powervm.tasks.storage.CreateDiskForImg' '.execute') @mock.patch('nova.virt.powervm_ext.driver.PowerVMDriver.' '_is_booted_from_volume') @mock.patch('nova_powervm.virt.powervm.tasks.network.PlugMgmtVif.execute') @mock.patch('nova_powervm.virt.powervm.tasks.network.PlugVifs.execute') @mock.patch('nova.virt.configdrive.required_by') @mock.patch('nova_powervm.virt.powervm.vm.power_on') def test_spawn_with_image_meta_root_bdm(self, mock_pwron, mock_cfg_drv, mock_plug_vifs, mock_plug_mgmt_vif, mock_boot_from_vol, mock_crt_img, mock_save): """Validates the PowerVM spawn. Specific Test: spawn of an image that does not have a disk image but rather the block device mappings are passed into spawn. These originated from either the image metadata itself or the create server request. In particular, test when the BDMs passed in have the root device for the instance and image metadata from an image is also passed. Note this tests the ability to spawn an image that does not contain a disk image but rather contains block device mappings containing the root BDM. The nova.compute.api.API.snapshot_volume_backed flow produces such images. """ # Set up the mocks to the tasks. mock_cfg_drv.return_value = False mock_boot_from_vol.return_value = True # Create some fake BDMs block_device_info = self._fake_bdms() # Invoke the method. self.drv.spawn('context', self.inst, powervm.IMAGE1, 'injected_files', 'admin_password', {}, block_device_info=block_device_info) self.assertTrue(mock_boot_from_vol.called) # Since the root device is in the BDMs we do not expect the image disk # to be created. self.assertFalse(mock_crt_img.called) # Create LPAR was called self.crt_lpar.assert_called_with(self.apt, self.drv.host_wrapper, self.inst, nvram=None, slot_mgr=self.slot_mgr) # Power on was called mock_pwron.assert_called_once_with(self.apt, self.inst, opts=mock.ANY) # Check that the connect volume was called self.assertEqual(2, self.vol_drv.connect_volume.call_count) self.scrub_stg.assert_called_with(mock.ANY, self.stg_ftsk, lpars_exist=True) @mock.patch('nova.virt.block_device.DriverVolumeBlockDevice.save') @mock.patch('nova_powervm.virt.powervm.tasks.storage.CreateDiskForImg' '.execute') @mock.patch('nova.virt.powervm_ext.driver.PowerVMDriver.' '_is_booted_from_volume') @mock.patch('nova_powervm.virt.powervm.tasks.network.PlugMgmtVif.execute') @mock.patch('nova_powervm.virt.powervm.tasks.network.PlugVifs.execute') @mock.patch('nova.virt.configdrive.required_by') @mock.patch('nova_powervm.virt.powervm.vm.power_on') def test_spawn_with_root_bdm(self, mock_pwron, mock_cfg_drv, mock_plug_vifs, mock_plug_mgmt_vif, mock_boot_from_vol, mock_crt_img, mock_save): """Validates the PowerVM spawn. Specific test: when no image is given and only block device mappings are given on the create server request. """ # Set up the mocks to the tasks. mock_cfg_drv.return_value = False mock_boot_from_vol.return_value = True # Create some fake BDMs block_device_info = self._fake_bdms() # Invoke the method. self.drv.spawn('context', self.inst, powervm.IMAGE1, 'injected_files', 'admin_password', {}, block_device_info=block_device_info) self.assertTrue(mock_boot_from_vol.called) # Since the root device is in the BDMs we do not expect the image disk # to be created. self.assertFalse(mock_crt_img.called) # Create LPAR was called self.crt_lpar.assert_called_with(self.apt, self.drv.host_wrapper, self.inst, nvram=None, slot_mgr=self.slot_mgr) # Power on was called mock_pwron.assert_called_once_with(self.apt, self.inst, opts=mock.ANY) # Check that the connect volume was called self.assertEqual(2, self.vol_drv.connect_volume.call_count) # Make sure the BDM save was invoked twice. self.assertEqual(2, mock_save.call_count) self.scrub_stg.assert_called_with(mock.ANY, self.stg_ftsk, lpars_exist=True) @mock.patch('nova_powervm.virt.powervm.tasks.storage.' 'CreateAndConnectCfgDrive') @mock.patch('nova_powervm.virt.powervm.tasks.storage.ConnectVolume') @mock.patch('nova_powervm.virt.powervm.tasks.storage.ConnectDisk') @mock.patch('nova_powervm.virt.powervm.tasks.storage.FindDisk') @mock.patch('nova.virt.powervm_ext.driver.PowerVMDriver.' '_is_booted_from_volume') @mock.patch('nova_powervm.virt.powervm.tasks.network.PlugMgmtVif') @mock.patch('nova_powervm.virt.powervm.tasks.network.PlugVifs') @mock.patch('nova.virt.configdrive.required_by') @mock.patch('nova_powervm.virt.powervm.tasks.vm.PowerOn') @mock.patch('nova_powervm.virt.powervm.driver.PowerVMDriver._vol_drv_iter') @mock.patch('nova_powervm.virt.powervm.slot.build_slot_mgr') @mock.patch('taskflow.patterns.linear_flow.Flow') @mock.patch('nova_powervm.virt.powervm.tasks.base.run') def test_spawn_recreate(self, mock_tf_run, mock_flow, mock_build_slot_mgr, mock_vol_drv_iter, mock_pwron, mock_cfg_drv, mock_plug_vifs, mock_plug_mgmt_vif, mock_boot_from_vol, mock_find_disk, mock_conn_disk, mock_conn_vol, mock_crt_cfg_drv): """Validates the 'recreate' spawn flow. Uses a basic disk image, attaching networks and powering on. """ # Set up the mocks to the tasks. self.drv.nvram_mgr = mock.Mock() self.drv.nvram_mgr.fetch.return_value = 'nvram data' mock_cfg_drv.return_value = False mock_boot_from_vol.return_value = False # Some tasks are mocked; some are not. Have Flow.add "execute" them so # we can verify the code thereunder. mock_flow.return_value.add.side_effect = lambda task: task.execute() self.inst.task_state = task_states.REBUILD_SPAWNING # Invoke the method. self.drv.spawn('context', self.inst, powervm.EMPTY_IMAGE, 'injected_files', 'admin_password', {}) xags = {pvm_const.XAG.VIO_FMAP, pvm_const.XAG.VIO_SMAP, pvm_const.XAG.VIO_STOR} calls = [mock.call(self.drv.adapter, xag=xags), mock.call(self.drv.adapter, name='create_scrubber', xag=xags - {pvm_const.XAG.VIO_STOR})] # Recreate uses all XAGs, builds special FeedTask for immediate # scrubbing. self.build_tx_feed.assert_has_calls(calls) # _vol_drv_iter gets called once in spawn itself, and once under # _add_volume_connection_tasks. # TODO(IBM): Find a way to make the call just once. Unless it's cheap. mock_vol_drv_iter.assert_has_calls([mock.call( self.inst, [], stg_ftsk=self.build_tx_feed.return_value)] * 2) mock_build_slot_mgr.assert_called_once_with( self.inst, self.drv.store_api, adapter=self.drv.adapter, vol_drv_iter=mock_vol_drv_iter.return_value) # Assert the correct tasks were called mock_plug_vifs.assert_called_once_with( self.drv.virtapi, self.drv.adapter, self.inst, None, self.drv.host_uuid, mock_build_slot_mgr.return_value) mock_plug_mgmt_vif.assert_called_once_with( self.drv.adapter, self.inst, self.drv.host_uuid, mock_build_slot_mgr.return_value) self.assertTrue(mock_plug_mgmt_vif.called) self.assertTrue(mock_find_disk.called) self.crt_lpar.assert_called_with( self.apt, self.drv.host_wrapper, self.inst, nvram='nvram data', slot_mgr=mock_build_slot_mgr.return_value) # SaveSlotStore.execute mock_build_slot_mgr.return_value.save.assert_called_once_with() self.assertTrue(mock_pwron.called) # Assert that tasks that are not supposed to be called are not called self.assertFalse(mock_conn_vol.called) self.assertFalse(mock_crt_cfg_drv.called) self.scrub_stg.assert_called_with(mock.ANY, self.stg_ftsk, lpars_exist=True) @mock.patch('nova.virt.block_device.DriverVolumeBlockDevice.save') @mock.patch('nova_powervm.virt.powervm.tasks.network.PlugMgmtVif.execute') @mock.patch('nova_powervm.virt.powervm.tasks.network.PlugVifs.execute') @mock.patch('nova_powervm.virt.powervm.vm.delete_lpar') @mock.patch('nova.virt.configdrive.required_by') @mock.patch('nova_powervm.virt.powervm.vm.power_on') @mock.patch('nova_powervm.virt.powervm.vm.power_off') def test_spawn_ops_rollback(self, mock_pwroff, mock_pwron, mock_cfg_drv, mock_dlt, mock_plug_vifs, mock_plug_mgmt_vifs, mock_save): """Validates the PowerVM driver operations. Will do a rollback.""" # Set up the mocks to the tasks. mock_cfg_drv.return_value = False block_device_info = self._fake_bdms() # Make sure power on fails. mock_pwron.side_effect = exc.Forbidden() # Invoke the method. self.assertRaises(exc.Forbidden, self.drv.spawn, 'context', self.inst, powervm.IMAGE1, 'injected_files', 'admin_password', {}, block_device_info=block_device_info) # Create LPAR was called self.crt_lpar.assert_called_with(self.apt, self.drv.host_wrapper, self.inst, nvram=None, slot_mgr=self.slot_mgr) self.assertEqual(2, self.vol_drv.connect_volume.call_count) # Power on was called mock_pwron.assert_called_once_with(self.apt, self.inst, opts=mock.ANY) # Validate the rollbacks were called self.assertEqual(2, self.vol_drv.disconnect_volume.call_count) @mock.patch('nova.virt.block_device.DriverVolumeBlockDevice.save') @mock.patch('nova_powervm.virt.powervm.tasks.storage.CreateDiskForImg.' 'execute') @mock.patch('nova.virt.powervm_ext.driver.PowerVMDriver.' '_is_booted_from_volume') @mock.patch('nova_powervm.virt.powervm.tasks.network.PlugMgmtVif.execute') @mock.patch('nova_powervm.virt.powervm.tasks.network.PlugVifs.execute') @mock.patch('nova.virt.configdrive.required_by') @mock.patch('nova_powervm.virt.powervm.tasks.vm.UpdateIBMiSettings.' 'execute') @mock.patch('nova.virt.powervm_ext.driver.PowerVMDriver.' '_get_boot_connectivity_type') @mock.patch('nova_powervm.virt.powervm.vm.power_on') def test_spawn_ibmi(self, mock_pwron, mock_boot_conn_type, mock_update_lod_src, mock_cfg_drv, mock_plug_vifs, mock_plug_mgmt_vif, mock_boot_from_vol, mock_crt_img, mock_save): """Validates the PowerVM spawn to create an IBMi server.""" # Set up the mocks to the tasks. mock_cfg_drv.return_value = False mock_boot_from_vol.return_value = True mock_boot_conn_type.return_value = 'vscsi' # Create some fake BDMs block_device_info = self._fake_bdms() # Invoke the method. self.drv.spawn('context', self.inst_ibmi, powervm.IMAGE1, 'injected_files', 'admin_password', {}, block_device_info=block_device_info) self.assertTrue(mock_boot_from_vol.called) # Since the root device is in the BDMs we do not expect the image disk # to be created. self.assertFalse(mock_crt_img.called) # Create LPAR was called self.crt_lpar.assert_called_with(self.apt, self.drv.host_wrapper, self.inst_ibmi, nvram=None, slot_mgr=self.slot_mgr) self.assertTrue(mock_boot_conn_type.called) self.assertTrue(mock_update_lod_src.called) # Power on was called mock_pwron.assert_called_once_with(self.apt, self.inst_ibmi, opts=mock.ANY) # Check that the connect volume was called self.assertEqual(2, self.vol_drv.connect_volume.call_count) # Make sure the BDM save was invoked twice. self.assertEqual(2, mock_save.call_count) @mock.patch('nova_powervm.virt.powervm.tasks.storage.' 'CreateAndConnectCfgDrive.execute') @mock.patch('nova_powervm.virt.powervm.tasks.storage.ConnectVolume' '.execute') @mock.patch('nova_powervm.virt.powervm.tasks.storage.CreateDiskForImg' '.execute') @mock.patch('nova.virt.powervm_ext.driver.PowerVMDriver.' '_is_booted_from_volume') @mock.patch('nova_powervm.virt.powervm.tasks.network.PlugMgmtVif.execute') @mock.patch('nova_powervm.virt.powervm.tasks.network.PlugVifs.execute') @mock.patch('nova.virt.configdrive.required_by') @mock.patch('nova_powervm.virt.powervm.tasks.vm.UpdateIBMiSettings' '.execute') @mock.patch('nova.virt.powervm_ext.driver.PowerVMDriver.' '_get_boot_connectivity_type') @mock.patch('nova_powervm.virt.powervm.vm.power_on') def test_spawn_ibmi_without_bdms(self, mock_pwron, mock_boot_conn_type, mock_update_lod_src, mock_cfg_drv, mock_plug_vifs, mock_plug_mgmt_vif, mock_boot_from_vol, mock_crt_disk_img, mock_conn_vol, mock_crt_cfg_drv): """Validates the 'typical' spawn flow for IBMi Perform an UT using an image with local disk, attaching networks and powering on. """ # Set up the mocks to the tasks. mock_cfg_drv.return_value = False mock_boot_from_vol.return_value = False mock_boot_conn_type.return_value = 'vscsi' # Invoke the method. self.drv.spawn('context', self.inst_ibmi, powervm.IMAGE1, 'injected_files', 'admin_password', {}) # Assert the correct tasks were called self.assertTrue(mock_plug_vifs.called) self.assertTrue(mock_plug_mgmt_vif.called) self.assertTrue(mock_crt_disk_img.called) self.crt_lpar.assert_called_with( self.apt, self.drv.host_wrapper, self.inst_ibmi, nvram=None, slot_mgr=self.slot_mgr) self.assertTrue(mock_update_lod_src.called) mock_pwron.assert_called_once_with(self.apt, self.inst_ibmi, opts=mock.ANY) # Assert that tasks that are not supposed to be called are not called self.assertFalse(mock_conn_vol.called) self.assertFalse(mock_crt_cfg_drv.called) @mock.patch('nova_powervm.virt.powervm.disk.localdisk.LocalStorage.' 'delete_disks') @mock.patch('nova_powervm.virt.powervm.tasks.storage.CreateDiskForImg.' 'execute') @mock.patch('nova_powervm.virt.powervm.tasks.network.PlugMgmtVif.execute') @mock.patch('nova_powervm.virt.powervm.tasks.network.PlugVifs.execute') @mock.patch('nova_powervm.virt.powervm.vm.delete_lpar') @mock.patch('nova.virt.configdrive.required_by') def test_spawn_ops_rollback_disk(self, mock_cfg_drv, mock_dlt, mock_plug_vifs, mock_plug_mgmt_vifs, mock_crt_disk, mock_delete_disks): """Validates the rollback if failure occurs on disk create.""" # Set up the mocks to the tasks. mock_cfg_drv.return_value = False # Make sure power on fails. mock_crt_disk.side_effect = exc.Forbidden() # Invoke the method. self.assertRaises(exc.Forbidden, self.drv.spawn, 'context', self.inst, powervm.IMAGE1, 'injected_files', 'admin_password', {}, block_device_info=None) # Create LPAR was called self.crt_lpar.assert_called_with(self.apt, self.drv.host_wrapper, self.inst, nvram=None, slot_mgr=self.slot_mgr) # Since the create disks method failed, the delete disks should not # have been called self.assertFalse(mock_delete_disks.called) @mock.patch('nova.virt.block_device.DriverVolumeBlockDevice.save') @mock.patch('nova_powervm.virt.powervm.tasks.network.PlugMgmtVif.execute') @mock.patch('nova_powervm.virt.powervm.tasks.network.PlugVifs.execute') @mock.patch('nova_powervm.virt.powervm.vm.delete_lpar') @mock.patch('nova.virt.configdrive.required_by') @mock.patch('pypowervm.tasks.power.power_on') @mock.patch('pypowervm.tasks.power.power_off') def test_spawn_ops_rollback_on_vol_connect(self, mock_pwroff, mock_pwron, mock_cfg_drv, mock_dlt, mock_plug_vifs, mock_plug_mgmt_vifs, mock_save): """Validates the rollbacks on a volume connect failure.""" # Set up the mocks to the tasks. mock_cfg_drv.return_value = False block_device_info = self._fake_bdms() # Have the connect fail. Also fail the disconnect on revert. Should # not block the rollback. self.vol_drv.connect_volume.side_effect = exc.Forbidden() self.vol_drv.disconnect_volume.side_effect = p_exc.VolumeDetachFailed( volume_id='1', instance_name=self.inst.name, reason='Test Case') # Invoke the method. self.assertRaises(exc.Forbidden, self.drv.spawn, 'context', self.inst, powervm.IMAGE1, 'injected_files', 'admin_password', {}, block_device_info=block_device_info) # Create LPAR was called self.crt_lpar.assert_called_with(self.apt, self.drv.host_wrapper, self.inst, nvram=None, slot_mgr=self.slot_mgr) self.assertEqual(1, self.vol_drv.connect_volume.call_count) # Power on should not be called. Shouldn't get that far in flow. self.assertFalse(mock_pwron.called) # Disconnect should, as it may need to remove from one of the VIOSes # (but maybe failed on another). self.assertTrue(self.vol_drv.disconnect_volume.called) @mock.patch('nova.block_device.get_root_bdm', autospec=True) @mock.patch('nova.virt.driver.block_device_info_get_mapping', autospec=True) def test_is_booted_from_volume(self, mock_get_mapping, mock_get_root_bdm): block_device_info = self._fake_bdms() ret = self.drv._is_booted_from_volume(block_device_info) mock_get_root_bdm.assert_called_once_with( mock_get_mapping.return_value) self.assertTrue(ret) self.assertEqual(1, mock_get_mapping.call_count) mock_get_mapping.reset_mock() mock_get_root_bdm.return_value = None ret = self.drv._is_booted_from_volume(block_device_info) self.assertFalse(ret) self.assertEqual(1, mock_get_mapping.call_count) # Test if block_device_info is None ret = self.drv._is_booted_from_volume(None) self.assertFalse(ret) def test_get_inst_xag(self): # No volumes - should be just the SCSI mapping xag = self.drv._get_inst_xag(mock.Mock(), None) self.assertEqual([pvm_const.XAG.VIO_SMAP], xag) # The vSCSI Volume attach - only needs the SCSI mapping. self.flags(fc_attach_strategy='vscsi', group='powervm') mock_bdm = {'connection_info': {'driver_volume_type': 'fibre_channel'}} xag = self.drv._get_inst_xag(mock.Mock(), [mock_bdm]) self.assertEqual([pvm_const.XAG.VIO_SMAP], xag) # The NPIV volume attach - requires SCSI, Storage and FC Mapping self.flags(fc_attach_strategy='npiv', group='powervm') xag = self.drv._get_inst_xag(mock.Mock(), [mock_bdm]) self.assertEqual({pvm_const.XAG.VIO_STOR, pvm_const.XAG.VIO_SMAP, pvm_const.XAG.VIO_FMAP}, set(xag)) # The vSCSI Volume attach - Ensure case insensitive. self.flags(fc_attach_strategy='VSCSI', group='powervm') xag = self.drv._get_inst_xag(mock.Mock(), [mock_bdm]) self.assertEqual([pvm_const.XAG.VIO_SMAP], xag) # Validate the other volume types only return SCSI mappings vol_types = ['iscsi', 'gpfs', 'local', 'nfs'] for vol_type in vol_types: mock_bdm = {'connection_info': {'driver_volume_type': vol_type}} xag = self.drv._get_inst_xag(mock.Mock(), [mock_bdm]) self.assertEqual([pvm_const.XAG.VIO_SMAP], xag) # If a recreate, all should be returned xag = self.drv._get_inst_xag(mock.Mock(), [mock_bdm], recreate=True) self.assertEqual({pvm_const.XAG.VIO_STOR, pvm_const.XAG.VIO_SMAP, pvm_const.XAG.VIO_FMAP}, set(xag)) @mock.patch('nova_powervm.virt.powervm.tasks.storage.ConnectVolume', autospec=True) @mock.patch('nova_powervm.virt.powervm.tasks.storage.SaveBDM', autospec=True) def test_add_vol_conn_task(self, mock_save_bdm, mock_conn_vol): bdm1, bdm2, vol_drv1, vol_drv2 = [mock.Mock()] * 4 flow = mock.Mock() mock_save_bdm.side_effect = 'save_bdm1', 'save_bdm2' mock_conn_vol.side_effect = 'conn_vol1', 'conn_vol2' vals = [(bdm1, vol_drv1), (bdm2, vol_drv2)] with mock.patch.object(self.drv, '_vol_drv_iter', return_value=vals) as mock_vdi: self.drv._add_volume_connection_tasks( 'context', 'instance', 'bdms', flow, 'stg_ftsk', 'slot_mgr') mock_vdi.assert_called_once_with('instance', 'bdms', stg_ftsk='stg_ftsk') mock_conn_vol.assert_has_calls([mock.call(vol_drv1, 'slot_mgr'), mock.call(vol_drv2, 'slot_mgr')]) mock_save_bdm.assert_has_calls([mock.call(bdm1, 'instance'), mock.call(bdm2, 'instance')]) flow.add.assert_has_calls([ mock.call('conn_vol1'), mock.call('save_bdm1'), mock.call('conn_vol2'), mock.call('save_bdm2')]) @mock.patch('nova_powervm.virt.powervm.tasks.storage.DisconnectVolume', autospec=True) def test_add_vol_disconn_task(self, mock_disconn_vol): vol_drv1, vol_drv2 = [mock.Mock()] * 2 flow = mock.Mock() mock_disconn_vol.side_effect = 'disconn_vol1', 'disconn_vol2' vals = [('bdm', vol_drv1), ('bdm', vol_drv2)] with mock.patch.object(self.drv, '_vol_drv_iter', return_value=vals) as mock_vdi: self.drv._add_volume_disconnection_tasks( 'context', 'instance', 'bdms', flow, 'stg_ftsk', 'slot_mgr') mock_vdi.assert_called_once_with('instance', 'bdms', stg_ftsk='stg_ftsk') mock_disconn_vol.assert_has_calls([mock.call(vol_drv1, 'slot_mgr'), mock.call(vol_drv2, 'slot_mgr')]) flow.add.assert_has_calls([mock.call('disconn_vol1'), mock.call('disconn_vol2')]) @mock.patch('nova_powervm.virt.powervm.driver.PowerVMDriver.' '_is_booted_from_volume', new=mock.Mock(return_value=False)) def test_get_boot_connectivity_type_no_bfv(self): # Boot connectivity type defaults to vscsi when not booted from volume. self.assertEqual('vscsi', self.drv._get_boot_connectivity_type( 'bdms', 'block_device_info')) @mock.patch('nova_powervm.virt.powervm.driver.PowerVMDriver.' '_is_booted_from_volume', new=mock.Mock(return_value=True)) def test_get_boot_connectivity_type_no_bdms(self): # Boot connectivity type defaults to vscsi when no BDMs self.assertEqual('vscsi', self.drv._get_boot_connectivity_type( None, 'block_device_info')) @mock.patch('nova_powervm.virt.powervm.driver.PowerVMDriver.' '_is_booted_from_volume', new=mock.Mock(return_value=True)) def test_get_boot_connectivity_type_no_boot_bdm(self): # Boot connectivity type defaults to vscsi when no BDM has a boot_index # of zero (which should actually never happen IRL). self.assertEqual('vscsi', self.drv._get_boot_connectivity_type( [{'boot_index': 1}], 'block_device_info')) @mock.patch('nova_powervm.virt.powervm.driver.PowerVMDriver.' '_is_booted_from_volume', new=mock.Mock(return_value=True)) def test_get_boot_connectivity_type_driver_volume_type(self): # Boot connectivity type discovered via BDM driver_volume_type. bdms = self._fake_bdms(set_boot_index=True)['block_device_mapping'] self.assertEqual('fibre_channel', self.drv._get_boot_connectivity_type( bdms, 'block_device_info')) @mock.patch('nova_powervm.virt.powervm.driver.PowerVMDriver.' '_is_booted_from_volume', new=mock.Mock(return_value=True)) def test_get_boot_connectivity_type_data_driver_volume_type(self): # Boot connectivity type discovered via BDM driver_volume_type in # conn_info['data'], which I think is bogus, but preserved for # compatibility. bdms = self._fake_bdms( set_boot_index=True, driver_volume_type_in_data=True)['block_device_mapping'] self.assertEqual('fibre_channel', self.drv._get_boot_connectivity_type( bdms, 'block_device_info')) @mock.patch('nova_powervm.virt.powervm.driver.PowerVMDriver.' '_is_booted_from_volume', new=mock.Mock(return_value=True)) def test_get_boot_connectivity_type_connection_type(self): # Boot connectivity type discovered from BDM's connectivity-type bdms = self._fake_bdms(connection_type='hello', set_boot_index=True)['block_device_mapping'] self.assertEqual('hello', self.drv._get_boot_connectivity_type( bdms, 'block_device_info')) # We convert 'pv_vscsi' to 'vscsi' bdms = self._fake_bdms(connection_type='pv_vscsi', set_boot_index=True)['block_device_mapping'] self.assertEqual('vscsi', self.drv._get_boot_connectivity_type( bdms, 'block_device_info')) @mock.patch('nova_powervm.virt.powervm.driver.PowerVMDriver.' '_is_booted_from_volume', new=mock.Mock(return_value=True)) def test_get_boot_connectivity_type_driver_volume_type_unset(self): # Boot connectivity type defaults to vscsi when BDM driver_volume_type # is unset. bdms = self._fake_bdms(driver_volume_type=None, set_boot_index=True)['block_device_mapping'] self.assertEqual('vscsi', self.drv._get_boot_connectivity_type( bdms, 'block_device_info')) @mock.patch('pypowervm.tasks.scsi_mapper.remove_maps') @mock.patch('pypowervm.wrappers.entry_wrapper.EntryWrapper.update', new=mock.Mock()) @mock.patch('nova_powervm.virt.powervm.tasks.network.UnplugVifs.execute') @mock.patch('nova.virt.powervm_ext.driver.PowerVMDriver.' '_is_booted_from_volume') @mock.patch('nova_powervm.virt.powervm.vm.delete_lpar') @mock.patch('nova_powervm.virt.powervm.vm.power_off') @mock.patch('nova_powervm.virt.powervm.media.ConfigDrivePowerVM.' 'dlt_vopt') @mock.patch('nova_powervm.virt.powervm.vm.get_pvm_uuid') @mock.patch('nova.virt.configdrive.required_by') @mock.patch('nova_powervm.virt.powervm.slot.build_slot_mgr') def test_destroy_internal( self, mock_bld_slot_mgr, mock_cfg, mock_pvmuuid, mock_dlt_vopt, mock_pwroff, mock_dlt, mock_boot_from_vol, mock_unplug_vifs, mock_rm_maps): """Validates the basic PowerVM destroy.""" # NVRAM Manager self.drv.nvram_mgr = mock.Mock() mock_cfg.return_value = True # BDMs mock_bdms = self._fake_bdms() mock_boot_from_vol.return_value = False def validate_rm_maps(vwrap, lpar_uuid): self.assertIsInstance(vwrap, pvm_vios.VIOS) self.assertEqual(mock_pvmuuid.return_value, lpar_uuid) mock_rm_maps.side_effect = validate_rm_maps # Invoke the method. self.drv.destroy('context', self.inst, ['net'], block_device_info=mock_bdms) # Power off was called mock_pwroff.assert_called_with(self.drv.adapter, self.inst, force_immediate=True) mock_bld_slot_mgr.assert_called_once_with(self.inst, self.drv.store_api) # Unplug should have been called # TODO(IBM): Find a way to verify UnplugVifs(..., slot_mgr) self.assertTrue(mock_unplug_vifs.called) # Validate that the vopt delete was called self.assertTrue(mock_dlt_vopt.called) # Validate that the volume detach was called self.vol_drv.disconnect_volume.assert_has_calls( [mock.call(mock_bld_slot_mgr.return_value)] * 2) # Post-scrub was invoked mock_rm_maps.assert_called() # Delete LPAR was called mock_dlt.assert_called_with(self.apt, mock.ANY) # Validate root device in bdm was checked. mock_boot_from_vol.assert_called_with(mock_bdms) # Validate disk driver detach and delete disk methods were called. self.assertTrue(self.drv.disk_dvr.delete_disks.called) self.assertTrue(self.drv.disk_dvr.disconnect_disk.called) # NVRAM was deleted self.drv.nvram_mgr.remove.assert_called_once_with(self.inst) # Slot store was deleted mock_bld_slot_mgr.return_value.delete.assert_called_once_with() def reset_mocks(): # Reset the mocks for mk in [mock_pwroff, mock_dlt, mock_dlt_vopt, self.vol_drv, mock_dlt, mock_boot_from_vol]: mk.reset_mock() def assert_not_called(): # Power off was not called self.assertFalse(mock_pwroff.called) # Validate that the vopt delete was not called self.assertFalse(mock_dlt_vopt.called) # Validate that the volume detach was not called self.assertFalse(self.vol_drv.disconnect_volume.called) # Delete LPAR was not called self.assertFalse(mock_dlt.called) # Test when the VM's root device is a BDM. reset_mocks() mock_boot_from_vol.return_value = True self.drv.disk_dvr.delete_disks.reset_mock() self.drv.disk_dvr.disconnect_disk.reset_mock() # Invoke the method. self.drv.destroy('context', self.inst, None, block_device_info=mock_bdms) # Validate root device in bdm was checked. mock_boot_from_vol.assert_called_with(mock_bdms) # Validate disk driver detach and delete disk methods were called. self.assertFalse(self.drv.disk_dvr.delete_disks.called) self.assertFalse(self.drv.disk_dvr.disconnect_disk.called) # Test when destroy_disks set to False. reset_mocks() mock_boot_from_vol.return_value = True self.drv.disk_dvr.delete_disks.reset_mock() self.drv.disk_dvr.disconnect_disk.reset_mock() # Invoke the method. self.drv.destroy('context', self.inst, None, block_device_info=mock_bdms, destroy_disks=False) mock_pwroff.assert_called_with(self.drv.adapter, self.inst, force_immediate=False) # Start negative tests reset_mocks() # Pretend we didn't find the VM on the system mock_pvmuuid.side_effect = exc.InstanceNotFound( instance_id=self.inst.name) # Invoke the method. self.drv.destroy('context', self.inst, None, block_device_info=mock_bdms) assert_not_called() reset_mocks() # Test generic exception mock_pvmuuid.side_effect = ValueError('Some error') # Invoke the method. self.assertRaises(exc.InstanceTerminationFailure, self.drv.destroy, 'context', self.inst, [], block_device_info=mock_bdms) assert_not_called() @mock.patch('pypowervm.tasks.scsi_mapper.remove_maps') @mock.patch('nova_powervm.virt.powervm.tasks.network.UnplugVifs.execute') @mock.patch('nova.virt.powervm_ext.driver.PowerVMDriver.' '_is_booted_from_volume') @mock.patch('nova_powervm.virt.powervm.vm.delete_lpar') @mock.patch('nova_powervm.virt.powervm.vm.power_off') @mock.patch('nova_powervm.virt.powervm.media.ConfigDrivePowerVM.' 'dlt_vopt') @mock.patch('nova_powervm.virt.powervm.vm.get_pvm_uuid') @mock.patch('nova.virt.configdrive.required_by') @mock.patch('nova_powervm.virt.powervm.slot.build_slot_mgr') def test_destroy_internal_no_nvram_cleanup( self, mock_bld_slot_mgr, mock_cfg, mock_pvmuuid, mock_dlt_vopt, mock_pwroff, mock_dlt, mock_boot_from_vol, mock_unplug_vifs, mock_rm_maps): """Validates the basic PowerVM destroy, without NVRAM cleanup. Used to validate the behavior when destroying evacuated instances. It should not clean up NVRAM as the instance is still on another host. """ mock_rm_maps.return_value = [] # NVRAM Manager self.drv.nvram_mgr = mock.Mock() self.inst.host = 'other' mock_cfg.return_value = True # BDMs mock_bdms = self._fake_bdms() mock_boot_from_vol.return_value = False # Invoke the method. self.drv.destroy('context', self.inst, ['net'], block_device_info=mock_bdms) # Power off was called mock_pwroff.assert_called_with(self.drv.adapter, self.inst, force_immediate=True) mock_bld_slot_mgr.assert_called_once_with(self.inst, self.drv.store_api) # Unplug should have been called # TODO(IBM): Find a way to verify UnplugVifs(..., slot_mgr) self.assertTrue(mock_unplug_vifs.called) # Validate that the vopt delete was called self.assertTrue(mock_dlt_vopt.called) # Validate that the volume detach was called self.vol_drv.disconnect_volume.assert_has_calls( [mock.call(mock_bld_slot_mgr.return_value)] * 2) # Delete LPAR was called mock_dlt.assert_called_with(self.apt, mock.ANY) # Validate root device in bdm was checked. mock_boot_from_vol.assert_called_with(mock_bdms) # Validate disk driver detach and delete disk methods were called. self.assertTrue(self.drv.disk_dvr.delete_disks.called) self.assertTrue(self.drv.disk_dvr.disconnect_disk.called) # NVRAM was NOT deleted self.assertFalse(self.drv.nvram_mgr.remove.called) self.assertFalse(mock_bld_slot_mgr.return_value.delete.called) @mock.patch('nova_powervm.virt.powervm.vm.get_pvm_uuid', autospec=True) @mock.patch('nova_powervm.virt.powervm.vm.get_vm_qp', autospec=True) def test_destroy(self, mock_getqp, mock_getuuid): """Validates the basic PowerVM destroy.""" # BDMs mock_bdms = self._fake_bdms() with mock.patch.object(self.drv, '_destroy') as mock_dst_int: # Invoke the method. self.drv.destroy('context', self.inst, [], block_device_info=mock_bdms) mock_dst_int.assert_called_with( 'context', self.inst, block_device_info=mock_bdms, destroy_disks=True, shutdown=True, network_info=[]) self.san_lpar_name.assert_not_called() # Test delete during migrate / resize self.inst.task_state = task_states.RESIZE_REVERTING mock_getqp.return_value = 'resize_' + self.inst.name with mock.patch.object(self.drv, '_destroy') as mock_dst_int: # Invoke the method. self.drv.destroy('context', self.inst, [], block_device_info=mock_bdms) # We shouldn't delete our resize_ instances mock_dst_int.assert_not_called() self.san_lpar_name.assert_called_with('resize_' + self.inst.name) self.san_lpar_name.reset_mock() # Now test migrating... mock_getqp.return_value = 'migrate_' + self.inst.name with mock.patch.object(self.drv, '_destroy') as mock_dst_int: # Invoke the method. self.drv.destroy('context', self.inst, [], block_device_info=mock_bdms) # If it is a migrated instance, it should be deleted. mock_dst_int.assert_called_with( 'context', self.inst, block_device_info=mock_bdms, destroy_disks=True, shutdown=True, network_info=[]) @mock.patch('nova_powervm.virt.powervm.slot.build_slot_mgr', autospec=True) def test_attach_volume(self, mock_bld_slot_mgr): """Validates the basic PowerVM attach volume.""" # BDMs mock_bdm = self._fake_bdms()['block_device_mapping'][0] with mock.patch.object(self.inst, 'save') as mock_save: # Invoke the method. self.drv.attach_volume('context', mock_bdm.get('connection_info'), self.inst, mock.sentinel.stg_ftsk) mock_bld_slot_mgr.assert_called_once_with(self.inst, self.drv.store_api) # Verify the connect volume was invoked self.vol_drv.connect_volume.assert_called_once_with( mock_bld_slot_mgr.return_value) mock_bld_slot_mgr.return_value.save.assert_called_once_with() mock_save.assert_called_once_with() @mock.patch('nova_powervm.virt.powervm.vm.instance_exists', autospec=True) @mock.patch('nova_powervm.virt.powervm.slot.build_slot_mgr', autospec=True) def test_detach_volume(self, mock_bld_slot_mgr, mock_inst_exists): """Validates the basic PowerVM detach volume.""" # Mock that the instance exists for the first test, then not. mock_inst_exists.side_effect = [True, False, False] # BDMs mock_bdm = self._fake_bdms()['block_device_mapping'][0] # Invoke the method, good path test. self.drv.detach_volume('context', mock_bdm.get('connection_info'), self.inst, mock.sentinel.stg_ftsk) mock_bld_slot_mgr.assert_called_once_with(self.inst, self.drv.store_api) # Verify the disconnect volume was invoked self.vol_drv.disconnect_volume.assert_called_once_with( mock_bld_slot_mgr.return_value) mock_bld_slot_mgr.return_value.save.assert_called_once_with() # Invoke the method, instance doesn't exist, no migration self.vol_drv.disconnect_volume.reset_mock() self.drv.detach_volume('context', mock_bdm.get('connection_info'), self.inst, mock.sentinel.stg_ftsk) # Verify the disconnect volume was not invoked self.assertEqual(0, self.vol_drv.disconnect_volume.call_count) # Test instance doesn't exist, migration cleanup self.vol_drv.disconnect_volume.reset_mock() mig = lpm.LiveMigrationDest(self.drv, self.inst) self.drv.live_migrations[self.inst.uuid] = mig with mock.patch.object(mig, 'cleanup_volume') as mock_clnup: self.drv.detach_volume('context', mock_bdm.get('connection_info'), self.inst, mock.sentinel.stg_ftsk) # The cleanup should have been called since there was a migration self.assertEqual(1, mock_clnup.call_count) # Verify the disconnect volume was not invoked self.assertEqual(0, self.vol_drv.disconnect_volume.call_count) @mock.patch('pypowervm.tasks.scsi_mapper.remove_maps') @mock.patch('nova_powervm.virt.powervm.tasks.network.UnplugVifs.execute') @mock.patch('nova_powervm.virt.powervm.vm.delete_lpar') @mock.patch('nova_powervm.virt.powervm.vm.power_off') @mock.patch('nova_powervm.virt.powervm.media.ConfigDrivePowerVM.' 'dlt_vopt') @mock.patch('nova.virt.configdrive.required_by') def test_destroy_rollback(self, mock_cfg, mock_dlt_vopt, mock_pwroff, mock_dlt, mock_unplug_vifs, mock_rm_maps): """Validates the basic PowerVM destroy rollback mechanism works.""" # Set up the mocks to the tasks. mock_rm_maps.return_value = [] mock_cfg.return_value = True # BDMs mock_bdms = self._fake_bdms() # Fire a failure in the power off. mock_dlt.side_effect = exc.Forbidden() # Have the connect volume fail on the rollback. Should not block the # full rollback. self.vol_drv.connect_volume.side_effect = p_exc.VolumeAttachFailed( volume_id='1', instance_name=self.inst.name, reason='Test Case') # Invoke the method. self.assertRaises(exc.InstanceTerminationFailure, self.drv.destroy, 'context', self.inst, [], block_device_info=mock_bdms) # Validate that the vopt delete was called self.assertTrue(mock_dlt_vopt.called) self.assertTrue(mock_unplug_vifs.called) # Validate that the volume detach was called self.assertEqual(2, self.vol_drv.disconnect_volume.call_count) # Delete LPAR was called mock_dlt.assert_called_with(self.apt, mock.ANY) # Validate the rollbacks were called. self.assertEqual(2, self.vol_drv.connect_volume.call_count) @mock.patch('nova_powervm.virt.powervm.slot.build_slot_mgr', autospec=True) def test_migrate_disk_and_power_off(self, mock_bld_slot_mgr): """Validates the PowerVM driver migrate / resize operation.""" # Set up the mocks to the migrate / resize operation. host = self.drv.get_host_ip_addr() resp = pvm_adp.Response('method', 'path', 'status', 'reason', {}) resp.entry = pvm_lpar.LPAR._bld(None).entry self.apt.read.return_value = resp # BDMs mock_bdms = self._fake_bdms() # Catch root disk resize smaller. small_root = objects.Flavor(vcpus=1, memory_mb=2048, root_gb=9) self.assertRaises( exc.InstanceFaultRollback, self.drv.migrate_disk_and_power_off, 'context', self.inst, 'dest', small_root, 'network_info', mock_bdms) # Boot disk resize boot_flav = objects.Flavor(vcpus=1, memory_mb=2048, root_gb=12) # Tasks expected to be added for migrate expected = [ 'pwr_off_vm', 'store_nvram', 'extend_disk_boot', 'disconnect_vol_*', 'disconnect_vol_*', 'fake', 'rename_vm_migrate_instance-00000001', ] dest_host = host + '1' with fx.DriverTaskFlow() as taskflow_fix: self.drv.migrate_disk_and_power_off( 'context', self.inst, dest_host, boot_flav, 'network_info', mock_bdms) taskflow_fix.assert_tasks_added(self, expected) mock_bld_slot_mgr.assert_called_once_with( self.inst, self.drv.store_api, adapter=self.drv.adapter, vol_drv_iter=mock.ANY) # Check the size set in the resize task extend_task = taskflow_fix.tasks_added[ expected.index('extend_disk_boot')] self.assertEqual(extend_task.size, 12) # Ensure slot manager was passed to disconnect self.assertEqual(mock_bld_slot_mgr.return_value, taskflow_fix.tasks_added[3].slot_mgr) self.assertEqual(mock_bld_slot_mgr.return_value, taskflow_fix.tasks_added[4].slot_mgr) self.san_lpar_name.assert_called_with('migrate_' + self.inst.name) @mock.patch('nova_powervm.virt.powervm.slot.build_slot_mgr', autospec=True) def test_finish_migration(self, mock_bld_slot_mgr): mock_bdms = self._fake_bdms() mig = objects.Migration(**powervm.TEST_MIGRATION) mig_same_host = objects.Migration(**powervm.TEST_MIGRATION_SAME_HOST) disk_info = {} # The first test is different hosts but local storage, should fail self.assertRaises(exc.InstanceFaultRollback, self.drv.finish_migration, 'context', mig, self.inst, disk_info, 'network_info', powervm.IMAGE1, 'resize_instance', mock_bdms) # The rest of the test need to pass the shared disk test self.disk_dvr.validate.return_value = None # Tasks expected to be added for migration to different host expected = [ 'crt_vm', 'plug_vifs', 'plug_mgmt_vif', 'find_disk', 'connect_disk', 'connect_vol_*', 'save_bdm_fake_vol1', 'connect_vol_*', 'save_bdm_fake_vol2', 'fake', 'pwr_vm', ] with fx.DriverTaskFlow() as taskflow_fix: self.drv.finish_migration( 'context', mig, self.inst, disk_info, 'network_info', powervm.IMAGE1, 'resize_instance', block_device_info=mock_bdms) mock_bld_slot_mgr.assert_called_once_with( self.inst, self.drv.store_api, adapter=self.drv.adapter, vol_drv_iter=mock.ANY) taskflow_fix.assert_tasks_added(self, expected) # Slot manager was passed to Create, PlugVifs, PlugMgmtVif, and # connect_volume (twice) for idx in (0, 1, 2, 5, 7): self.assertEqual(mock_bld_slot_mgr.return_value, taskflow_fix.tasks_added[idx].slot_mgr) self.san_lpar_name.assert_not_called() mock_bld_slot_mgr.reset_mock() # Tasks expected to be added for resize to the same host expected = [ 'resize_vm', 'connect_vol_*', 'save_bdm_fake_vol1', 'connect_vol_*', 'save_bdm_fake_vol2', 'fake', 'pwr_vm', ] with fx.DriverTaskFlow() as taskflow_fix: self.drv.finish_migration( 'context', mig_same_host, self.inst, disk_info, 'network_info', powervm.IMAGE1, 'resize_instance', block_device_info=mock_bdms) taskflow_fix.assert_tasks_added(self, expected) mock_bld_slot_mgr.assert_called_once_with( self.inst, self.drv.store_api, adapter=self.drv.adapter, vol_drv_iter=mock.ANY) # Slot manager was passed to connect_volume (twice) for idx in (1, 3): self.assertEqual(mock_bld_slot_mgr.return_value, taskflow_fix.tasks_added[idx].slot_mgr) self.san_lpar_name.assert_called_with('resize_' + self.inst.name) self.san_lpar_name.reset_mock() mock_bld_slot_mgr.reset_mock() # Tasks expected to be added for resize to the same host, no BDMS, # and no power_on expected = [ 'resize_vm', ] with fx.DriverTaskFlow() as taskflow_fix: self.drv.finish_migration( 'context', mig_same_host, self.inst, disk_info, 'network_info', powervm.IMAGE1, 'resize_instance', power_on=False) taskflow_fix.assert_tasks_added(self, expected) # Don't need the slot manager on a pure resize (no BDMs and same host) mock_bld_slot_mgr.assert_not_called() self.san_lpar_name.assert_called_with('resize_' + self.inst.name) @mock.patch('nova_powervm.virt.powervm.vm.power_on', autospec=True) @mock.patch('nova_powervm.virt.powervm.vm.update', autospec=True) @mock.patch('nova_powervm.virt.powervm.vm.power_off', autospec=True) def test_finish_revert_migration(self, mock_off, mock_update, mock_on): """Validates that the finish revert migration works.""" mock_instance = mock.Mock() # Validate with a default power on self.drv.finish_revert_migration('context', mock_instance, None) # Asserts mock_off.assert_called_once_with(self.apt, mock_instance) mock_update.assert_called_once_with( self.apt, self.drv.host_wrapper, mock_instance) mock_on.assert_called_once_with(self.apt, mock_instance) @mock.patch('nova_powervm.virt.powervm.vm.power_on', autospec=True) @mock.patch('nova_powervm.virt.powervm.vm.update', autospec=True) @mock.patch('nova_powervm.virt.powervm.vm.power_off', autospec=True) def test_finish_revert_migration_no_power_on(self, mock_off, mock_update, mock_on): """Validates that the finish revert migration works, no power_on.""" mock_instance = mock.Mock() # Validate with power_on set to false self.drv.finish_revert_migration( 'context', mock_instance, None, power_on=False) # Asserts mock_off.assert_called_once_with(self.apt, mock_instance) mock_update.assert_called_once_with( self.apt, self.drv.host_wrapper, mock_instance) self.assertEqual(0, mock_on.call_count) @mock.patch('nova_powervm.virt.powervm.vm.power_off', autospec=True) @mock.patch('nova_powervm.virt.powervm.vm.power_on', autospec=True) def test_rescue(self, mock_pwron, mock_pwroff): """Validates the PowerVM driver rescue operation.""" with mock.patch.object(self.drv, 'disk_dvr') as mock_disk_dvr: # Invoke the method. self.drv.rescue('context', self.inst, mock.MagicMock(), powervm.TEST_IMAGE1, 'rescue_psswd') mock_pwroff.assert_called_once_with(self.apt, self.inst, force_immediate=False) self.assertTrue(mock_disk_dvr.create_disk_from_image.called) self.assertTrue(mock_disk_dvr.connect_disk.called) mock_pwron.assert_called_once_with(self.apt, self.inst, opts=mock.ANY) self.assertEqual('PowerOn(bootmode=sms)', str(mock_pwron.call_args[1]['opts'])) @mock.patch('nova_powervm.virt.powervm.vm.power_off', autospec=True) @mock.patch('nova_powervm.virt.powervm.vm.power_on', autospec=True) def test_unrescue(self, mock_pwron, mock_pwroff): """Validates the PowerVM driver rescue operation.""" with mock.patch.object(self.drv, 'disk_dvr') as mock_disk_dvr: # Invoke the method. self.drv.unrescue(self.inst, 'network_info') mock_pwroff.assert_called_once_with( self.apt, self.inst, force_immediate=False) self.assertTrue(mock_disk_dvr.disconnect_disk.called) self.assertTrue(mock_disk_dvr.delete_disks.called) mock_pwron.assert_called_once_with(self.apt, self.inst, opts=None) @mock.patch('nova_powervm.virt.powervm.driver.LOG', autospec=True) def test_log_op(self, mock_log): """Validates the log_operations.""" self.drv._log_operation('fake_op', self.inst) entry = (r'Operation: %(op)s. Virtual machine display ' 'name: %(display_name)s, name: %(name)s') msg_dict = {'display_name': u'Fake Instance', 'name': 'instance-00000001', 'op': 'fake_op'} mock_log.info.assert_called_with(entry, msg_dict, instance=self.inst) @mock.patch('pypowervm.wrappers.managed_system.System.get', new=mock.Mock(return_value=[mock.Mock()])) @mock.patch('nova_powervm.virt.powervm.host.build_host_resource_from_ms') def test_host_resources(self, mock_bhrfm): mock_bhrfm.return_value = {} stats = self.drv.get_available_resource('nodename') self.assertIsNotNone(stats) # Check for the presence of fields added to host stats fields = ('local_gb', 'local_gb_used') for fld in fields: value = stats.get(fld, None) self.assertIsNotNone(value) @contextlib.contextmanager def _update_provider_tree(self, allocations=None): """Host resource dict gets converted properly to provider tree inv.""" with mock.patch('nova_powervm.virt.powervm.host.' 'build_host_resource_from_ms') as mock_bhrfm: mock_bhrfm.return_value = { 'vcpus': 8, 'memory_mb': 2048, } self.drv.host_wrapper = 'host_wrapper' # Validate that this gets converted to int with floor self.drv.disk_dvr = mock.Mock(capacity=2091.8) exp_inv = { 'VCPU': { 'total': 8, 'max_unit': 8, 'allocation_ratio': 16.0, 'reserved': 0, }, 'MEMORY_MB': { 'total': 2048, 'max_unit': 2048, 'allocation_ratio': 1.5, 'reserved': 512, }, 'DISK_GB': { 'total': 2091, 'max_unit': 2091, 'allocation_ratio': 1.0, 'reserved': 0, }, } ptree = provider_tree.ProviderTree() ptree.new_root('compute_host', uuids.cn) # Let the caller muck with these yield ptree, exp_inv self.drv.update_provider_tree(ptree, 'compute_host', allocations=allocations) self.assertEqual(exp_inv, ptree.data('compute_host').inventory) mock_bhrfm.assert_called_once_with('host_wrapper') def test_update_provider_tree(self): # Basic: no inventory already on the provider, no extra providers, no # aggregates or traits. with self._update_provider_tree(): pass def test_update_provider_tree_ignore_allocations(self): with self._update_provider_tree(allocations="This is ignored"): pass def test_update_provider_tree_conf_overrides(self): # Non-default CONF values for allocation ratios and reserved. self.flags(cpu_allocation_ratio=12.3, reserved_host_cpus=4, ram_allocation_ratio=4.5, reserved_host_memory_mb=32, disk_allocation_ratio=6.7, # This gets int(ceil)'d reserved_host_disk_mb=5432.1) with self._update_provider_tree() as (_, exp_inv): exp_inv['VCPU']['allocation_ratio'] = 12.3 exp_inv['VCPU']['reserved'] = 4 exp_inv['MEMORY_MB']['allocation_ratio'] = 4.5 exp_inv['MEMORY_MB']['reserved'] = 32 exp_inv['DISK_GB']['allocation_ratio'] = 6.7 exp_inv['DISK_GB']['reserved'] = 6 def test_update_provider_tree_complex_ptree(self): # Overrides inventory already on the provider; leaves other providers # and aggregates/traits alone. with self._update_provider_tree() as (ptree, _): ptree.update_inventory('compute_host', { # these should get blown away 'VCPU': { 'total': 16, 'max_unit': 2, 'allocation_ratio': 1.0, 'reserved': 10, }, 'CUSTOM_BOGUS': { 'total': 1234, } }) ptree.update_aggregates('compute_host', [uuids.ss_agg, uuids.other_agg]) ptree.update_traits('compute_host', ['CUSTOM_FOO', 'CUSTOM_BAR']) ptree.new_root('ssp', uuids.ssp) ptree.update_inventory('ssp', {'sentinel': 'inventory', 'for': 'ssp'}) ptree.update_aggregates('ssp', [uuids.ss_agg]) ptree.new_child('sriov', 'compute_host', uuid=uuids.sriov) # Make sure the compute's agg and traits were left alone cndata = ptree.data('compute_host') self.assertEqual(set([uuids.ss_agg, uuids.other_agg]), cndata.aggregates) self.assertEqual(set(['CUSTOM_FOO', 'CUSTOM_BAR']), cndata.traits) # And the other providers were left alone self.assertEqual(set([uuids.cn, uuids.ssp, uuids.sriov]), set(ptree.get_provider_uuids())) # ...including the ssp's aggregates self.assertEqual(set([uuids.ss_agg]), ptree.data('ssp').aggregates) @mock.patch('nova_powervm.virt.powervm.vif.plug_secure_rmc_vif') @mock.patch('nova_powervm.virt.powervm.vif.get_secure_rmc_vswitch') @mock.patch('nova_powervm.virt.powervm.vif.plug') @mock.patch('nova_powervm.virt.powervm.vm.get_cnas') @mock.patch('nova_powervm.virt.powervm.vm.get_instance_wrapper') @mock.patch('nova_powervm.virt.powervm.slot.build_slot_mgr') def test_plug_vifs(self, mock_bld_slot_mgr, mock_wrap, mock_vm_get, mock_plug_vif, mock_get_rmc_vswitch, mock_plug_rmc_vif): # Mock up the CNA response cnas = [mock.MagicMock(), mock.MagicMock()] cnas[0].mac = 'AABBCCDDEEFF' cnas[0].vswitch_uri = 'fake_uri' cnas[1].mac = 'AABBCCDDEE11' cnas[1].vswitch_uri = 'fake_mgmt_uri' mock_vm_get.return_value = cnas mock_lpar_wrapper = mock.MagicMock() mock_lpar_wrapper.can_modify_io = mock.MagicMock( return_value=(True, None)) mock_wrap.return_value = mock_lpar_wrapper # Mock up the network info. They get sanitized to upper case. net_info = [ {'address': 'aa:bb:cc:dd:ee:ff', 'vnic_type': 'normal'}, {'address': 'aa:bb:cc:dd:ee:22', 'vnic_type': 'normal'} ] # Mock up the rmc vswitch vswitch_w = mock.MagicMock() vswitch_w.href = 'fake_mgmt_uri' mock_get_rmc_vswitch.return_value = vswitch_w # Run method self.drv.plug_vifs(self.inst, net_info) mock_bld_slot_mgr.assert_called_once_with(self.inst, self.drv.store_api) # The create should have only been called once. The other was already # existing. mock_plug_vif.assert_called_with( self.drv.adapter, self.drv.host_uuid, self.inst, net_info[1], mock_bld_slot_mgr.return_value, new_vif=True) mock_bld_slot_mgr.return_value.save.assert_called_once_with() self.assertEqual(0, mock_plug_rmc_vif.call_count) @mock.patch('nova_powervm.virt.powervm.tasks.vm.Get', autospec=True) def test_plug_vif_failures(self, mock_vm): # Test instance not found handling mock_vm.execute.side_effect = exc.InstanceNotFound( instance_id=self.inst) # Run method self.assertRaises(exc.VirtualInterfacePlugException, self.drv.plug_vifs, self.inst, {}) # Test a random Exception mock_vm.execute.side_effect = ValueError() # Run method self.assertRaises(exc.VirtualInterfacePlugException, self.drv.plug_vifs, self.inst, {}) @mock.patch('nova_powervm.virt.powervm.vif.unplug', autospec=True) @mock.patch('nova_powervm.virt.powervm.vm.get_cnas', autospec=True) @mock.patch('nova_powervm.virt.powervm.vm.get_instance_wrapper', autospec=True) @mock.patch('nova_powervm.virt.powervm.slot.build_slot_mgr', autospec=True) def test_unplug_vifs(self, mock_bld_slot_mgr, mock_wrap, mock_vm_get, mock_unplug_vif): # Mock up the CNA response cnas = [mock.MagicMock(), mock.MagicMock()] cnas[0].mac = 'AABBCCDDEEFF' cnas[0].vswitch_uri = 'fake_uri' cnas[1].mac = 'AABBCCDDEE11' cnas[1].vswitch_uri = 'fake_mgmt_uri' mock_vm_get.return_value = cnas mock_lpar_wrapper = mock.MagicMock() mock_lpar_wrapper.can_modify_io = mock.MagicMock( return_value=(True, None)) mock_wrap.return_value = mock_lpar_wrapper # Mock up the network info. They get sanitized to upper case. net_info = [ {'address': 'aa:bb:cc:dd:ee:ff'}, {'address': 'aa:bb:cc:dd:ee:22'} ] # Run method self.drv.unplug_vifs(self.inst, net_info) mock_bld_slot_mgr.assert_called_once_with(self.inst, self.drv.store_api) # The create should have only been called once. The other was already # existing. mock_unplug_vif.assert_has_calls( [mock.call(self.drv.adapter, self.drv.host_uuid, self.inst, net_inf, mock_bld_slot_mgr.return_value, cna_w_list=cnas) for net_inf in net_info]) mock_bld_slot_mgr.return_value.save.assert_called_once_with() @mock.patch('nova_powervm.virt.powervm.tasks.vm.Get.execute', autospec=True) def test_unplug_vif_failures(self, mock_vm): # Test instance not found handling mock_vm.side_effect = exc.InstanceNotFound( instance_id=self.inst) # Run method self.drv.unplug_vifs(self.inst, {}) self.assertEqual(1, mock_vm.call_count) @mock.patch('nova_powervm.virt.powervm.vm.get_instance_wrapper', autospec=True) def test_unplug_vif_failures_httperror(self, mock_wrap): # Test instance not found handling mock_wrap.side_effect = exc.InstanceNotFound( instance_id=self.inst.name) # Backing API: Instance does not exist # Nova Response: No exceptions should be raised. self.drv.unplug_vifs(self.inst, {}) self.assertEqual(1, mock_wrap.call_count) def test_extract_bdm(self): """Tests the _extract_bdm method.""" self.assertEqual([], self.drv._extract_bdm(None)) self.assertEqual([], self.drv._extract_bdm({'fake': 'val'})) fake_bdi = {'block_device_mapping': ['content']} self.assertListEqual(['content'], self.drv._extract_bdm(fake_bdi)) def test_get_host_ip_addr(self): self.assertEqual(self.drv.get_host_ip_addr(), '127.0.0.1') @mock.patch('nova.virt.powervm_ext.driver.LOG.warning', autospec=True) @mock.patch('nova.compute.utils.get_machine_ips', autospec=True) def test_get_host_ip_addr_failure(self, mock_ips, mock_log): mock_ips.return_value = ['1.1.1.1'] self.drv.get_host_ip_addr() mock_log.assert_called_once_with(u'my_ip address (%(my_ip)s) was ' u'not found on any of the ' u'interfaces: %(ifaces)s', {'ifaces': '1.1.1.1', 'my_ip': mock.ANY}) def test_shared_stg_calls(self): data = self.drv.check_instance_shared_storage_local('context', 'inst') self.assertTrue( self.drv.disk_dvr.check_instance_shared_storage_local.called) self.drv.check_instance_shared_storage_remote('context', data) self.assertTrue( self.drv.disk_dvr.check_instance_shared_storage_remote.called) self.drv.check_instance_shared_storage_cleanup('context', data) self.assertTrue( self.drv.disk_dvr.check_instance_shared_storage_cleanup.called) @mock.patch('nova_powervm.virt.powervm.vm.reboot', autospec=True) def test_reboot(self, mock_reboot): inst = mock.Mock() self.drv.reboot('context', inst, 'network_info', 'SOFT') mock_reboot.assert_called_once_with(self.apt, inst, False) mock_reboot.reset_mock() self.drv.reboot('context', inst, 'network_info', 'HARD') mock_reboot.assert_called_once_with(self.apt, inst, True) @mock.patch('pypowervm.tasks.vterm.open_remotable_vnc_vterm') @mock.patch('nova_powervm.virt.powervm.vm.get_pvm_uuid', new=mock.Mock(return_value='uuid')) def test_get_vnc_console(self, mock_vterm): # Success mock_vterm.return_value = '10' resp = self.drv.get_vnc_console(mock.ANY, self.inst) self.assertEqual('127.0.0.1', resp.host) self.assertEqual('10', resp.port) self.assertEqual('uuid', resp.internal_access_path) mock_vterm.assert_called_once_with( mock.ANY, 'uuid', mock.ANY, vnc_path='uuid', use_x509_auth=False, ca_certs=None, server_cert=None, server_key=None) # Failure mock_vterm.side_effect = pvm_exc.VNCBasedTerminalFailedToOpen(err='xx') self.assertRaises(exc.ConsoleTypeUnavailable, self.drv.get_vnc_console, mock.ANY, self.inst) # 404 mock_vterm.side_effect = pvm_exc.HttpNotFound(mock.Mock(status=404)) self.assertRaises(exc.InstanceNotFound, self.drv.get_vnc_console, mock.ANY, self.inst) @staticmethod def _fake_bdms(set_boot_index=False, connection_type=None, driver_volume_type='fibre_channel', driver_volume_type_in_data=False): def _fake_bdm(volume_id, target_lun): conninfo = {'data': {'volume_id': volume_id, 'target_lun': target_lun, 'initiator_target_map': {'21000024F5': ['50050768']}}} if connection_type is not None: conninfo['data']['connection-type'] = connection_type if driver_volume_type is not None: if driver_volume_type_in_data: conninfo['data']['driver_volume_type'] = driver_volume_type else: conninfo['driver_volume_type'] = driver_volume_type mapping_dict = {'source_type': 'volume', 'volume_id': volume_id, 'destination_type': 'volume', 'connection_info': jsonutils.dumps(conninfo)} if set_boot_index: mapping_dict['boot_index'] = target_lun bdm_dict = nova_block_device.BlockDeviceDict(mapping_dict) bdm_obj = bdmobj.BlockDeviceMapping(**bdm_dict) return nova_virt_bdm.DriverVolumeBlockDevice(bdm_obj) bdm_list = [_fake_bdm('fake_vol1', 0), _fake_bdm('fake_vol2', 1)] block_device_info = {'block_device_mapping': bdm_list} return block_device_info @mock.patch('nova_powervm.virt.powervm.tasks.image.UpdateTaskState.' 'execute') @mock.patch('nova_powervm.virt.powervm.tasks.storage.InstanceDiskToMgmt.' 'execute') @mock.patch('nova_powervm.virt.powervm.tasks.image.StreamToGlance.execute') @mock.patch('nova_powervm.virt.powervm.tasks.storage.' 'RemoveInstanceDiskFromMgmt.execute') def test_snapshot(self, mock_rm, mock_stream, mock_conn, mock_update): mock_conn.return_value = 'stg_elem', 'vios_wrap', 'disk_path' self.drv.snapshot('context', self.inst, 'image_id', 'update_task_state') self.assertEqual(2, mock_update.call_count) self.assertEqual(1, mock_conn.call_count) mock_stream.assert_called_with(disk_path='disk_path') mock_rm.assert_called_with(stg_elem='stg_elem', vios_wrap='vios_wrap', disk_path='disk_path') # snapshot operation not supported self.drv.disk_dvr.capabilities = {'snapshot': False} self.assertRaises(exc.NotSupportedWithOption, self.drv.snapshot, 'context', self.inst, 'image_id', 'update_task_state') @mock.patch('nova_powervm.virt.powervm.live_migration.LiveMigrationDest', autospec=True) def test_can_migrate_dest(self, mock_lpm): mock_lpm.return_value.check_destination.return_value = 'dest_data' dest_data = self.drv.check_can_live_migrate_destination( 'context', mock.Mock(), 'src_compute_info', 'dst_compute_info') self.assertEqual('dest_data', dest_data) def test_can_live_mig_dest_clnup(self): self.drv.cleanup_live_migration_destination_check( 'context', 'dest_data') @mock.patch('nova_powervm.virt.powervm.live_migration.LiveMigrationSrc', autospec=True) def test_can_live_mig_src(self, mock_lpm): mock_lpm.return_value.check_source.return_value = ( 'src_data') src_data = self.drv.check_can_live_migrate_source( 'context', mock.Mock(), 'dest_check_data') self.assertEqual('src_data', src_data) def test_pre_live_migr(self): block_device_info = self._fake_bdms() resp = self.drv.pre_live_migration( 'context', self.lpm_inst, block_device_info, 'network_info', 'disk_info', migrate_data='migrate_data') self.assertIsNotNone(resp) def test_live_migration(self): mock_post_meth = mock.Mock() mock_rec_meth = mock.Mock() # Good path self.drv.live_migration( 'context', self.lpm_inst, 'dest', mock_post_meth, mock_rec_meth, 'block_mig', 'migrate_data') mock_post_meth.assert_called_once_with( 'context', self.lpm_inst, 'dest', mock.ANY, mock.ANY) self.assertEqual(0, mock_rec_meth.call_count) # Abort invocation path self._setup_lpm() mock_post_meth.reset_mock() mock_kwargs = {'operation_name': 'op', 'seconds': 10} self.lpm.live_migration.side_effect = ( pvm_exc.JobRequestTimedOut(**mock_kwargs)) self.assertRaises( lpm.LiveMigrationFailed, self.drv.live_migration, 'context', self.lpm_inst, 'dest', mock_post_meth, mock_rec_meth, 'block_mig', 'migrate_data') self.lpm.migration_abort.assert_called_once_with() mock_rec_meth.assert_called_once_with( 'context', self.lpm_inst, 'dest', migrate_data=mock.ANY) self.lpm.rollback_live_migration.assert_called_once_with('context') self.assertEqual(0, mock_post_meth.call_count) # Exception path self._setup_lpm() mock_post_meth.reset_mock() mock_rec_meth.reset_mock() self.lpm.live_migration.side_effect = ValueError() self.assertRaises( lpm.LiveMigrationFailed, self.drv.live_migration, 'context', self.lpm_inst, 'dest', mock_post_meth, mock_rec_meth, 'block_mig', 'migrate_data') mock_rec_meth.assert_called_once_with( 'context', self.lpm_inst, 'dest', migrate_data=mock.ANY) self.lpm.rollback_live_migration.assert_called_once_with('context') self.assertEqual(0, mock_post_meth.call_count) # Ensure we get LiveMigrationFailed even if recovery fails. self._setup_lpm() mock_post_meth.reset_mock() mock_rec_meth.reset_mock() self.lpm.live_migration.side_effect = ValueError() # Cause the recovery method to fail with an exception. mock_rec_meth.side_effect = ValueError() self.assertRaises( lpm.LiveMigrationFailed, self.drv.live_migration, 'context', self.lpm_inst, 'dest', mock_post_meth, mock_rec_meth, 'block_mig', 'migrate_data') mock_rec_meth.assert_called_once_with( 'context', self.lpm_inst, 'dest', migrate_data=mock.ANY) self.lpm.rollback_live_migration.assert_called_once_with('context') self.assertEqual(0, mock_post_meth.call_count) def test_rollbk_lpm_dest(self): self.drv.rollback_live_migration_at_destination( 'context', self.lpm_inst, 'network_info', 'block_device_info') mock_rollback = self.lpm.rollback_live_migration_at_destination mock_rollback.assert_called_once_with( 'context', self.lpm_inst, 'network_info', 'block_device_info', destroy_disks=True, migrate_data=None) self.assertRaises( KeyError, lambda: self.drv.live_migrations[self.lpm_inst.uuid]) def test_post_live_mig(self): self.drv.post_live_migration('context', self.lpm_inst, None) self.lpm.post_live_migration.assert_called_once_with([], None) def test_post_live_mig_src(self): self.drv.post_live_migration_at_source('context', self.lpm_inst, 'network_info') self.lpm.post_live_migration_at_source.assert_called_once_with( 'network_info') @mock.patch('nova_powervm.virt.powervm.vm.power_off', autospec=True) def test_power_off(self, mock_power_off): self.drv.power_off(self.inst) mock_power_off.assert_called_once_with( self.drv.adapter, self.inst, force_immediate=True, timeout=None) # Long timeout (retry interval means nothing on powervm) mock_power_off.reset_mock() self.drv.power_off(self.inst, timeout=500, retry_interval=10) mock_power_off.assert_called_once_with( self.drv.adapter, self.inst, force_immediate=False, timeout=500) @mock.patch('nova_powervm.virt.powervm.driver.PowerVMDriver._destroy') def test_confirm_migration_diff_host(self, mock_destroy): mock_mig = mock.Mock(source_compute='host1', dest_compute='host2') self.drv.confirm_migration('context', mock_mig, self.lpm_inst, 'network_info') mock_destroy.assert_called_once_with( 'context', self.lpm_inst, block_device_info=None, destroy_disks=False, shutdown=False) @mock.patch('nova_powervm.virt.powervm.vm.rename', autospec=True) def test_confirm_migration_same_host(self, mock_rename): mock_mig = mock.Mock(source_compute='host1', dest_compute='host1') self.drv.confirm_migration('context', mock_mig, self.lpm_inst, 'network_info') mock_rename.assert_called_once_with( self.drv.adapter, self.lpm_inst, self.lpm_inst.name) @mock.patch('nova_powervm.virt.powervm.driver.PowerVMDriver._vol_drv_iter', autospec=True) def test_post_live_mig_dest(self, mock_vdi): vals = [(None, None)] mock_vdi.return_value = vals self.drv.post_live_migration_at_destination( 'context', self.lpm_inst, 'network_info') self.lpm.post_live_migration_at_destination.assert_called_once_with( 'network_info', vals) @mock.patch('nova_powervm.virt.powervm.driver.PowerVMDriver._vol_drv_iter', autospec=True) def test_post_live_mig_dest_vol_drv(self, mock_vdi): bdm1 = mock.Mock() fake_bdi = {'block_device_mapping': [bdm1]} vals = [(bdm1, self.iscsi_vol_drv)] mock_vdi.return_value = vals self.drv.post_live_migration_at_destination( 'context', self.lpm_inst, 'network_info', fake_bdi) self.lpm.post_live_migration_at_destination.assert_called_once_with( 'network_info', vals) @mock.patch('pypowervm.tasks.memory.calculate_memory_overhead_on_host', autospec=True) def test_estimate_instance_overhead(self, mock_calc_over): mock_calc_over.return_value = ('2048', '96') inst_info = self.inst.get_flavor() inst_info.extra_specs = {} overhead = self.drv.estimate_instance_overhead(inst_info) self.assertEqual({'memory_mb': '2048'}, overhead) # Make sure the cache works mock_calc_over.reset_mock() overhead = self.drv.estimate_instance_overhead(inst_info) self.assertEqual({'memory_mb': '2048'}, overhead) self.assertEqual(0, mock_calc_over.call_count) # Reset the cache every time from now on self.drv._inst_overhead_cache = {} # Flavor having extra_specs inst_info.extra_specs = {'powervm:max_mem': 4096} overhead = self.drv.estimate_instance_overhead(inst_info) mock_calc_over.assert_called_with(self.apt, self.drv.host_uuid, {'max_mem': 4096}) self.assertEqual({'memory_mb': '2048'}, overhead) self.drv._inst_overhead_cache = {} # Test when instance passed is dict inst_info = obj_base.obj_to_primitive(inst_info) overhead = self.drv.estimate_instance_overhead(inst_info) self.assertEqual({'memory_mb': '2048'}, overhead) self.drv._inst_overhead_cache = {} # When instance_info is None overhead = self.drv.estimate_instance_overhead(None) self.assertEqual({'memory_mb': 0}, overhead) self.drv._inst_overhead_cache = {} # Test when instance Object is passed overhead = self.drv.estimate_instance_overhead(self.inst) self.assertEqual({'memory_mb': '2048'}, overhead) def test_vol_drv_iter(self): block_device_info = self._fake_bdms() bdms = self.drv._extract_bdm(block_device_info) vol_adpt = mock.Mock() def _get_results(bdms): # Patch so we get the same mock back each time. with mock.patch('nova_powervm.virt.powervm.volume.' 'build_volume_driver', return_value=vol_adpt): return [(bdm, vol_drv) for bdm, vol_drv in self.drv._vol_drv_iter(self.inst, bdms)] results = _get_results(bdms) self.assertEqual( 'fake_vol1', results[0][0]['connection_info']['data']['volume_id']) self.assertEqual(vol_adpt, results[0][1]) self.assertEqual( 'fake_vol2', results[1][0]['connection_info']['data']['volume_id']) self.assertEqual(vol_adpt, results[1][1]) # Test with empty bdms self.assertEqual([], _get_results([])) def test_build_vol_drivers(self): # This utility just returns a list of drivers from the _vol_drv_iter() # iterator so mock it and ensure the drivers are returned. vals = [('bdm0', 'drv0'), ('bdm1', 'drv1')] with mock.patch.object(self.drv, '_vol_drv_iter', return_value=vals): drivers = self.drv._build_vol_drivers('context', 'instance', None) self.assertEqual(['drv0', 'drv1'], drivers) @mock.patch.object(objects.BlockDeviceMappingList, 'get_by_instance_uuid') @mock.patch.object(virt_driver, 'get_block_device_info') def test_get_block_device_info(self, mock_bk_dev, mock_bdml): mock_bk_dev.return_value = 'info' self.assertEqual('info', self.drv._get_block_device_info('ctx', self.inst)) def test_deallocate_networks_on_reschedule(self): candeallocate = self.drv.deallocate_networks_on_reschedule(mock.Mock()) self.assertTrue(candeallocate) @mock.patch('pypowervm.tasks.cna.find_orphaned_trunks', autospec=True) def test_cleanup_orphan_adapters(self, mock_find_orphans): mock_orphan = mock.MagicMock() mock_find_orphans.return_value = [mock_orphan] self.drv._cleanup_orphan_adapters('my_vswitch') mock_orphan.delete.assert_called_once_with() def test_get_host_cpu_stats(self): hcpu_stats = self.drv.get_host_cpu_stats() expected_stats = { 'kernel': self.drv.host_cpu_cache.total_fw_cycles, 'user': self.drv.host_cpu_cache.total_user_cycles, 'idle': (self.drv.host_cpu_cache.total_cycles - self.drv.host_cpu_cache.total_user_cycles - self.drv.host_cpu_cache.total_fw_cycles), 'iowait': 0, 'frequency': self.drv.host_cpu_cache.cpu_freq} self.assertEqual(expected_stats, hcpu_stats) self.drv.host_cpu_cache.refresh.assert_called_once()