46 lines
1.3 KiB
Python
46 lines
1.3 KiB
Python
# Copyright 2016 IBM Corp.
|
|
#
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from nova.hacking import checks
|
|
|
|
|
|
def no_log_warn(logical_line, filename):
|
|
"""Disallow 'LOG.warn('
|
|
|
|
"""
|
|
if logical_line.startswith('LOG.warn('):
|
|
yield(0, 'P301 Use LOG.warning() rather than LOG.warn()')
|
|
|
|
|
|
def no_os_popen(logical_line):
|
|
"""Disallow 'os.popen('
|
|
|
|
Deprecated library function os.popen() Replace it using subprocess
|
|
https://bugs.launchpad.net/tempest/+bug/1529836
|
|
|
|
P302
|
|
"""
|
|
|
|
if 'os.popen(' in logical_line:
|
|
yield(0, 'P302 Deprecated library function os.popen(). '
|
|
'Replace it using subprocess module. ')
|
|
|
|
|
|
def factory(register):
|
|
register(no_log_warn)
|
|
register(no_os_popen)
|
|
checks.factory(register)
|