openstack
/
nova-specs
Code Issues Proposed changes

Update patch set 11 

Patch Set 11: Code-Review-1

(5 comments)

Patch-set: 11
Reviewer: Gerrit User 16688 <16688@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 1d80c4ca8b891232324812e19e0838032b3cd396
Attention: {"person_ident":"Gerrit User 16688 \u003c16688@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_16688\u003e replied on the change"}
This commit is contained in:
Gerrit User 16688 2023-05-18 13:37:50 +00:00 committed by Gerrit Code Review
parent a8d35205e6
commit 1c3850ff2d
1 changed files with 103 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

103
5760ff2b9537f7d39e703cd612ce2d0b0844aa9a
View File

@ -16,6 +16,109 @@
"message": "Thank you to have applied suggested changes",
"revId": "5760ff2b9537f7d39e703cd612ce2d0b0844aa9a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7b798fab_87c0367d",
"filename": "specs/2023.2/approved/support-napatech-linkvirtualization-smartnic.rst",
"patchSetId": 11
},
"lineNbr": 53,
"author": {
"id": 16688
},
"writtenOn": "2023-05-18T13:37:50Z",
"side": 1,
"message": "nit: be more explicit saying that this is the new VIF type you are proposing",
"range": {
"startLine": 53,
"startChar": 2,
"endLine": 53,
"endChar": 73
},
"revId": "5760ff2b9537f7d39e703cd612ce2d0b0844aa9a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "91d82d79_e1b89679",
"filename": "specs/2023.2/approved/support-napatech-linkvirtualization-smartnic.rst",
"patchSetId": 11
},
"lineNbr": 55,
"author": {
"id": 16688
},
"writtenOn": "2023-05-18T13:37:50Z",
"side": 1,
"message": "nit: what/where is this class? If you are referring to a library project (os-vif), please mention it\n\nnit2: ``OvsPlugin``\n\nnet3: please explain how a DPDK port representor is plugged and unplugged from OVS",
"range": {
"startLine": 55,
"startChar": 27,
"endLine": 55,
"endChar": 38
},
"revId": "5760ff2b9537f7d39e703cd612ce2d0b0844aa9a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c4666423_80444dbc",
"filename": "specs/2023.2/approved/support-napatech-linkvirtualization-smartnic.rst",
"patchSetId": 11
},
"lineNbr": 60,
"author": {
"id": 16688
},
"writtenOn": "2023-05-18T13:37:50Z",
"side": 1,
"message": "Just some questions:\n1) it seems to be a very short spec definition for such an important RFE. Would it be so transparent for OpenStack Nova/Neutron?\n\n2) What hardware does support this feature?",
"revId": "5760ff2b9537f7d39e703cd612ce2d0b0844aa9a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "8f980962_9965b7e1",
"filename": "specs/2023.2/approved/support-napatech-linkvirtualization-smartnic.rst",
"patchSetId": 11
},
"lineNbr": 156,
"author": {
"id": 16688
},
"writtenOn": "2023-05-18T13:37:50Z",
"side": 1,
"message": "nit: each line should be a new bullet point",
"range": {
"startLine": 156,
"startChar": 0,
"endLine": 156,
"endChar": 2
},
"revId": "5760ff2b9537f7d39e703cd612ce2d0b0844aa9a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5f2f0750_bb9f28bd",
"filename": "specs/2023.2/approved/support-napatech-linkvirtualization-smartnic.rst",
"patchSetId": 11
},
"lineNbr": 158,
"author": {
"id": 16688
},
"writtenOn": "2023-05-18T13:37:50Z",
"side": 1,
"message": "do you know beforehand what are the tests that will be executed in this CI? Just a question, not a requirement for the spec",
"revId": "5760ff2b9537f7d39e703cd612ce2d0b0844aa9a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}