openstack
/
nova-specs
Code Issues Proposed changes

Update patch set 12 

Patch Set 12:

(1 comment)

Patch-set: 12
This commit is contained in:
Gerrit User 4393 2023-05-24 18:25:17 +00:00 committed by Gerrit Code Review
parent ebd084304d
commit 2ba7922a48
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
befeb2b945cd58663433afb9b0cf50ba54c64c30
View File

@ -68,6 +68,24 @@
"revId": "befeb2b945cd58663433afb9b0cf50ba54c64c30",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "8e29b51b_ead2aa2f",
"filename": "specs/2023.2/approved/cleanup-dangling-volume-attachments.rst",
"patchSetId": 12
},
"lineNbr": 54,
"author": {
"id": 4393
},
"writtenOn": "2023-05-24T18:25:17Z",
"side": 1,
"message": "Let\u0027s also add that we should delete cinder attachments that we don\u0027t know anything about that are claiming to be for this instance. Meaning, we should list attachments for the volume and then (in pseudocode):\n```\nfor attachment in volume[\u0027attachments\u0027]:\n if attachment.instance_uuid \u003d\u003d instance.uuid and\n attachment.id not in bdms:\n delete_attachment(attachment)\nfor bdm in bdms:\n if bdm.attachment_id not in volume[\u0027attachments\u0027]:\n delete_bdm(bdm)\n```\n\nWe very specifically need to be clear that you can\u0027t attach or detach volumes directly with cinder without going through nova\u0027s API.",
"parentUuid": "495f4f21_7484c1fd",
"revId": "befeb2b945cd58663433afb9b0cf50ba54c64c30",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {