openstack
/
nova-specs
Code Issues Proposed changes

Update patch set 12 

Patch Set 12: Code-Review-1

(2 comments)

Patch-set: 12
Reviewer: Gerrit User 11604 <11604@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, e1e478810604bd86503cb926cb0957878eb97cf6
Attention: {"person_ident":"Gerrit User 7166 \u003c7166@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_11604\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 11604 \u003c11604@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_11604\u003e replied on the change"}
This commit is contained in:
Gerrit User 11604 2023-05-24 17:02:30 +00:00 committed by Gerrit Code Review
parent cc78a0a684
commit 60fe6eb289
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
befeb2b945cd58663433afb9b0cf50ba54c64c30
View File

@ -159,6 +159,24 @@
"revId": "befeb2b945cd58663433afb9b0cf50ba54c64c30",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7e73f4d5_21cd88cc",
"filename": "specs/2023.2/approved/cleanup-dangling-volume-attachments.rst",
"patchSetId": 12
},
"lineNbr": 174,
"author": {
"id": 11604
},
"writtenOn": "2023-05-24T17:02:30Z",
"side": 1,
"message": "it would have a perfroamce impact yes which is why it was orgianlly an oflien oepration done by the admin vai nova-manage.",
"parentUuid": "ff344a9d_7560317c",
"revId": "befeb2b945cd58663433afb9b0cf50ba54c64c30",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -176,6 +194,24 @@
"revId": "befeb2b945cd58663433afb9b0cf50ba54c64c30",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "6cff9dd0_fc8e3234",
"filename": "specs/2023.2/approved/cleanup-dangling-volume-attachments.rst",
"patchSetId": 12
},
"lineNbr": 179,
"author": {
"id": 11604
},
"writtenOn": "2023-05-24T17:02:30Z",
"side": 1,
"message": "not nessisarly\nthe expectaation here is that if the cinder api is down we will still be able to boot vms using our exisitng bdms form the db\nwe jsut cant heal any deviation",
"parentUuid": "27f2f2be_7b13e69f",
"revId": "befeb2b945cd58663433afb9b0cf50ba54c64c30",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {