openstack
/
nova-specs
Code Issues Proposed changes

Update patch set 10 

Patch Set 10: Code-Review+1

(2 comments)

Patch-set: 10
Reviewer: Gerrit User 7730 <7730@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, 49e23935337fb7383bb8bfed33b63e465c2323db
Attention: {"person_ident":"Gerrit User 35489 \u003c35489@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_7730\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 7730 \u003c7730@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_7730\u003e replied on the change"}
This commit is contained in:
Gerrit User 7730 2023-05-05 14:31:04 +00:00 committed by Gerrit Code Review
parent cbb93d3d01
commit 6d3fb9bd46
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
a95069d093d29e12379368120c1037d484d3eb63 Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "c4347099_1236878c",
"filename": "specs/2023.2/approved/support-napatech-linkvirtualization-smartnic.rst",
"patchSetId": 10
},
"lineNbr": 53,
"author": {
"id": 7730
},
"writtenOn": "2023-05-05T14:31:04Z",
"side": 1,
"message": "Already merged, right?",
"revId": "a95069d093d29e12379368120c1037d484d3eb63",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "6979e435_315177b6",
"filename": "specs/2023.2/approved/support-napatech-linkvirtualization-smartnic.rst",
"patchSetId": 10
},
"lineNbr": 135,
"author": {
"id": 7730
},
"writtenOn": "2023-05-05T14:31:04Z",
"side": 1,
"message": "nit: I think you want to refer the work that will be needed but the not patches or gerrit changes related as you may need some more (this may happen).\n\nYou want for example indicate the kind of changes needed in Nova, Neutron, osvif...",
"revId": "a95069d093d29e12379368120c1037d484d3eb63",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}