openstack
/
nova-specs
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(2 comments)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 27900 \u003c27900@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_15334\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 15334 \u003c15334@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_15334\u003e replied on the change"}
This commit is contained in:
Gerrit User 15334 2024-02-29 14:44:04 +00:00 committed by Gerrit Code Review
parent cdb8738dd4
commit 6ff6c7d7d0
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
506e904394ef20ad7729a38c9366aa5406d68568
View File

@ -17,6 +17,24 @@
"revId": "506e904394ef20ad7729a38c9366aa5406d68568",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e08fc758_3a1ca21b",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 15334
},
"writtenOn": "2024-02-29T14:44:04Z",
"side": 1,
"message": "I agree. We currently have no `title` or `description` fields. We should add those are part of this effort. I would like us to get to the point where there would be zero human input needed to generate a spec.",
"parentUuid": "d5480c77_910c887f",
"revId": "506e904394ef20ad7729a38c9366aa5406d68568",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -33,6 +51,24 @@
"message": "I think more reasonable would be to start with schemas already defined in openstack-codegenerator project since they are already mostly reviewed by human for sanity and address document bugs, microversions and actions. This can save quote lot of time.\n\nImportant: openstack-codegenerator does not currently have schemas for deprecated methods",
"revId": "506e904394ef20ad7729a38c9366aa5406d68568",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "6dea2f3c_9a8a94b2",
"filename": "specs/2024.2/approved/openapi.rst",
"patchSetId": 2
},
"lineNbr": 79,
"author": {
"id": 15334
},
"writtenOn": "2024-02-29T14:44:04Z",
"side": 1,
"message": "\u003e I think more reasonable would be to start with schemas already defined in openstack-codegenerator project since they are already mostly reviewed by human for sanity and address document bugs, microversions and actions. This can save quote lot of time.\n\nNot a bad idea.\n\n\u003e Important: openstack-codegenerator does not currently have schemas for deprecated methods\n\nOkay. We don\u0027t want to add these for removed (`HTTP 410 (Gone)`) APIs. We should have them for deprecated APIs though.",
"parentUuid": "61c12355_2001447c",
"revId": "506e904394ef20ad7729a38c9366aa5406d68568",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}