openstack
/
nova-specs
Code Issues Proposed changes

Update patch set 12 

Patch Set 12: Code-Review-1 Review-Priority+1

(9 comments)

Patch-set: 12
Reviewer: Gerrit User 7166 <7166@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, cad1267e46ccab01017dda68746d4b8a69ee3451
Label: Review-Priority=+1, ff264cb893862ed04b4775afbea5a0a2efa4af99
Attention: {"person_ident":"Gerrit User 34860 \u003c34860@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_7166\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 7166 \u003c7166@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_7166\u003e replied on the change"}
This commit is contained in:
Gerrit User 7166 2023-05-22 15:09:01 +00:00 committed by Gerrit Code Review
parent 79c0cab5ec
commit 8c5cc5f3c9
1 changed files with 163 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

163
befeb2b945cd58663433afb9b0cf50ba54c64c30 Normal file
View File

@ -0,0 +1,163 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "cd40ddfa_bcd22ec9",
"filename": "specs/2023.2/approved/cleanup-dangling-volume-attachments.rst",
"patchSetId": 12
},
"lineNbr": 11,
"author": {
"id": 7166
},
"writtenOn": "2023-05-22T15:09:01Z",
"side": 1,
"message": "nit: change the link please",
"revId": "befeb2b945cd58663433afb9b0cf50ba54c64c30",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "503cf8b0_553d04ec",
"filename": "specs/2023.2/approved/cleanup-dangling-volume-attachments.rst",
"patchSetId": 12
},
"lineNbr": 27,
"author": {
"id": 7166
},
"writtenOn": "2023-05-22T15:09:01Z",
"side": 1,
"message": "in general, you don\u0027t need to provide the reproduction steps but here I\u0027m OK",
"revId": "befeb2b945cd58663433afb9b0cf50ba54c64c30",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "bf03f91b_ccbd2272",
"filename": "specs/2023.2/approved/cleanup-dangling-volume-attachments.rst",
"patchSetId": 12
},
"lineNbr": 83,
"author": {
"id": 7166
},
"writtenOn": "2023-05-22T15:09:01Z",
"side": 1,
"message": "the two above paragraphs are not the proposed change, just explaining why it won\u0027t work.",
"revId": "befeb2b945cd58663433afb9b0cf50ba54c64c30",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "64fdb0a2_77fb418d",
"filename": "specs/2023.2/approved/cleanup-dangling-volume-attachments.rst",
"patchSetId": 12
},
"lineNbr": 85,
"author": {
"id": 7166
},
"writtenOn": "2023-05-22T15:09:01Z",
"side": 1,
"message": "only when restarting the instances, or should we also verify that when restarting the nova-compute ?",
"range": {
"startLine": 85,
"startChar": 0,
"endLine": 85,
"endChar": 30
},
"revId": "befeb2b945cd58663433afb9b0cf50ba54c64c30",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "31a0cfef_02182f76",
"filename": "specs/2023.2/approved/cleanup-dangling-volume-attachments.rst",
"patchSetId": 12
},
"lineNbr": 92,
"author": {
"id": 7166
},
"writtenOn": "2023-05-22T15:09:01Z",
"side": 1,
"message": "what if the Cinder API isn\u0027t running? Could you explain that then we would continue to support the BDM but providing a log.",
"revId": "befeb2b945cd58663433afb9b0cf50ba54c64c30",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3f4e20d7_8be5fafe",
"filename": "specs/2023.2/approved/cleanup-dangling-volume-attachments.rst",
"patchSetId": 12
},
"lineNbr": 131,
"author": {
"id": 7166
},
"writtenOn": "2023-05-22T15:09:01Z",
"side": 1,
"message": "not sure you really need to explain your code changes, but OK.",
"revId": "befeb2b945cd58663433afb9b0cf50ba54c64c30",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ff344a9d_7560317c",
"filename": "specs/2023.2/approved/cleanup-dangling-volume-attachments.rst",
"patchSetId": 12
},
"lineNbr": 174,
"author": {
"id": 7166
},
"writtenOn": "2023-05-22T15:09:01Z",
"side": 1,
"message": "really ? \n\nI think that we would have some impact given we need to call Cinder everytime we restart an instance, even when restarting nova-compute if by default we restart the instances.\n\nThat\u0027s why I\u0027m a bit afraid. Should we like have an opt-in for that then ?",
"revId": "befeb2b945cd58663433afb9b0cf50ba54c64c30",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "27f2f2be_7b13e69f",
"filename": "specs/2023.2/approved/cleanup-dangling-volume-attachments.rst",
"patchSetId": 12
},
"lineNbr": 179,
"author": {
"id": 7166
},
"writtenOn": "2023-05-22T15:09:01Z",
"side": 1,
"message": "here, we need to make sure that Cinder-API service runs before, right?",
"revId": "befeb2b945cd58663433afb9b0cf50ba54c64c30",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "02331c06_a9d3beb7",
"filename": "specs/2023.2/approved/cleanup-dangling-volume-attachments.rst",
"patchSetId": 12
},
"lineNbr": 229,
"author": {
"id": 7166
},
"writtenOn": "2023-05-22T15:09:01Z",
"side": 1,
"message": "which ones specifically ?",
"revId": "befeb2b945cd58663433afb9b0cf50ba54c64c30",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}