Check length of the lines to be less than 80 chars

This commit adds a test to be sure the lines of specs
are less than 80 characters.
Also updates specs that needs to pass this test.

Change-Id: Ie4c523f249d90bc2783534bf30a9f25cd3625303

specs/juno/backportable-db-migrations-juno.rst

@@ -27,9 +27,9 @@ as placeholders to allow for migration backports if needed.
 Proposed change
 ===============
 
-The proposed change is to reserve 10 migrations for Icehouse backports.  These
+The proposed change is to reserve 10 migrations for Icehouse backports. These
-migrations would be no-ops and would simply result in an increment of the schema
+migrations would be no-ops and would simply result in an increment of the
-version.
+schema version.
 
 Alternatives
 ------------

specs/juno/cross-service-request-id.rst

@@ -24,8 +24,9 @@ glance, neutron) send x-openstack-request-id.
 Proposed change
 ===============
 
-Use x-openstack-request-id when handling v3 requests for nova. There is existing
+Use x-openstack-request-id when handling v3 requests for nova. There is
-middleware in oslo to generate the ID and attach the header to the response.
+existing middleware in oslo to generate the ID and attach the header to
+the response.
 
 Alternatives
 ------------
@@ -34,8 +35,8 @@ The current approach -- keeping the existing header name -- is the alternative.
 This will perpetuate header name discontinuity among OpenStack services.
 
 Another alternative is to include the new header name for both v2 and v3. But
-the benefits of doing so is not great enough to justify altering the behavior of
+the benefits of doing so is not great enough to justify altering the behavior
-the existing API.
+of the existing API.
 
 Data model impact
 -----------------
@@ -64,10 +65,10 @@ Other end user impact
 ---------------------
 
 Users making requests using the v3 API will only receive the new header,
-x-openstack-request-id. python-novaclient uses x-compute-request-id (if present)
+x-openstack-request-id. python-novaclient uses x-compute-request-id (if
-when reporting an HTTPError; this will need to be updated to use the new header
+present) when reporting an HTTPError; this will need to be updated to use the
-name when novaclient is using v3. Other clients moving from v2 to v3 will need
+new header name when novaclient is using v3. Other clients moving from v2 to v3
-to consider the header name change.
+will need to consider the header name change.
 
 Performance Impact
 ------------------

specs/juno/support-console-log-migration.rst

@@ -33,8 +33,8 @@ There are two issues which play a role in this.
 Proposed change
 ===============
 
-We propose the following in this blueprint to solve this issue without depending
+We propose the following in this blueprint to solve this issue without
-on kvm.
+depending on kvm.
 
 * Require that VIR_MIGRATE_UNDEFINE_SOURCE is not set. Instead wait for the
   condition that the instance is shutoff at the source.
@@ -44,9 +44,9 @@ on kvm.
   all the rotated files need to be rotated once.
 
 * Change get-console-log function such that console.log and console.log.1 are
-  merged in the response (within the MAX_CONSOLE_BYTES limit). It log rotation is
+  merged in the response (within the MAX_CONSOLE_BYTES limit). It log rotation
-  implemented then the function needs to read as many files as it takes to fill up
+  is implemented then the function needs to read as many files as it takes to
-  the MAX_CONSOLE_BYTES limit.
+  fill up the MAX_CONSOLE_BYTES limit.
 
 * The source VM would get undefined by the periodic task once the database is
   updated with the new hostname.
@@ -83,16 +83,16 @@ None
 Performance Impact
 ------------------
 
-* There's a brief window between the time the VM is activated in the destination
+* There's a brief window between the time the VM is activated in the
-  and before post-live-migration is completed. Any nova console-log requests will
+  destination and before post-live-migration is completed. Any nova
-  return almost empty content during this window.
+  console-log requests will return almost empty content during this window.
 
 Other deployer impact
 ---------------------
 
 * If people are using VIR_MIGRATE_UNDEFINE_SOURCE then they need to remove this
-  option to get this feature. If this flag exists we will fallback to not having
+  option to get this feature. If this flag exists we will fallback to not
-  the console log migrated.
+  having the console log migrated.
 
 Developer impact
 ----------------
@@ -131,8 +131,8 @@ Documentation Impact
 We expect to have the following documentation changes:
 
 * The migration flag changes to get console logs migrated
-* Expected empty console log during the VM offline period in the final stages of
+* Expected empty console log during the VM offline period in the final stages
-  the migration
+  of the migration
 
 References
 ==========

specs/template.rst

@@ -37,8 +37,8 @@ Some notes about using this template:
   required.  http://asciiflow.com/ is a very nice tool to assist with making
   ascii diagrams.  The reason for this is that the tool used to review specs is
   based purely on plain text.  Plain text will allow review to proceed without
-  having to look at additional files which can not be viewed in gerrit.  It will
+  having to look at additional files which can not be viewed in gerrit.  It
-  also allow inline feedback on the diagram itself.
+  will also allow inline feedback on the diagram itself.
 
 Problem description
 ===================
@@ -79,7 +79,8 @@ proposed changes to the data model.
 
 Questions which need to be addressed by this section include:
 
-* What new data objects and/or database schema changes is this going to require?
+* What new data objects and/or database schema changes is this going to
+  require?
 
 * What database migrations will accompany this change.
 
@@ -174,7 +175,8 @@ changes to an existing notification, or removing a notification.
 Other end user impact
 ---------------------
 
-Aside from the API, are there other ways a user will interact with this feature?
+Aside from the API, are there other ways a user will interact with this
+feature?
 
 * Does this change have an impact on python-novaclient? What does the user
   interface there look like?
@@ -191,18 +193,18 @@ Examples of things to consider here include:
 * A periodic task might look like a small addition but if it calls conductor or
   another service the load is multiplied by the number of nodes in the system.
 
-* Scheduler filters get called once per host for every instance being created, so
+* Scheduler filters get called once per host for every instance being created,
-  any latency they introduce is linear with the size of the system.
+  so any latency they introduce is linear with the size of the system.
 
 * A small change in a utility function or a commonly used decorator can have a
   large impacts on performance.
 
-* Calls which result in a database queries (whether direct or via conductor) can
+* Calls which result in a database queries (whether direct or via conductor)
-  have a profound impact on performance when called in critical sections of the
+  can have a profound impact on performance when called in critical sections of
-  code.
+  the code.
 
-* Will the change include any locking, and if so what considerations are there on
+* Will the change include any locking, and if so what considerations are there
-  holding the lock?
+  on holding the lock?
 
 Other deployer impact
 ---------------------
@@ -313,6 +315,7 @@ references are unavailable. Examples of what you could include are:
 
 * Links to relevant research, if appropriate
 
-* Related specifications as appropriate (e.g.  if it's an EC2 thing, link the EC2 docs)
+* Related specifications as appropriate (e.g.  if it's an EC2 thing, link the
+  EC2 docs)
 
 * Anything else you feel it is worthwhile to refer to

tests/test_titles.py

@@ -79,6 +79,15 @@ class TestTitles(testtools.TestCase):
         self.assertIn(refs, titles)
         self.assertEqual(0, len(titles[refs]))
 
+    def _check_lines_wrapping(self, tpl, raw):
+        for i, line in enumerate(raw.split("\n")):
+            if "http://" in line or "https://" in line:
+                continue
+            self.assertTrue(
+                len(line) < 80,
+                msg="%s:%d: Line limited to a maximum of 79 characters." %
+                (tpl, i+1))
+
     def test_template(self):
         files = ['specs/template.rst'] + glob.glob('specs/*/*')
         for filename in files:
@@ -86,6 +95,8 @@ class TestTitles(testtools.TestCase):
                             "spec's file must uses 'rst' extension.")
             with open(filename) as f:
                 data = f.read()
+
             spec = docutils.core.publish_doctree(data)
             titles = self._get_titles(spec)
             self._check_titles(titles)
+            self._check_lines_wrapping(filename, data)