Update patch set 12

Patch Set 12: Code-Review-1

(2 comments)

Patch-set: 12
Reviewer: Gerrit User 4393 <4393@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 41f50cabce14a896137341b696da70a1e0738d13
Attention: {"person_ident":"Gerrit User 4393 \u003c4393@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_4393\u003e replied on the change"}

befeb2b945cd58663433afb9b0cf50ba54c64c30

@@ -1,5 +1,22 @@
 {
   "comments": [
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "88a1e2a1_14fc3ff3",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 12
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 4393
+      },
+      "writtenOn": "2023-05-24T16:41:01Z",
+      "side": 1,
+      "message": "I think we need to be pretty specific about ho detailed we\u0027re going to be here, in light of CVE-2023-2088.",
+      "revId": "befeb2b945cd58663433afb9b0cf50ba54c64c30",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
     {
       "unresolved": true,
       "key": {
@@ -34,6 +51,23 @@
       "revId": "befeb2b945cd58663433afb9b0cf50ba54c64c30",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "495f4f21_7484c1fd",
+        "filename": "specs/2023.2/approved/cleanup-dangling-volume-attachments.rst",
+        "patchSetId": 12
+      },
+      "lineNbr": 54,
+      "author": {
+        "id": 4393
+      },
+      "writtenOn": "2023-05-24T16:41:01Z",
+      "side": 1,
+      "message": "I think we might want to be more specific here and say that we need to specifically correlate our attachments (by id) to those in cinder and remove any that are no longer valid. We also want to be specific that creating an attachment in cinder should not be adopted or integrated into nova, effectively allowing someone to bypass nova\u0027s attachment api by jamming the attachment into cinder and then rebooting the instance.\n\nSo this should be based on attachment_id, as stored in our connector, and we should purge any that don\u0027t exist on the cinder side *and* not import any that we find when listing attachments on the volume.",
+      "revId": "befeb2b945cd58663433afb9b0cf50ba54c64c30",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
     {
       "unresolved": true,
       "key": {