openstack
/
nova-specs
Code Issues Proposed changes

Update patch set 12 

Patch Set 12:

(2 comments)

Patch-set: 12
Attention: {"person_ident":"Gerrit User 11604 \u003c11604@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_4393\u003e replied on the change"}
This commit is contained in:
Gerrit User 4393 2023-05-24 17:10:45 +00:00 committed by Gerrit Code Review
parent 60fe6eb289
commit ebd084304d
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
befeb2b945cd58663433afb9b0cf50ba54c64c30
View File

@ -177,6 +177,24 @@
"revId": "befeb2b945cd58663433afb9b0cf50ba54c64c30",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a1844e47_60fd4422",
"filename": "specs/2023.2/approved/cleanup-dangling-volume-attachments.rst",
"patchSetId": 12
},
"lineNbr": 174,
"author": {
"id": 4393
},
"writtenOn": "2023-05-24T17:10:45Z",
"side": 1,
"message": "It\u0027s an extremely tiny impact.. A GET of an attachment by ID. In the scheme of a hard reboot, it\u0027s extremely minor. Considering the fallout from the recent CVE, it\u0027s also very easy to justify such things for safety :)",
"parentUuid": "7e73f4d5_21cd88cc",
"revId": "befeb2b945cd58663433afb9b0cf50ba54c64c30",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -212,6 +230,24 @@
"revId": "befeb2b945cd58663433afb9b0cf50ba54c64c30",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f0aa66fb_02add270",
"filename": "specs/2023.2/approved/cleanup-dangling-volume-attachments.rst",
"patchSetId": 12
},
"lineNbr": 179,
"author": {
"id": 4393
},
"writtenOn": "2023-05-24T17:10:45Z",
"side": 1,
"message": "Yeah, when we discussed this we said that if we can\u0027t refresh the cache because cinder is down, just re-use what we have. It might be worth calling that out specifically just to avoid further confusion.",
"parentUuid": "6cff9dd0_fc8e3234",
"revId": "befeb2b945cd58663433afb9b0cf50ba54c64c30",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {