52cdd374b6
Patch Set 1: (3 comments) Patch-set: 1
126 lines
5.3 KiB
Plaintext
126 lines
5.3 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "a1d5484b_fde3f5d1",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 11604
|
|
},
|
|
"writtenOn": "2024-02-19T14:12:22Z",
|
|
"side": 1,
|
|
"message": "soft +1 i generally agree with this idea and doing it in tree but before reviing this in detail i want to see what others think",
|
|
"revId": "235a019801f5ae30bc82409818d19a57af88aafc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "149aabbb_49a41c54",
|
|
"filename": "specs/2024.2/approved/openapi.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 51,
|
|
"author": {
|
|
"id": 11604
|
|
},
|
|
"writtenOn": "2024-02-19T14:12:22Z",
|
|
"side": 1,
|
|
"message": "as an end user i want staticaly viewable docuemetaiton hosted as part of the\nexisting docs site without requireing a running nova.\n\nim adding this because i dont think it would be accpable to remove the existing api-ref site or break any of our existing hyperlinks.\n\nwe can supprot this feature in addtion to the api-ref but if we were to ever attpemt to reomve the api and use the openaip defs as a replacment i woudl requrie the ablity to generate static html pages to do that removal.\n\ni.e. even with openapi we need to keep https://docs.openstack.org/api-ref/compute/ or provide a replacement that we can host at that location wiht the same ablity to link too each endpoint directly ideally with the abllity to also expoand/collapse that endpoint via the url.",
|
|
"revId": "235a019801f5ae30bc82409818d19a57af88aafc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "9a5c3d20_a7800b95",
|
|
"filename": "specs/2024.2/approved/openapi.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 51,
|
|
"author": {
|
|
"id": 15334
|
|
},
|
|
"writtenOn": "2024-02-21T18:07:02Z",
|
|
"side": 1,
|
|
"message": "Yeah, I\u0027d expect we\u0027d store a cached version of that dependency in-tree to avoid having to build it every time. The API doesn\u0027t change that frequently.",
|
|
"parentUuid": "149aabbb_49a41c54",
|
|
"revId": "235a019801f5ae30bc82409818d19a57af88aafc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "82838fca_89f0cc93",
|
|
"filename": "specs/2024.2/approved/openapi.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 122,
|
|
"author": {
|
|
"id": 11604
|
|
},
|
|
"writtenOn": "2024-02-19T14:12:22Z",
|
|
"side": 1,
|
|
"message": "im a hard no on maintianing this out of tree offically.\n\nmeainging i think it would be inappropate for another official project like the openstack sdk to maintian openapi schema defintions for the nova api.\n\nso the only way i htink this could work would be in a new repo that is a deliverable of the compute team i.e. a nova-lib.\n\ni could get behind nova-lib if in addtion to hosting the api schemas it also had the notifocation OVOs and possible all the nova objects.\n\nthe reasoning for that is the notifcation ovo are intended to be imporable to use to parse our notificaitons and it may be nice to have thos in there own lib with the api schemas so that you could generate api and rpc clients.\n\nin generall i would prefer to keep everything in the nova repo so i agree with this being an alternitive and not the prefered path.",
|
|
"revId": "235a019801f5ae30bc82409818d19a57af88aafc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "8aa8561b_67fdc416",
|
|
"filename": "specs/2024.2/approved/openapi.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 122,
|
|
"author": {
|
|
"id": 15334
|
|
},
|
|
"writtenOn": "2024-02-21T18:07:02Z",
|
|
"side": 1,
|
|
"message": "Acknowledged",
|
|
"parentUuid": "82838fca_89f0cc93",
|
|
"revId": "235a019801f5ae30bc82409818d19a57af88aafc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "60b8defb_6ca9e2eb",
|
|
"filename": "specs/2024.2/approved/openapi.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 240,
|
|
"author": {
|
|
"id": 11604
|
|
},
|
|
"writtenOn": "2024-02-19T14:12:22Z",
|
|
"side": 1,
|
|
"message": "ack generation of the api-ref in its current form https://docs.openstack.org/api-ref/compute/ from the open api defs would make sense to do.\n\nthat keeps them in sync and fulfils my request/requirement of maintaining the ability to generate static htmp/pdf versions of that document.",
|
|
"revId": "235a019801f5ae30bc82409818d19a57af88aafc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "9c57922d_5d5af030",
|
|
"filename": "specs/2024.2/approved/openapi.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 240,
|
|
"author": {
|
|
"id": 15334
|
|
},
|
|
"writtenOn": "2024-02-21T18:07:02Z",
|
|
"side": 1,
|
|
"message": "Acknowledged",
|
|
"parentUuid": "60b8defb_6ca9e2eb",
|
|
"revId": "235a019801f5ae30bc82409818d19a57af88aafc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |