656 lines
24 KiB
Plaintext
656 lines
24 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "ea47e80f_07fce4a3",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 9,
|
|
"author": {
|
|
"id": 11604
|
|
},
|
|
"writtenOn": "2022-10-26T22:39:22Z",
|
|
"side": 1,
|
|
"message": "so this needs to be wrapped proeprly\n\nbut in generall looking at the code in the https://github.com/napatech/linkvirt-ovs-openstack-plugin\n\nthe main question is why are you adding a new ml2 driver, os-vif plugin and vif_type\n\nwe we could trivially add supprot for virtio-forwarded to the normal ml2/ovs ml2 dirver or ml2/ovn driver for virtio-forwarder.\n\nas far as i can see there is noting vendeor specific so i would prefer to just support virtio-forwarder genericaly unless there is a strong reason not to do that.\n\nim sure that this will eventually get supported by upstream ovs so if we do it once now we wont need to update nova or neutron again when that happens with ovs-dpdk upstream",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "f3c78726_56047f8e",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 9,
|
|
"author": {
|
|
"id": 11604
|
|
},
|
|
"writtenOn": "2022-10-26T22:52:20Z",
|
|
"side": 1,
|
|
"message": "upstream ovs-dpdk already has experimental supprot for hardware offloads\n\nhttps://docs.openvswitch.org/en/latest/howto/dpdk/#flow-hardware-offload-experimental\n\nwhich woudl use virtio-forwarder/vhost-user correct.\n\nthe Napatech (NT200B01) is one of the validated drivers for that\n\nhow does what this spec tries to enable differ from the upstream representor supprot \nhttps://docs.openvswitch.org/en/latest/topics/dpdk/phy/#representors\n\nhttps://github.com/napatech/linkvirt-ovs-openstack-plugin/blob/main/vif_plug_linkvirt_ovs/ovsdb/lv_ovsdb_lib.py#L102-L112\nseams to just be enabling that fucntionaltiy",
|
|
"parentUuid": "ea47e80f_07fce4a3",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "372ba885_e2b94293",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 9,
|
|
"author": {
|
|
"id": 35489
|
|
},
|
|
"writtenOn": "2022-11-03T11:37:28Z",
|
|
"side": 1,
|
|
"message": "Hello, Sean\n\nWe\u0027ve implemented a separate driver because we have next specific item in our solution:\n1. We have the next path to the socket: /usr/local/var/run/ and the socket name has the next configuration: stdvio + vf number. So for example, if we use PCI with virtual function 6 ( 0000.2b00.6 ) we will have socket name stdvio6\nYou can see implementation of that here:\nhttps://github.com/napatech/linkvirt-ovs-openstack-plugin/blob/main/networking_napatech/mech_linkvirt_ovs.py#L62",
|
|
"parentUuid": "f3c78726_56047f8e",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "fa1b1df0_baf0df76",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 9,
|
|
"author": {
|
|
"id": 11604
|
|
},
|
|
"writtenOn": "2022-12-15T10:34:30Z",
|
|
"side": 1,
|
|
"message": "the socket name could be computed by neutron and passed to nova as part of the vif binding details.\n\nso if that is all that is required i think the nova side can be kept generic.",
|
|
"parentUuid": "372ba885_e2b94293",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "7fa89459_9d210f53",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 9,
|
|
"author": {
|
|
"id": 35489
|
|
},
|
|
"writtenOn": "2023-01-06T21:45:02Z",
|
|
"side": 1,
|
|
"message": "We reworked our approach. \nAccording to the previous comments, custom plugin was removed and ovs driver with virtio-forwarder was extended",
|
|
"parentUuid": "fa1b1df0_baf0df76",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "86bd5171_f71011d2",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 9,
|
|
"author": {
|
|
"id": 35489
|
|
},
|
|
"writtenOn": "2023-03-16T12:07:13Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "7fa89459_9d210f53",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "5fb9e8ab_921a86d0",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 8313
|
|
},
|
|
"writtenOn": "2022-10-03T13:29:54Z",
|
|
"side": 1,
|
|
"message": "From Neutron perspective, it looks ok, and in sync with what we have for other smartnics. We quickly discussed this during the last drivers meeting:\nhttps://meetings.opendev.org/meetings/neutron_drivers/2022/neutron_drivers.2022-09-30-14.01.log.html#l-74\n\nThe team basically agreed to go this way, and accept nova-spec to continue with neutron patch.",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "a34fb566_b6403acb",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 35239
|
|
},
|
|
"writtenOn": "2022-10-03T13:38:31Z",
|
|
"side": 1,
|
|
"message": "Thanks for the update. I will update the missing fields and also documentation (w/ rel. notes) as requested in neutron-lib change.",
|
|
"parentUuid": "5fb9e8ab_921a86d0",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "581e870e_c2227dcf",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 11604
|
|
},
|
|
"writtenOn": "2022-10-18T12:10:28Z",
|
|
"side": 1,
|
|
"message": "ill try and find time to review this in the next week or two\ndependitn on how the ptg goes.\n\ni just wanted to highlight that feature in os-vif are tracked as RFE bugs\nyou only need a spec if you need to change nova/neutron.\n\nso we might be able to do this as a specless blueprint in nova ill add it to the ptg agenda if you have not already done so and we can try and see if this requies a spec.\n\ni am expecting the nova change to be relitivly trivial just passign the extra info to os-vif since you already have an os-vif plugin.\n\na spec would be required if you need to modify the xml generation or do more invasive changes to nova but if its just passing the extra info to os-vif that proably doabel specless.",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "4c499f87_5a3f3f04",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 11604
|
|
},
|
|
"writtenOn": "2022-12-15T10:45:07Z",
|
|
"side": 1,
|
|
"message": "if you still intend to proceed with this this cycle please try and rework this to adress the commets inline before teh end fo the week.\n\nTo set expectations most of the core team will be away until spec freeze so its unlikely this will get the rewiew attention required before sepc freeze to proceed this cycle.",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "c07d20d0_a0760530",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 7730
|
|
},
|
|
"writtenOn": "2023-01-10T09:32:21Z",
|
|
"side": 1,
|
|
"message": "I don\u0027t see any blocker supporting it. Could you just review the spec to make it conform based on indications? Thanks a lot.",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "2dbfe673_2999d68c",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 35489
|
|
},
|
|
"writtenOn": "2023-03-16T12:07:13Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "a34fb566_b6403acb",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "31f251bf_bd683ec8",
|
|
"filename": "specs/2023.1/approved/napatech-linkvirtualization-smartnic-support.rst",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 11,
|
|
"author": {
|
|
"id": 7730
|
|
},
|
|
"writtenOn": "2023-01-10T09:32:21Z",
|
|
"side": 1,
|
|
"message": "nit: This need to be updated",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "97ae8eab_49dc7b3d",
|
|
"filename": "specs/2023.1/approved/napatech-linkvirtualization-smartnic-support.rst",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 11,
|
|
"author": {
|
|
"id": 35239
|
|
},
|
|
"writtenOn": "2023-01-10T10:00:55Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "31f251bf_bd683ec8",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "c9c4f33d_485ecc27",
|
|
"filename": "specs/2023.1/approved/napatech-linkvirtualization-smartnic-support.rst",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 17,
|
|
"author": {
|
|
"id": 11604
|
|
},
|
|
"writtenOn": "2022-10-26T22:39:22Z",
|
|
"side": 1,
|
|
"message": "this patch is to the spec repo, so no, it does not update the souce code to do that.\n\ni was just remove this final sentence",
|
|
"range": {
|
|
"startLine": 15,
|
|
"startChar": 36,
|
|
"endLine": 17,
|
|
"endChar": 35
|
|
},
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "dff8ea93_b863c499",
|
|
"filename": "specs/2023.1/approved/napatech-linkvirtualization-smartnic-support.rst",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 17,
|
|
"author": {
|
|
"id": 35489
|
|
},
|
|
"writtenOn": "2023-03-16T12:07:13Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "c9c4f33d_485ecc27",
|
|
"range": {
|
|
"startLine": 15,
|
|
"startChar": 36,
|
|
"endLine": 17,
|
|
"endChar": 35
|
|
},
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "6899ffca_e61742da",
|
|
"filename": "specs/2023.1/approved/napatech-linkvirtualization-smartnic-support.rst",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 25,
|
|
"author": {
|
|
"id": 11604
|
|
},
|
|
"writtenOn": "2022-10-26T22:39:22Z",
|
|
"side": 1,
|
|
"message": "we currently supprot virtio_forwarder for AGILIO OVS\nhttps://github.com/openstack/nova/blob/master/nova/network/os_vif_util.py#L371-L394\n\ncan describe a littel how the napatech solution differs.\n\nalso this patch does not change anything.\n\nthe spec descirbes the cahnge required to enable the integration but does nothing by itself",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "2da3bb13_1337f7b6",
|
|
"filename": "specs/2023.1/approved/napatech-linkvirtualization-smartnic-support.rst",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 25,
|
|
"author": {
|
|
"id": 35489
|
|
},
|
|
"writtenOn": "2023-03-16T12:07:13Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "6899ffca_e61742da",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "9c1131f2_f604182e",
|
|
"filename": "specs/2023.1/approved/napatech-linkvirtualization-smartnic-support.rst",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 28,
|
|
"author": {
|
|
"id": 11604
|
|
},
|
|
"writtenOn": "2022-10-26T22:39:22Z",
|
|
"side": 1,
|
|
"message": "correct new vnic_types shoudl only be added if it change the interface to the instance. differnt network vendors shoudl share vnic types if and when possibe.\n\nvif_type however can be vendor specific if requried.",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "be90372f_c0035947",
|
|
"filename": "specs/2023.1/approved/napatech-linkvirtualization-smartnic-support.rst",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 28,
|
|
"author": {
|
|
"id": 35489
|
|
},
|
|
"writtenOn": "2023-03-16T12:07:13Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "9c1131f2_f604182e",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "1c2dd7f2_c81a3275",
|
|
"filename": "specs/2023.1/approved/napatech-linkvirtualization-smartnic-support.rst",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 35,
|
|
"author": {
|
|
"id": 11604
|
|
},
|
|
"writtenOn": "2022-10-26T22:39:22Z",
|
|
"side": 1,
|
|
"message": "thats not really a usecase.",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "fa1296e4_4165f7ee",
|
|
"filename": "specs/2023.1/approved/napatech-linkvirtualization-smartnic-support.rst",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 35,
|
|
"author": {
|
|
"id": 7730
|
|
},
|
|
"writtenOn": "2023-01-10T09:32:21Z",
|
|
"side": 1,
|
|
"message": "Yes :-) Please just indicate that as an user of blabla I want to use this super mega cool feature.",
|
|
"parentUuid": "1c2dd7f2_c81a3275",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "7645558a_fe966120",
|
|
"filename": "specs/2023.1/approved/napatech-linkvirtualization-smartnic-support.rst",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 35,
|
|
"author": {
|
|
"id": 35239
|
|
},
|
|
"writtenOn": "2023-01-10T10:00:55Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "fa1296e4_4165f7ee",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "2a58fab8_4e96a0ff",
|
|
"filename": "specs/2023.1/approved/napatech-linkvirtualization-smartnic-support.rst",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 41,
|
|
"author": {
|
|
"id": 11604
|
|
},
|
|
"writtenOn": "2022-10-26T22:39:22Z",
|
|
"side": 1,
|
|
"message": "other then the plugin \n\nthe change proposed in https://review.opendev.org/c/openstack/nova/+/859577/1/nova/network/os_vif_util.py apeare to be identical to \nhttps://github.com/openstack/nova/blob/master/nova/network/os_vif_util.py#L380-L390\n\n\ni think i woudl almost prefer to allow the vif plugin name to be passed form neutron to nova so that we can reuse as much of the code as possibel.\n\ni.e. make it so that you only need to change nova if you need to add a new vnic type not a new vif type.\n\n\nlooking at \nhttps://github.com/napatech/linkvirt-ovs-openstack-plugin\nim not sure why we would not just add supprot for virtio-forwarder to the ovs ml2 driver and/or ovn.\n\ni dont see anything napatec specific. \n\nwe also dont need to pass the network type here\nhttps://github.com/napatech/linkvirt-ovs-openstack-plugin/blob/main/networking_napatech/mech_linkvirt_ovs.py#L68\n\nwe can but nova can just get that from the network\nhere https://github.com/openstack/nova/blob/b1958b7cfa6b8aca5b76b3f133627bb733d29f00/nova/network/neutron.py#L3221",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "78af0d0e_b987a046",
|
|
"filename": "specs/2023.1/approved/napatech-linkvirtualization-smartnic-support.rst",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 41,
|
|
"author": {
|
|
"id": 35489
|
|
},
|
|
"writtenOn": "2022-11-03T11:37:28Z",
|
|
"side": 1,
|
|
"message": "If Agilio method rewriting is allowed, we can do it in the way, as you suggested.\n\n\nWe can remove the network_type variable from the neutron and does not use it in the OpenStack layer.",
|
|
"parentUuid": "2a58fab8_4e96a0ff",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "292faec0_96203172",
|
|
"filename": "specs/2023.1/approved/napatech-linkvirtualization-smartnic-support.rst",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 41,
|
|
"author": {
|
|
"id": 11604
|
|
},
|
|
"writtenOn": "2022-12-15T10:34:30Z",
|
|
"side": 1,
|
|
"message": "if the change is additive then yes if not then we need to have two ways of doing this.",
|
|
"parentUuid": "78af0d0e_b987a046",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "5d5dab82_75f30fff",
|
|
"filename": "specs/2023.1/approved/napatech-linkvirtualization-smartnic-support.rst",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 41,
|
|
"author": {
|
|
"id": 35489
|
|
},
|
|
"writtenOn": "2023-03-16T12:07:13Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "292faec0_96203172",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "e6c30d0f_0736fa31",
|
|
"filename": "specs/2023.1/approved/napatech-linkvirtualization-smartnic-support.rst",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 103,
|
|
"author": {
|
|
"id": 11604
|
|
},
|
|
"writtenOn": "2022-12-15T10:45:07Z",
|
|
"side": 1,
|
|
"message": "this isnt really and upgrade impact it should be moved the the propsoed changes section. the min version of os-vif will need to be increased in nova requirements file to enable this but again that is not conisdered and upgrade impact so we can just list \"None\" here.",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "469a2608_333d24fb",
|
|
"filename": "specs/2023.1/approved/napatech-linkvirtualization-smartnic-support.rst",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 103,
|
|
"author": {
|
|
"id": 35489
|
|
},
|
|
"writtenOn": "2023-03-16T12:07:13Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "e6c30d0f_0736fa31",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "15da236e_e9b6c0c3",
|
|
"filename": "specs/2023.1/approved/napatech-linkvirtualization-smartnic-support.rst",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 111,
|
|
"author": {
|
|
"id": 8313
|
|
},
|
|
"writtenOn": "2022-10-03T13:29:54Z",
|
|
"side": 1,
|
|
"message": "Please fill this field",
|
|
"range": {
|
|
"startLine": 111,
|
|
"startChar": 0,
|
|
"endLine": 111,
|
|
"endChar": 3
|
|
},
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "133025f9_0377a02e",
|
|
"filename": "specs/2023.1/approved/napatech-linkvirtualization-smartnic-support.rst",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 111,
|
|
"author": {
|
|
"id": 11604
|
|
},
|
|
"writtenOn": "2022-12-15T10:45:07Z",
|
|
"side": 1,
|
|
"message": "yes please add you irc nic or gerrit username here.",
|
|
"parentUuid": "15da236e_e9b6c0c3",
|
|
"range": {
|
|
"startLine": 111,
|
|
"startChar": 0,
|
|
"endLine": 111,
|
|
"endChar": 3
|
|
},
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "21ebf2ec_c892a681",
|
|
"filename": "specs/2023.1/approved/napatech-linkvirtualization-smartnic-support.rst",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 111,
|
|
"author": {
|
|
"id": 7730
|
|
},
|
|
"writtenOn": "2023-01-10T09:32:21Z",
|
|
"side": 1,
|
|
"message": "is not the launchpad id?",
|
|
"parentUuid": "133025f9_0377a02e",
|
|
"range": {
|
|
"startLine": 111,
|
|
"startChar": 0,
|
|
"endLine": 111,
|
|
"endChar": 3
|
|
},
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "c01fff85_ab32bf09",
|
|
"filename": "specs/2023.1/approved/napatech-linkvirtualization-smartnic-support.rst",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 111,
|
|
"author": {
|
|
"id": 35239
|
|
},
|
|
"writtenOn": "2023-01-10T10:00:55Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "21ebf2ec_c892a681",
|
|
"range": {
|
|
"startLine": 111,
|
|
"startChar": 0,
|
|
"endLine": 111,
|
|
"endChar": 3
|
|
},
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "0220ebf0_c7b82371",
|
|
"filename": "specs/2023.1/approved/napatech-linkvirtualization-smartnic-support.rst",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 121,
|
|
"author": {
|
|
"id": 11604
|
|
},
|
|
"writtenOn": "2022-10-26T22:39:22Z",
|
|
"side": 1,
|
|
"message": "so technially you are not actully ment to start wrighting the code until after the spec is approved in general since the design can change radically in spec review.\nso in generally we dont include link to reviews in the spec.",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "210d6b74_4c70d478",
|
|
"filename": "specs/2023.1/approved/napatech-linkvirtualization-smartnic-support.rst",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 121,
|
|
"author": {
|
|
"id": 35489
|
|
},
|
|
"writtenOn": "2023-03-16T12:07:13Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "0220ebf0_c7b82371",
|
|
"revId": "679d5f2b2f0a9faaa6689462442cd903ebb779dc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |