openstack
/
nova-specs
Code Issues Proposed changes
nova-specs/efa921b99b9a4a1fac42bef6f1b...

307 lines
11 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "074d7309_23fef572",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 6
},
"lineNbr": 0,
"author": {
"id": 11604
},
"writtenOn": "2023-03-13T13:17:26Z",
"side": 1,
"message": "i have not done a review of this today but i will re review when you update it with our conversation form irc\n\n",
"revId": "efa921b99b9a4a1fac42bef6f1b12866effa0ecb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "67ace3bc_e1077449",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 6
},
"lineNbr": 0,
"author": {
"id": 11604
},
"writtenOn": "2023-03-13T13:39:58Z",
"side": 1,
"message": "this need a little more context and detail in general.\n\nhaving looked at the code for this feature which is pretty small we dont need the spec to be very long just need more detail to help other cores understand what you are trying to enable.\n\n",
"revId": "efa921b99b9a4a1fac42bef6f1b12866effa0ecb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f82f9bce_063aad4e",
"filename": "specs/2023.2/approved/napatech-linkvirtualization-smartnic-support.rst",
"patchSetId": 6
},
"lineNbr": 26,
"author": {
"id": 11604
},
"writtenOn": "2023-03-13T13:39:58Z",
"side": 1,
"message": "Napatech SmartNICs can offload several computational resource-intensive tasks\nfrom the hypervisor, such as packet switching, QoS enforcement, and V(x)LAN\ntunnel encapsulation/decapsulation. Upstream and Out of tree OVS implementations can leverage these offloads when using dpdk via dpdk port representors.\nhttps://docs.openvswitch.org/en/latest/topics/dpdk/phy/#representors\n\nnova and os-vif currently support kernel-based vf representors but not dpdk vf representors which leverage vhost-user socket. This spec seeks to address that gap.",
"revId": "efa921b99b9a4a1fac42bef6f1b12866effa0ecb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "067790a4_489a2526",
"filename": "specs/2023.2/approved/napatech-linkvirtualization-smartnic-support.rst",
"patchSetId": 6
},
"lineNbr": 26,
"author": {
"id": 35489
},
"writtenOn": "2023-03-16T12:06:51Z",
"side": 1,
"message": "Done",
"parentUuid": "f82f9bce_063aad4e",
"revId": "efa921b99b9a4a1fac42bef6f1b12866effa0ecb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1528a33b_197ace6a",
"filename": "specs/2023.2/approved/napatech-linkvirtualization-smartnic-support.rst",
"patchSetId": 6
},
"lineNbr": 28,
"author": {
"id": 11604
},
"writtenOn": "2023-03-13T13:39:58Z",
"side": 1,
"message": "this shoudl be in proposed changes section.\n\nProblem description is the \"what we want to change\"\n\nUse Cases is the \"why we want to change it\"\n\nand Proposed change is the \"how we want to change it\"\n\nso this is part of the \"how\" not the \"what\"",
"range": {
"startLine": 27,
"startChar": 0,
"endLine": 28,
"endChar": 63
},
"revId": "efa921b99b9a4a1fac42bef6f1b12866effa0ecb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f2f690ad_8f3fb3c6",
"filename": "specs/2023.2/approved/napatech-linkvirtualization-smartnic-support.rst",
"patchSetId": 6
},
"lineNbr": 28,
"author": {
"id": 35489
},
"writtenOn": "2023-03-16T12:06:51Z",
"side": 1,
"message": "Done",
"parentUuid": "1528a33b_197ace6a",
"range": {
"startLine": 27,
"startChar": 0,
"endLine": 28,
"endChar": 63
},
"revId": "efa921b99b9a4a1fac42bef6f1b12866effa0ecb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "01d843e3_edc3d518",
"filename": "specs/2023.2/approved/napatech-linkvirtualization-smartnic-support.rst",
"patchSetId": 6
},
"lineNbr": 40,
"author": {
"id": 11604
},
"writtenOn": "2023-03-13T13:39:58Z",
"side": 1,
"message": "right so this has change now we are not adding any new vnic or vif type just adding virtio-forwarder supprot to the ovs vif type",
"range": {
"startLine": 39,
"startChar": 0,
"endLine": 40,
"endChar": 52
},
"revId": "efa921b99b9a4a1fac42bef6f1b12866effa0ecb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "4ee61695_92a885b6",
"filename": "specs/2023.2/approved/napatech-linkvirtualization-smartnic-support.rst",
"patchSetId": 6
},
"lineNbr": 40,
"author": {
"id": 35489
},
"writtenOn": "2023-03-16T12:06:51Z",
"side": 1,
"message": "Done",
"parentUuid": "01d843e3_edc3d518",
"range": {
"startLine": 39,
"startChar": 0,
"endLine": 40,
"endChar": 52
},
"revId": "efa921b99b9a4a1fac42bef6f1b12866effa0ecb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ede0903d_e6e063d2",
"filename": "specs/2023.2/approved/napatech-linkvirtualization-smartnic-support.rst",
"patchSetId": 6
},
"lineNbr": 84,
"author": {
"id": 11604
},
"writtenOn": "2023-03-13T13:39:58Z",
"side": 1,
"message": "well it shoudl be about the same as normal hardware offloaded OVS\n\nbut yes vs kernel ovs or even tradtional vhost-user it should increase",
"revId": "efa921b99b9a4a1fac42bef6f1b12866effa0ecb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "5bc7a591_9808309a",
"filename": "specs/2023.2/approved/napatech-linkvirtualization-smartnic-support.rst",
"patchSetId": 6
},
"lineNbr": 84,
"author": {
"id": 35489
},
"writtenOn": "2023-03-16T12:06:51Z",
"side": 1,
"message": "Done",
"parentUuid": "ede0903d_e6e063d2",
"revId": "efa921b99b9a4a1fac42bef6f1b12866effa0ecb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f26ad823_53d165b0",
"filename": "specs/2023.2/approved/napatech-linkvirtualization-smartnic-support.rst",
"patchSetId": 6
},
"lineNbr": 91,
"author": {
"id": 11604
},
"writtenOn": "2023-03-13T13:39:58Z",
"side": 1,
"message": "we renamed the passthrough_whitelist\n[pci]\npassthrough_whitelist\nto\n[pci]\ndevice_spec\nso we shoudl use this instead\nhttps://docs.openstack.org/nova/latest/configuration/config.html#pci.device_spec\n\n\nThis solution is using dpdk vdevs\n\nin the past dpdk used to have a limit of 32 of these due to the number of bits allcoated to the the dpdk interface index in the the mbuf structure\n\nhas that been fixed yet?\n\nif there are limits in the number of ports imposed by ovs/dpdk beyond the number of VFs that can be allocated on a nic we should call this out.\n\nbascially we dont want operators thinkign if they need more prots they can just add an addtion nic if that wont actully work.",
"revId": "efa921b99b9a4a1fac42bef6f1b12866effa0ecb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "01fa804d_b4eea7ac",
"filename": "specs/2023.2/approved/napatech-linkvirtualization-smartnic-support.rst",
"patchSetId": 6
},
"lineNbr": 91,
"author": {
"id": 35489
},
"writtenOn": "2023-03-16T12:06:51Z",
"side": 1,
"message": "Done",
"parentUuid": "f26ad823_53d165b0",
"revId": "efa921b99b9a4a1fac42bef6f1b12866effa0ecb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "53874112_02ecd861",
"filename": "specs/2023.2/approved/napatech-linkvirtualization-smartnic-support.rst",
"patchSetId": 6
},
"lineNbr": 102,
"author": {
"id": 11604
},
"writtenOn": "2023-03-13T13:39:58Z",
"side": 1,
"message": "ack\nform a nova presepctive there really isnt any other than\nfor this to work you need to have updated nova, os-vif and neutorn to a version that supprot the feature.",
"revId": "efa921b99b9a4a1fac42bef6f1b12866effa0ecb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e4d510f3_a2f4729c",
"filename": "specs/2023.2/approved/napatech-linkvirtualization-smartnic-support.rst",
"patchSetId": 6
},
"lineNbr": 102,
"author": {
"id": 35489
},
"writtenOn": "2023-03-16T12:06:51Z",
"side": 1,
"message": "Done",
"parentUuid": "53874112_02ecd861",
"revId": "efa921b99b9a4a1fac42bef6f1b12866effa0ecb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7360d87d_436c1568",
"filename": "specs/2023.2/approved/napatech-linkvirtualization-smartnic-support.rst",
"patchSetId": 6
},
"lineNbr": 118,
"author": {
"id": 11604
},
"writtenOn": "2023-03-13T13:39:58Z",
"side": 1,
"message": "i can act as a Liaison for this if you liek\n\n\"sean-k-mooney\"",
"revId": "efa921b99b9a4a1fac42bef6f1b12866effa0ecb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "96b4c13b_5779c4bc",
"filename": "specs/2023.2/approved/napatech-linkvirtualization-smartnic-support.rst",
"patchSetId": 6
},
"lineNbr": 118,
"author": {
"id": 35489
},
"writtenOn": "2023-03-16T12:06:51Z",
"side": 1,
"message": "Done",
"parentUuid": "7360d87d_436c1568",
"revId": "efa921b99b9a4a1fac42bef6f1b12866effa0ecb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
View Git Blame Copy Permalink