107 lines
3.6 KiB
Plaintext
107 lines
3.6 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "baaf3b01_c64ae4d4",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 9708
|
|
},
|
|
"writtenOn": "2022-12-14T14:12:49Z",
|
|
"side": 1,
|
|
"message": "looks good to me",
|
|
"revId": "197971ded63ef83a9af2df5b1410cd185a1dcdc1",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "a99eee7b_6bbe091c",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 7166
|
|
},
|
|
"writtenOn": "2022-12-14T14:45:38Z",
|
|
"side": 1,
|
|
"message": "IMHO, we still have a few thoughts that need the spec to be modified for adding more comments about the RPC API and about the os-instance API modification.",
|
|
"revId": "197971ded63ef83a9af2df5b1410cd185a1dcdc1",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "6478f4cf_9546ec13",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 11604
|
|
},
|
|
"writtenOn": "2022-12-15T09:53:38Z",
|
|
"side": 1,
|
|
"message": "im holding +2w because i would like to see sylvain\u0027s requests adressed before this is merged and the agreement we reached in https://review.opendev.org/c/openstack/nova-specs/+/863884/5/specs/2023.1/approved/update-userdata.rst#92 added to the spec.\n\nif you repsin this with the comments inline adressed i think we can merge this this week.",
|
|
"revId": "197971ded63ef83a9af2df5b1410cd185a1dcdc1",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "8e09c3f1_b335c304",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 33634
|
|
},
|
|
"writtenOn": "2022-12-19T12:42:30Z",
|
|
"side": 1,
|
|
"message": "All comments should now be addressed in the updated spec.\n\nI have also rearranged the flow of config drive regeneration as I think that we only need to check whether compute driver supports this when we actually would want to call the RPC method, which is only the last case.\nOtherwise, we would fail even though the compute driver could fulfill the request.",
|
|
"revId": "197971ded63ef83a9af2df5b1410cd185a1dcdc1",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "a9357cce_581349d9",
|
|
"filename": "specs/2023.1/approved/update-userdata.rst",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 130,
|
|
"author": {
|
|
"id": 11604
|
|
},
|
|
"writtenOn": "2022-12-14T15:33:03Z",
|
|
"side": 1,
|
|
"message": "we woudl jsut need the new action start and end notification for this",
|
|
"revId": "197971ded63ef83a9af2df5b1410cd185a1dcdc1",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "99a1761c_2cdda235",
|
|
"filename": "specs/2023.1/approved/update-userdata.rst",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 130,
|
|
"author": {
|
|
"id": 33634
|
|
},
|
|
"writtenOn": "2022-12-19T12:42:30Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "a9357cce_581349d9",
|
|
"revId": "197971ded63ef83a9af2df5b1410cd185a1dcdc1",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |