openstack/nova
Code Issues Proposed changes

Update notes for submitted changes

Browse Source 
* Move setup of libvirt disk cachemode into imagebackend module
* Ensure to use 'hdN' for IDE disk device in libvirt driver
* Don't hardcode use of 'virtio' for root disk in libvirt driver
* Move more libvirt disk setup into the imagebackend module
* Refactor libvirt imagebackend module to reduce code duplication
* Move libvirt disk config setup out of main get_guest_config method
* Don't set device='cdrom' for all disks in libvirt driver
* Get rid of pointless 'suffix' parameter in libvirt imagebackend
This commit is contained in:
Jenkins
2012-07-20 20:42:36 +00:00
committed by Gerrit Code Review
parent bdfff5b22e
commit 0168a213e4
8 changed files with 82 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
1e/c856db22c798bffbf0f7d5def0e880a8fc9842 Normal file
View File

@@ -0,0 +1,10 @@
Verified+2: Jenkins
Approved+1: Trey Morris <trey.morris@rackspace.com>
Code-Review+2: Trey Morris <trey.morris@rackspace.com>
Code-Review+2: Josh Kearney <josh@jk0.org>
Verified+1: SmokeStack
Submitted-by: Jenkins
Submitted-at: Fri, 20 Jul 2012 16:38:46 +0000
Reviewed-on: https://review.openstack.org/10053
Project: openstack/nova
Branch: refs/heads/master

10
27/66ee2b6ed68f1784aad1b41e81baa75cc305df Normal file
View File

@@ -0,0 +1,10 @@
Verified+2: Jenkins
Approved+1: Trey Morris <trey.morris@rackspace.com>
Code-Review+2: Trey Morris <trey.morris@rackspace.com>
Code-Review+2: Josh Kearney <josh@jk0.org>
Verified+1: SmokeStack
Submitted-by: Jenkins
Submitted-at: Fri, 20 Jul 2012 16:46:54 +0000
Reviewed-on: https://review.openstack.org/10054
Project: openstack/nova
Branch: refs/heads/master

9
55/1078b567b9650353fd9695f7c88fb9ed1da0f9 Normal file
View File

@@ -0,0 +1,9 @@
Verified+2: Jenkins
Approved+1: Trey Morris <trey.morris@rackspace.com>
Code-Review+2: Trey Morris <trey.morris@rackspace.com>
Code-Review+2: Josh Kearney <josh@jk0.org>
Submitted-by: Jenkins
Submitted-at: Fri, 20 Jul 2012 16:30:43 +0000
Reviewed-on: https://review.openstack.org/10052
Project: openstack/nova
Branch: refs/heads/master

11
6d/7bf9a2f9491ae9c7ad54b8b7a38a6e11a4bfcd Normal file
View File

@@ -0,0 +1,11 @@
Verified+2: Jenkins
Approved+1: Vish Ishaya <vishvananda@gmail.com>
Code-Review+2: Vish Ishaya <vishvananda@gmail.com>
Code-Review+2: Kevin L. Mitchell <kevin.mitchell@rackspace.com>
Code-Review+1: Joe Gordon <jogo@cloudscaling.com>
Verified+1: SmokeStack
Submitted-by: Jenkins
Submitted-at: Fri, 20 Jul 2012 20:42:36 +0000
Reviewed-on: https://review.openstack.org/10048
Project: openstack/nova
Branch: refs/heads/master

10
72/92473944762c42c0d04e16599822ab55d9b726 Normal file
View File

@@ -0,0 +1,10 @@
Verified+2: Jenkins
Approved+1: Trey Morris <trey.morris@rackspace.com>
Code-Review+2: Trey Morris <trey.morris@rackspace.com>
Code-Review+2: Josh Kearney <josh@jk0.org>
Verified+1: SmokeStack
Submitted-by: Jenkins
Submitted-at: Fri, 20 Jul 2012 16:22:23 +0000
Reviewed-on: https://review.openstack.org/10049
Project: openstack/nova
Branch: refs/heads/master

11
7b/5a46b29fe994e9dc973bd7e5b60dee9f803f91 Normal file
View File

@@ -0,0 +1,11 @@
Verified+2: Jenkins
Approved+1: Vish Ishaya <vishvananda@gmail.com>
Code-Review+2: Vish Ishaya <vishvananda@gmail.com>
Code-Review+2: Trey Morris <trey.morris@rackspace.com>
Code-Review+2: Kevin L. Mitchell <kevin.mitchell@rackspace.com>
Verified+1: SmokeStack
Submitted-by: Jenkins
Submitted-at: Fri, 20 Jul 2012 20:42:33 +0000
Reviewed-on: https://review.openstack.org/10050
Project: openstack/nova
Branch: refs/heads/master

10
92/83f68ea31ffe97efd075c791211a13a8bae6a9 Normal file
View File

@@ -0,0 +1,10 @@
Verified+2: Jenkins
Approved+1: Trey Morris <trey.morris@rackspace.com>
Code-Review+2: Trey Morris <trey.morris@rackspace.com>
Code-Review+2: Josh Kearney <josh@jk0.org>
Verified+1: SmokeStack
Submitted-by: Jenkins
Submitted-at: Fri, 20 Jul 2012 16:48:16 +0000
Reviewed-on: https://review.openstack.org/10055
Project: openstack/nova
Branch: refs/heads/master

11
cf/f588e67a4a1dee4f0a690c30d467495e0d679f Normal file
View File

@@ -0,0 +1,11 @@
Verified+2: Jenkins
Approved+1: Trey Morris <trey.morris@rackspace.com>
Code-Review+2: Trey Morris <trey.morris@rackspace.com>
Code-Review+2: Josh Kearney <josh@jk0.org>
Code-Review+2: Kevin L. Mitchell <kevin.mitchell@rackspace.com>
Verified+1: SmokeStack
Submitted-by: Jenkins
Submitted-at: Fri, 20 Jul 2012 19:54:29 +0000
Reviewed-on: https://review.openstack.org/10051
Project: openstack/nova
Branch: refs/heads/master