Fix status code of server's action confirm_resize for v3

The status code of confirm_resize should be 202, but it
returns 204 now. That because it returns HTTPNoContent
that overwrites the status code of decorator 'wsgi.response(202)'

And adds API samples for confirm_resize that used to test
the status code of confirm_resize.

Partially implements blueprint v3-api-unittests
Closes-bug: #1233561

Change-Id: I50a3046866af0a1efdb5c41ded40f973b02843e8

doc/v3/api_samples/servers/server-action-confirm-resize.json

@@ -0,0 +1,3 @@
+{
+    "confirm_resize" : null
+}

doc/v3/api_samples/servers/server-action-confirm-resize.xml

@@ -0,0 +1,3 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<confirm_resize
+    xmlns="http://docs.openstack.org/compute/api/v1.1"/>

doc/v3/api_samples/servers/server-action-resize.json

@@ -0,0 +1,5 @@
+{
+    "resize" : {
+        "flavor_ref" : "2"
+    }
+}

doc/v3/api_samples/servers/server-action-resize.xml

@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<resize
+    xmlns="http://docs.openstack.org/compute/api/v1.1"
+    flavor_ref="2"/>

nova/api/openstack/compute/plugins/v3/servers.py

@@ -953,7 +953,6 @@ class ServersController(wsgi.Controller):
         except exception.InstanceInvalidState as state_error:
             common.raise_http_conflict_for_instance_invalid_state(state_error,
                     'confirm_resize')
-        return exc.HTTPNoContent()
 
     @wsgi.response(202)
     @wsgi.serializers(xml=FullServerTemplate)

nova/tests/integrated/v3/api_samples/servers/server-action-confirm-resize.json.tpl

@@ -0,0 +1,3 @@
+{
+    "confirm_resize" : null
+}

nova/tests/integrated/v3/api_samples/servers/server-action-confirm-resize.xml.tpl

@@ -0,0 +1,3 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<confirm_resize
+    xmlns="http://docs.openstack.org/compute/api/v1.1"/>

nova/tests/integrated/v3/api_samples/servers/server-action-resize.json.tpl

@@ -0,0 +1,5 @@
+{
+    "resize" : {
+        "flavor_ref" : "%(id)s"
+    }
+}

nova/tests/integrated/v3/api_samples/servers/server-action-resize.xml.tpl

@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<resize
+    xmlns="http://docs.openstack.org/compute/api/v1.1"
+    flavor_ref="%(id)s"/>

nova/tests/integrated/v3/test_servers.py

@@ -74,3 +74,38 @@ class ServersSampleAllExtensionJsonTest(ServersSampleJsonTest):
 
 class ServersSampleAllExtensionXmlTest(ServersSampleXmlTest):
     all_extensions = True
+
+
+class ServersActionsJsonTest(ServersSampleBase):
+    sample_dir = 'servers'
+
+    def _test_server_action(self, uuid, action,
+                            subs={}, resp_tpl=None, code=202):
+        subs.update({'action': action,
+                     'glance_host': self._get_glance_host()})
+        response = self._do_post('servers/%s/action' % uuid,
+                                 'server-action-%s' % action.replace('_',
+                                                                     '-'),
+                                 subs)
+        if resp_tpl:
+            subs.update(self._get_regexes())
+            self._verify_response(resp_tpl, subs, response, code)
+        else:
+            self.assertEqual(response.status, code)
+            self.assertEqual(response.read(), "")
+
+    def test_server_resize(self):
+        self.flags(allow_resize_to_same_host=True)
+        uuid = self._post_server()
+        self._test_server_action(uuid, "resize",
+                                 {"id": 2,
+                                  "host": self._get_host()})
+        return uuid
+
+    def test_server_confirm_resize(self):
+        uuid = self.test_server_resize()
+        self._test_server_action(uuid, "confirm_resize")
+
+
+class ServersActionsXmlTest(ServersActionsJsonTest):
+    ctype = 'xml'