From 02e0413a8da907700677bc0430b946f9fe02e59c Mon Sep 17 00:00:00 2001 From: Russell Bryant Date: Thu, 16 Jan 2014 18:31:59 -0500 Subject: [PATCH] Remove get_network from nova.network.rpcapi Remove the get_network() method from nova.network.rpcapi. It's not actually used, so help make that clear by removing it from the client rpc class. This also helps us clarify what changes we have to be careful about with respect to rpc versioning. Related to nova-network-objects Change-Id: Ibfcc90499fb6c20b7f14597ea360ed55bb34e058 --- nova/network/rpcapi.py | 5 +---- nova/tests/network/test_rpcapi.py | 4 ---- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/nova/network/rpcapi.py b/nova/network/rpcapi.py index f286d1b42854..599607f0c9f3 100644 --- a/nova/network/rpcapi.py +++ b/nova/network/rpcapi.py @@ -70,6 +70,7 @@ class NetworkAPI(rpcclient.RpcProxy): NOTE: remove unused method get_vifs_by_instance() NOTE: remove unused method get_vif_by_mac_address() + NOTE: remove unused method get_network() ''' # @@ -100,10 +101,6 @@ class NetworkAPI(rpcclient.RpcProxy): def get_all_networks(self, ctxt): return self.client.call(ctxt, 'get_all_networks') - def get_network(self, ctxt, network_uuid): - return self.client.call(ctxt, 'get_network', - network_uuid=network_uuid) - # TODO(russellb): Convert this to named arguments. It's a pretty large # list, so unwinding it all is probably best done in its own patch so it's # easier to review. diff --git a/nova/tests/network/test_rpcapi.py b/nova/tests/network/test_rpcapi.py index 564e770c4f26..474116a2e204 100644 --- a/nova/tests/network/test_rpcapi.py +++ b/nova/tests/network/test_rpcapi.py @@ -101,10 +101,6 @@ class NetworkRpcAPITestCase(test.NoDBTestCase): def test_get_all_networks(self): self._test_network_api('get_all_networks', rpc_method='call') - def test_get_network(self): - self._test_network_api('get_network', rpc_method='call', - network_uuid='fake_uuid') - def test_create_networks(self): self._test_network_api('create_networks', rpc_method='call', arg1='arg', arg2='arg')