openstack/nova
Code Issues Proposed changes

Access DB values as dict not as attributes. Part 2

Browse Source 
We cannot assume nova.db.api will be returning sqlalchemy objects with
attributes, instead treat return values as dicts

Part of blueprint db-api-cleanup

Change-Id: I39ccd2f110c258d69bb2d4d7078c672c6a6ef36e
This commit is contained in:
Joe Gordon
2012-11-29 17:10:30 -08:00
parent adb0f2b0b4
commit 03ae11664d
6 changed files with 99 additions and 99 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
nova/tests/scheduler/test_host_filters.py
View File

@@ -771,7 +771,7 @@ class HostFiltersTestCase(test.TestCase):
'availability_zone': 'fake_avail_zone', }
result = db.aggregate_create(self.context.elevated(), values, metadata)
for host in hosts:
db.aggregate_host_add(self.context.elevated(), result.id, host)
db.aggregate_host_add(self.context.elevated(), result['id'], host)
return result
def _do_test_aggregate_filter_extra_specs(self, emeta, especs, passes):
@@ -797,7 +797,7 @@ class HostFiltersTestCase(test.TestCase):
{'memory_mb': 1024, 'extra_specs': extra_specs}}
host = fakes.FakeHostState('host1', 'node1',
{'free_ram_mb': 1024})
db.aggregate_host_delete(self.context.elevated(), agg2.id, 'host1')
db.aggregate_host_delete(self.context.elevated(), agg2['id'], 'host1')
self.assertFalse(filt_cls.host_passes(host, filter_properties))
def test_aggregate_filter_passes_extra_specs_simple(self):