openstack
/
nova
Code Issues Proposed changes

Add unit tests for missing VirtualInterface in 2.70 os-interface 

This adds some simple unit tests for showing and listing attached
port interfaces where the corresponding VirtualInterface record
does not exist - which is possible for very old port attachments
since we started creating the VirtualInterface record for neutron
ports in the Newton release.

This is a follow up to I09420ff7134874dfe4dc399931c7740e81ecc2d0.

Part of blueprint expose-virtual-device-tags-in-rest-api

Change-Id: If14c4d6e97870de875b5dcd6bf68bd1b56ffad74
This commit is contained in:
Matt Riedemann 2019-02-25 10:57:37 -05:00
parent 1c6fdc9aec
commit 0d4f3f41ee
1 changed files with 42 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
nova/tests/unit/api/openstack/compute/test_attach_interfaces.py
View File

@ -513,6 +513,48 @@ class InterfaceAttachTestsV249(test.NoDBTestCase):
self.attachments.create(self.req, FAKE_UUID1, body=body)
class InterfaceAttachTestsV270(test.NoDBTestCase):
"""os-interface API tests for microversion 2.70"""
def setUp(self):
super(InterfaceAttachTestsV270, self).setUp()
self.attachments = (
attach_interfaces_v21.InterfaceAttachmentController())
self.req = fakes.HTTPRequest.blank('', version='2.70')
self.stub_out('nova.compute.api.API.get', fake_get_instance)
@mock.patch('nova.objects.VirtualInterface.get_by_uuid', return_value=None)
def test_show_interface_no_vif(self, mock_get_by_uuid):
"""Tests GET /servers/{server_id}/os-interface/{id} where there is no
corresponding VirtualInterface database record for the attached port.
"""
with mock.patch.object(self.attachments.network_api, 'show_port',
fake_show_port):
attachment = self.attachments.show(
self.req, FAKE_UUID1, FAKE_PORT_ID1)['interfaceAttachment']
self.assertIn('tag', attachment)
self.assertIsNone(attachment['tag'])
ctxt = self.req.environ['nova.context']
mock_get_by_uuid.assert_called_once_with(ctxt, FAKE_PORT_ID1)
@mock.patch('nova.objects.VirtualInterfaceList.get_by_instance_uuid',
return_value=objects.VirtualInterfaceList())
def test_list_interfaces_no_vifs(self, mock_get_by_instance_uuid):
"""Tests GET /servers/{server_id}/os-interface where there is no
corresponding VirtualInterface database record for the attached ports.
"""
with mock.patch.object(self.attachments.network_api, 'list_ports',
return_value={'ports': ports}) as list_ports:
attachments = self.attachments.index(
self.req, FAKE_UUID1)['interfaceAttachments']
for attachment in attachments:
self.assertIn('tag', attachment)
self.assertIsNone(attachment['tag'])
ctxt = self.req.environ['nova.context']
list_ports.assert_called_once_with(ctxt, device_id=FAKE_UUID1)
mock_get_by_instance_uuid.assert_called_once_with(
self.req.environ['nova.context'], FAKE_UUID1)
class AttachInterfacesPolicyEnforcementv21(test.NoDBTestCase):
def setUp(self):