openstack/nova
Code Issues Proposed changes

Fix advice for new contribs

Browse Source 
The trivial bug list has already got a +1 and often the fixes there are
too trivial to learn very much. Replaced with some hopefully more
useful advice.

Change-Id: Ibf5abc4dca170770d302ae9276312faad5eabdb6
This commit is contained in:
Alexis Lee 2016-01-06 14:24:22 +00:00
parent ea1abcf101
commit 1a3633ef88
2 changed files with 15 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
doc/source/code-review.rst
View File

@ -1,3 +1,5 @@
.. _code-review:
========================== ==========================
Code Review Guide for Nova Code Review Guide for Nova
========================== ==========================

24
doc/source/how_to_get_involved.rst
View File

@ -48,19 +48,21 @@ What should I work on?
So you are starting out your Nova journey, where is a good place to So you are starting out your Nova journey, where is a good place to
start? start?
Bugs are a great way to cut your Nova teeth: If you'd like to learn how Nova works before changing anything (good idea!), we
https://bugs.launchpad.net/nova/+bugs?field.tag=low-hanging-fruit recommend looking for reviews with -1s and -2s and seeing why they got
downvoted. There is also the :ref:`code-review`. Once you have some
understanding, start reviewing patches. It's OK to ask people to explain things
you don't understand. It's also OK to see some potential problems but put a +0.
Also, we guess that you probably want to understand how Nova works Another way is to look for a subteam you'd like to get involved with and review
before changing anything ? Good news, we have a solution for you! Code their patches. See:
reviews are usually the best way for ramping up on a project and get and https://etherpad.openstack.org/p/mitaka-nova-priorities-tracking
compare feedback on what's bad or what's cool. For that, you can help
us. We have a list of trivial bugs that are waiting reviews :
https://etherpad.openstack.org/p/mitaka-nova-priorities-tracking L56 and
below
We also have a list of low hanging fruit work available: Once you're ready to write code, take a look at some of the work already marked
https://etherpad.openstack.org/p/nova-low-hanging-fruit as low-hanging fruit:
* https://bugs.launchpad.net/nova/+bugs?field.tag=low-hanging-fruit
* https://etherpad.openstack.org/p/nova-low-hanging-fruit
How do I get my feature in? How do I get my feature in?
~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~