openstack/nova
Code Issues Proposed changes

Update values in test_flagfile to be different.

Browse Source 
This will ensure the test is actually getting the correct values

Change-Id: I648488c0f573a4d402408cfaf66c1f144c116e1d
This commit is contained in:
Alex Meade 2012-03-09 17:07:37 +00:00
parent 0c3c67e085
commit 1c68d20e4b
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
nova/tests/test_flags.py
View File

@ -114,7 +114,7 @@ class FlagsTestCase(test.TestCase):
try: try:
os.write(fd, '--string=foo\n--int=2\n--false\n--notrue\n') os.write(fd, '--string=foo\n--int=2\n--false\n--notrue\n')
os.write(fd, '--multi=foo\n') # FIXME(markmc): --multi=bar\n') os.write(fd, '--multi=bar\n')
os.close(fd) os.close(fd)
self.FLAGS(['flags_test', '--flagfile=' + path]) self.FLAGS(['flags_test', '--flagfile=' + path])
@ -123,11 +123,11 @@ class FlagsTestCase(test.TestCase):
self.assertEqual(self.FLAGS.int, 2) self.assertEqual(self.FLAGS.int, 2)
self.assertEqual(self.FLAGS.false, True) self.assertEqual(self.FLAGS.false, True)
self.assertEqual(self.FLAGS.true, False) self.assertEqual(self.FLAGS.true, False)
self.assertEqual(self.FLAGS.multi, ['foo']) # FIXME(markmc): 'bar' self.assertEqual(self.FLAGS.multi, ['bar'])
# Re-parse to test multistring isn't append multiple times # Re-parse to test multistring isn't append multiple times
self.FLAGS(['flags_test', '--flagfile=' + path]) self.FLAGS(['flags_test', '--flagfile=' + path])
self.assertEqual(self.FLAGS.multi, ['foo']) # FIXME(markmc): 'bar' self.assertEqual(self.FLAGS.multi, ['bar'])
finally: finally:
os.remove(path) os.remove(path)