openstack/nova
Code Issues Proposed changes

Remove Unicode characters

Browse Source 
Change-Id: I1b01b42efceb5430b3eda54531eb843c0c73ab68
This commit is contained in:
Pierre Riteau
2025-06-13 23:53:55 +02:00
parent d75507e679
commit 1efbbc8d5f
4 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
nova/conf/scheduler.py
View File

@ -609,14 +609,14 @@ As an example, let's consider the case where this option is set to:
``os_distro=1, hw_machine_type=-1``
If an instance would boot with an image having ``os_distro=windows`` and
If an instance would boot with an image having ``os_distro=windows`` and
``hw_machine_type=q35``, the final host weight will be:
``(nb_inst(``os_distro=windows``) * 1.0) +
(nb_inst(``hw_machine_type=q35``) * -1)``
where nb_inst(``prop=value``) would give me the number of instances having
an image where ``prop`` is set to ``value`` (eg. the number of instances
an image where ``prop`` is set to ``value`` (eg. the number of instances
running with ``os_distro=windows``)
Possible values:

10
nova/pci/stats.py
View File

@ -637,16 +637,16 @@ class PciDeviceStats(object):
# If it is not set, we skip the next code block and no filtering
# is applied to the pools.
if all(spec.get("live_migratable") == 'true' for spec in request.spec):
#  if all specs require live migratable devices, then we need to
#  reduce the pools by the ones that support them.
# if all specs require live migratable devices, then we need to
# reduce the pools by the ones that support them.
pools = [pool for pool in pools if pool.get("live_migratable") and
pool['live_migratable'] == 'true']
elif all(
spec.get("live_migratable") == "false" for spec in request.spec
):
#  If the request asks to NOT support live-migratable devices, then
#  we don't provide the ones that support them.
#  We want to exclude the devices that don't have this value yet.
# If the request asks to NOT support live-migratable devices, then
# we don't provide the ones that support them.
# We want to exclude the devices that don't have this value yet.
pools = [pool for pool in pools if pool.get("live_migratable") and
pool['live_migratable'] == 'false']
return pools

8
nova/tests/functional/libvirt/test_pci_sriov_servers.py
View File

@ -1567,8 +1567,8 @@ class SRIOVServersTest(_PCIServersWithMigrationTestBase):
# alias hostdev2 --> src_dev: 3 --> dst_dev: 2
# In such situations, we use the _assertDeviceAddressesPresent()
# method, which only verifies that a similar device — for
# example, one with slot 0x82 — exists in the destination XML,
# method, which only verifies that a similar device - for
# example, one with slot 0x82 - exists in the destination XML,
# regardless of order.
self._assertDeviceAddressesPresent(src_xml, dst_xml)
@ -2204,8 +2204,8 @@ class SRIOVServersTest(_PCIServersWithMigrationTestBase):
# alias hostdev2 --> src_dev: 3 --> dst_dev: 2
# In such situations, we use the _assertDeviceAddressesPresent()
# method, which only verifies that a similar device — for
# example, one with slot 0x82 — exists in the destination XML,
# method, which only verifies that a similar device - for
# example, one with slot 0x82 - exists in the destination XML,
# regardless of order.
self._assertDeviceAddressesPresent(src_xml, dst_xml)

2
nova/tests/unit/scheduler/weights/test_weights_image_props.py
View File

@ -73,7 +73,7 @@ class ImagePropertiesWeigherTestCase(test.NoDBTestCase):
host_values = [
# host1 has no instances
('host1', 'node1', {'instances': {}}),
#  host2 has one instance with os_distro=win and hw_machine_type=pc
# host2 has one instance with os_distro=win and hw_machine_type=pc
('host2', 'node2', {'instances': {uuids.inst1: objects.Instance(
uuid=uuids.inst1)}}),
# host3 has two instances