From 9ec6afe8939d6f3d72317b1cc8e0f4273bf31e43 Mon Sep 17 00:00:00 2001
From: melanie witt <melwittt@gmail.com>
Date: Thu, 6 May 2021 00:46:17 +0000
Subject: [PATCH] Enable unified limits in the nova-next job

This configures the nova-next job to enable the new experimental
unified limits functionality.

This also adds basic testing for nova "global" limits in keystone in
the post-test-hook for the nova-next job. These can't be tested in
tempest because they involve modifying global quota limits that would
affect any other server tests running in parallel.

Related to blueprint unified-limits-nova

Depends-On: https://review.opendev.org/c/openstack/devstack/+/789962
Depends-On: https://review.opendev.org/c/openstack/tempest/+/790186
Depends-On: https://review.opendev.org/c/openstack/tempest/+/804311

Change-Id: I624b2684867305a9095e8964ead786c7b0c28242
---
 .zuul.yaml             |  3 ++
 gate/post_test_hook.sh | 67 ++++++++++++++++++++++++++++++++++++++++--
 2 files changed, 67 insertions(+), 3 deletions(-)

diff --git a/.zuul.yaml b/.zuul.yaml
index ae545a4e78c5..928cca4f63b1 100644
--- a/.zuul.yaml
+++ b/.zuul.yaml
@@ -339,6 +339,8 @@
             compute-feature-enabled:
               # The q35 machine type doesn't support an IDE bus
               ide_bus: False
+              # Added in Yoga.
+              unified_limits: True
             neutron_plugin_options:
               available_type_drivers: flat,geneve,vlan,gre,local,vxlan
       devstack_localrc:
@@ -355,6 +357,7 @@
         FORCE_CONFIG_DRIVE: True
         # Added in Yoga.
         NOVNC_FROM_PACKAGE: False
+        NOVA_USE_UNIFIED_LIMITS: True
       devstack_services:
         # Disable OVN services
         br-ex-tcpdump: false
diff --git a/gate/post_test_hook.sh b/gate/post_test_hook.sh
index 28ad9b939ea4..b788746cef93 100755
--- a/gate/post_test_hook.sh
+++ b/gate/post_test_hook.sh
@@ -59,9 +59,7 @@ set -e
 purge_db
 
 # We need to get the admin credentials to run the OSC CLIs for Placement.
-set +x
-source $BASE/devstack/openrc admin
-set -x
+export OS_CLOUD=devstack-admin
 
 # Verify whether instances were archived from all cells. Admin credentials are
 # needed to list deleted instances across all projects.
@@ -271,3 +269,66 @@ set -e
 # Verify whether online data migrations run after archiving will succeed.
 # See for more details: https://bugs.launchpad.net/nova/+bug/1824435
 $MANAGE db online_data_migrations
+
+
+# Test global registered unified limits by updating registered limits and
+# attempting to create resources. Because these quota limits are global, we
+# can't test them in tempest because modifying global limits can cause other
+# tests running in parallel to fail.
+echo "Testing unified limits registered limits"
+
+# Get the registered limits IDs.
+reglimit_ids_names=$(openstack registered limit list -f value -c "ID" -c "Resource Name")
+
+# Put them in a map to lookup ID from name for subsequent limit set commands.
+# Requires Bash 4.
+declare -A id_name_map
+while read id name
+    do id_name_map["$name"]="$id"
+done <<< "$reglimit_ids_names"
+
+# Server metadata items
+#
+# Set the quota to 1.
+metadata_items_id="${id_name_map["server_metadata_items"]}"
+
+bash -c "unset OS_USERNAME OS_TENANT_NAME OS_PROJECT_NAME;
+    openstack --os-cloud devstack-system-admin registered limit set \
+        --default-limit 1 $metadata_items_id"
+
+# Create a server. Should succeed with one metadata item.
+openstack --os-compute-api-version 2.37 \
+    server create --image ${image_id} --flavor ${flavor_id} --nic none \
+    --property cool=true --wait metadata-items-test1
+
+# Try to create another server with two metadata items. This should fail.
+set +e
+output=$(openstack --os-compute-api-version 2.37 \
+    server create --image ${image_id} --flavor ${flavor_id} --nic none \
+    --property cool=true --property location=fridge \
+    --wait metadata-items-test2)
+rc=$?
+set -e
+# Return code should be 1 if server create failed.
+if [[ ${rc} -ne 1 ]]; then
+    echo "Expected return code 1 from server create with two metadata items"
+    exit 2
+fi
+# Verify it's a quota error.
+if [[ ! "HTTP 403" =~ "$output" ]]; then
+    echo "Expected HTTP 403 from server create with two metadata items"
+    exit 2
+fi
+
+# Increase the quota limit to two.
+bash -c "unset OS_USERNAME OS_TENANT_NAME OS_PROJECT_NAME;
+    openstack --os-cloud devstack-system-admin registered limit set \
+        --default-limit 2 $metadata_items_id"
+
+# Second server create should succeed now.
+openstack --os-compute-api-version 2.37 \
+    server create --image ${image_id} --flavor ${flavor_id} --nic none \
+    --property cool=true --property location=fridge --wait metadata-items-test2
+
+# Delete the servers.
+openstack server delete metadata-items-test1 metadata-items-test2