openstack/nova
Code Issues Proposed changes

Fix docs for confirmResize action

Browse Source 
The docs had three things wrong:

1. The server status would be VERIFY_RESIZE, not VERIFY_RESIZED.

2. The RESIZED value is on the OS-EXT-STS:vm_state field, not
   vm_status.

3. The migration record status must be "finished", which is what
   gets set on the migration record in the _finish_resize() method
   in ComputeManager and used in the comptue API.confirm_resize()
   method. "confirming" status is what the API sets the migration
   record to before casting to nova-compute to finish the
   confirmation.

Stepping back, this is too many conditionals for what is really
needed. So rather than fix all three items individually, this
change simply fixes the first one and removes the other two since
the 'status' is based on the 'vm_state' internally, and a non-admin
user cannot list migrations anyway, and the _finish_resize()
method sets the migration status *before* the vm_state.

Closes-Bug: #1764878

Change-Id: Ib751686880ee824cf0693a649f47c828f515b471
This commit is contained in:
Matt Riedemann
2018-04-17 17:55:41 -04:00
parent f106094e96
commit 203572a8ae
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
api-ref/source/servers-actions.inc
View File

@@ -170,8 +170,7 @@ server in the compute node that OpenStack Compute manages.
**Preconditions**
You can only confirm the resized server where the status is
``VERIFY_RESIZED``, the vm_status is ``RESIZED``, and the
migration_status is ``finished`` or ``confirming``.
``VERIFY_RESIZE``.
If the server is locked, you must have administrator privileges
to confirm the server.