openstack/nova
Code Issues Proposed changes

Properly log BlockDeviceMappingList in _create_block_device_mapping

Browse Source 
The block_device_mapping list parameter is a BlockDeviceMappingList
object, and list objects don't repr the sub-objects so it's useless
information in the logs. Cast to a list to get the sub-objects repr'ed
in the logs.

The bdm list of dicts from the API request is converted to a
BlockDeviceMappingList in _check_and_transform_bdm which is called from
_create_instance before _create_block_device_mapping.

Closes-Bug: #1513934

Change-Id: Id709c0bc9d0ad980d0b36973f3a52034003170af
This commit is contained in:
Matt Riedemann 2015-11-06 12:00:18 -08:00
parent 74509a7dc7
commit 206b1413e4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
nova/compute/api.py
View File

@ -1269,7 +1269,7 @@ class API(base.Base):
This method makes a copy of the list in order to avoid using the same This method makes a copy of the list in order to avoid using the same
id field in case this is called for multiple instances. id field in case this is called for multiple instances.
""" """
LOG.debug("block_device_mapping %s", block_device_mapping, LOG.debug("block_device_mapping %s", list(block_device_mapping),
instance_uuid=instance_uuid) instance_uuid=instance_uuid)
instance_block_device_mapping = copy.deepcopy(block_device_mapping) instance_block_device_mapping = copy.deepcopy(block_device_mapping)
for bdm in instance_block_device_mapping: for bdm in instance_block_device_mapping: