openstack
/
nova
Code Issues Proposed changes

libvirt: add tests to check multipath in iscsi/fc volume connectors 

This adds checks to the iscsi/fibrechannel volume driver connector
tests to make sure that the resulting connector has a use_multipath
value based on the libvirt.volume_use_multipath config option nova
passes to os-brick.

Change-Id: I82b303a405b8a2d51c2e659edf285fa1d1f3a73b
Related-Bug: #1723928
This commit is contained in:
Matt Riedemann 2018-01-09 12:43:34 -05:00
parent c315a97923
commit 2324146d85
2 changed files with 17 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
nova/tests/unit/virt/libvirt/volume/test_fibrechannel.py
View File

@ -24,10 +24,15 @@ class LibvirtFibreChannelVolumeDriverTestCase(
test_volume.LibvirtVolumeBaseTestCase):
def test_libvirt_fibrechan_driver(self):
libvirt_driver = fibrechannel.LibvirtFibreChannelVolumeDriver(
self.fake_host)
self.assertIsInstance(libvirt_driver.connector,
connector.FibreChannelConnector)
for multipath in (True, False):
self.flags(volume_use_multipath=multipath, group='libvirt')
libvirt_driver = fibrechannel.LibvirtFibreChannelVolumeDriver(
self.fake_host)
self.assertIsInstance(libvirt_driver.connector,
connector.FibreChannelConnector)
if hasattr(libvirt_driver.connector, 'use_multipath'):
self.assertEqual(
multipath, libvirt_driver.connector.use_multipath)
def _test_libvirt_fibrechan_driver_s390(self):
libvirt_driver = fibrechannel.LibvirtFibreChannelVolumeDriver(

11
nova/tests/unit/virt/libvirt/volume/test_iscsi.py
View File

@ -22,9 +22,14 @@ class LibvirtISCSIVolumeDriverTestCase(
test_volume.LibvirtISCSIVolumeBaseTestCase):
def test_libvirt_iscsi_driver(self, transport=None):
libvirt_driver = iscsi.LibvirtISCSIVolumeDriver(self.fake_host)
self.assertIsInstance(libvirt_driver.connector,
connector.ISCSIConnector)
for multipath in (True, False):
self.flags(volume_use_multipath=multipath, group='libvirt')
libvirt_driver = iscsi.LibvirtISCSIVolumeDriver(self.fake_host)
self.assertIsInstance(libvirt_driver.connector,
connector.ISCSIConnector)
if hasattr(libvirt_driver.connector, 'use_multipath'):
self.assertEqual(
multipath, libvirt_driver.connector.use_multipath)
def test_libvirt_iscsi_driver_get_config(self):
libvirt_driver = iscsi.LibvirtISCSIVolumeDriver(self.fake_host)