openstack
/
nova
Code Issues Proposed changes

Add TODO note for mox removal 

MoxStubout fixture in nova/test.py and
filtering warnings in nova/tests/fixtures.py
will be removed after removing unit tests
related to nova-network.
So add notes for them.

Change-Id: I20e51647e66467ebedde01e914484cd02fea6ef3
Implements: blueprint mox-removal-ussuri
This commit is contained in:
Takashi NATSUME 2018-06-20 15:46:35 +09:00
parent 36b582a55a
commit 2565cd841d
2 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
nova/test.py
View File

@ -303,6 +303,14 @@ class TestCase(testtools.TestCase):
# Reset the compute RPC API globals (mostly the _ROUTER).
compute_rpcapi.reset_globals()
# TODO(takashin): Remove MoxStubout fixture
# after removing tests which uses mox and are related to
# nova-network in the following files.
#
# - nova/tests/unit/api/openstack/compute/test_floating_ips.py
# - nova/tests/unit/api/openstack/compute/test_security_groups.py
# - nova/tests/unit/fake_network.py
# - nova/tests/unit/network/test_manager.py
mox_fixture = self.useFixture(moxstubout.MoxStubout())
self.mox = mox_fixture.mox
self.stubs = mox_fixture.stubs

10
nova/tests/fixtures.py
View File

@ -839,8 +839,14 @@ class WarningsFixture(fixtures.Fixture):
message='Policy enforcement is depending on the value of is_admin.'
' This key is deprecated. Please update your policy '
'file to use the standard policy values.')
# NOTE(sdague): mox3 is on life support, don't really care
# about any deprecations coming from it
# TODO(takashin): Remove filtering warnings about mox
# after removing tests which uses mox and are related to
# nova-network in the following files.
#
# - nova/tests/unit/api/openstack/compute/test_floating_ips.py
# - nova/tests/unit/api/openstack/compute/test_security_groups.py
# - nova/tests/unit/fake_network.py
# - nova/tests/unit/network/test_manager.py
warnings.filterwarnings('ignore',
module='mox3.mox')
# NOTE(gibi): we can remove this once we get rid of Mox in nova