openstack/nova
Code Issues Proposed changes

Add 'not in' test to tools/hacking.py

Browse Source 
N901: Use the 'not in' operator for collection membership evaluation

Change-Id: Ie156359d85dd089d68eb214f1569f27577800e17
This commit is contained in:
Joe Gordon 2013-01-31 15:07:54 -08:00
parent c2e4630f08
commit 2cd4687683
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
tools/hacking.py
View File

@ -43,6 +43,7 @@ logging.disable('LOG')
#N6xx calling methods
#N7xx localization
#N8xx git commit messages
#N9xx other
IMPORT_EXCEPTIONS = ['sqlalchemy', 'migrate', 'nova.db.sqlalchemy.session']
START_DOCSTRING_TRIPLE = ['u"""', 'r"""', '"""', "u'''", "r'''", "'''"]
@ -493,6 +494,23 @@ def nova_localization_strings(logical_line, tokens):
#TODO(jogo) Dict and list objects
def nova_not_in(logical_line):
r"""Check localization in line.
Okay: if x not in y
Okay: if not (X in Y or X is Z)
Okay: if not (X in Y)
N901: if not X in Y
N901: if not X.B in Y
"""
split_line = logical_line.split()
if (len(split_line) == 5 and split_line[0] == 'if' and
split_line[1] == 'not' and split_line[3] == 'in' and not
split_line[2].startswith('(')):
yield (logical_line.find('not'), "N901: Use the 'not in' "
"operator for collection membership evaluation")
current_file = ""