From 31889ce296d1e1a62fe5825292479009118ddfab Mon Sep 17 00:00:00 2001
From: Stephen Finucane <stephenfin@redhat.com>
Date: Wed, 24 Feb 2021 11:38:24 +0000
Subject: [PATCH] libvirt: Add tests for insecure UEFI configuration

Follow-up to I342e95fef0a792299180a4d8076e6e7c4041ac9b

Blueprint: allow-secure-boot-for-qemu-kvm-guests
Change-Id: I1079e7457456c495465a8de9ca055bbf259a582d
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
---
 nova/tests/unit/virt/libvirt/test_config.py | 29 ++++++++++++++++++---
 1 file changed, 25 insertions(+), 4 deletions(-)

diff --git a/nova/tests/unit/virt/libvirt/test_config.py b/nova/tests/unit/virt/libvirt/test_config.py
index 8654bc5737e6..7a21e908cbda 100644
--- a/nova/tests/unit/virt/libvirt/test_config.py
+++ b/nova/tests/unit/virt/libvirt/test_config.py
@@ -2473,7 +2473,7 @@ class LibvirtConfigGuestTest(LibvirtConfigBaseTest):
             </domain>""",  # noqa: E501
         )
 
-    def test_config_uefi_autoconfigure(self):
+    def _test_config_uefi_autoconfigure(self, secure):
         obj = config.LibvirtConfigGuest()
         obj.virt_type = "kvm"
         obj.memory = 100 * units.Mi
@@ -2483,8 +2483,11 @@ class LibvirtConfigGuestTest(LibvirtConfigBaseTest):
         obj.os_type = "hvm"
         obj.os_firmware = "efi"
         obj.os_mach_type = "pc-q35-5.1"
-        obj.os_loader_secure = True
-        xml = obj.to_xml()
+        obj.os_loader_secure = secure
+        return obj.to_xml()
+
+    def test_config_uefi_autoconfigure(self):
+        xml = self._test_config_uefi_autoconfigure(secure=False)
 
         self.assertXmlEqual(
             xml,
@@ -2496,7 +2499,25 @@ class LibvirtConfigGuestTest(LibvirtConfigBaseTest):
               <vcpu>1</vcpu>
               <os firmware="efi">
                 <type machine="pc-q35-5.1">hvm</type>
-                <loader secure='yes'/>
+                <loader secure="no"/>
+              </os>
+            </domain>""",
+        )
+
+    def test_config_uefi_autoconfigure_secure(self):
+        xml = self._test_config_uefi_autoconfigure(secure=True)
+
+        self.assertXmlEqual(
+            xml,
+            """
+            <domain type="kvm">
+              <uuid>f01cf68d-515c-4daf-b85f-ef1424d93bfc</uuid>
+              <name>uefi</name>
+              <memory>104857600</memory>
+              <vcpu>1</vcpu>
+              <os firmware="efi">
+                <type machine="pc-q35-5.1">hvm</type>
+                <loader secure="yes"/>
               </os>
             </domain>""",
         )