openstack
/
nova
Code Issues Proposed changes

Merge "libvirt: log vm and task state when vif plugging times out"

This commit is contained in:
Jenkins 2017-06-12 07:40:52 +00:00 committed by Gerrit Code Review
parent d147277b8f 82ecd93a20
commit 3712780cb3
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
nova/tests/unit/virt/libvirt/test_driver.py
View File

@ -14387,7 +14387,8 @@ class LibvirtConnTestCase(test.NoDBTestCase,
prepare.side_effect = fake_prepare
drvr = libvirt_driver.LibvirtDriver(virtapi, False)
instance = objects.Instance(**self.test_instance)
instance = objects.Instance(vm_state=vm_states.BUILDING,
**self.test_instance)
vifs = [{'id': 'vif1', 'active': False},
{'id': 'vif2', 'active': False}]

9
nova/virt/libvirt/driver.py
View File

@ -5167,9 +5167,12 @@ class LibvirtDriver(driver.ComputeDriver):
destroy_disks_on_failure)
except eventlet.timeout.Timeout:
# We never heard from Neutron
LOG.warning(_LW('Timeout waiting for vif plugging callback for '
'instance %(uuid)s'), {'uuid': instance.uuid},
instance=instance)
LOG.warning('Timeout waiting for vif plugging callback for '
'instance with vm_state %(vm_state)s and '
'task_state %(task_state)s.',
{'vm_state': instance.vm_state,
'task_state': instance.task_state},
instance=instance)
if CONF.vif_plugging_is_fatal:
self._cleanup_failed_start(context, instance, network_info,
block_device_info, guest,