openstack/nova
Code Issues Proposed changes

Ensure 'subunit2pyunit' is run in venv from run_tests.sh

Browse Source 
The run_tests.sh script invokes

  bash -c "${wrapper} $TESTRTESTS | subunit2pyunit"

where '${wrapper}' expands to 'tools/with_venv.sh'. Due to shell
precedence rules, this only applies to '$TESTRTESTS' not the
'subunit2pyunit' part of the command. The 'subunit2pyunit' binary
though may only be available from the .venv

Change-Id: I5972c8f77b3f50a3713881e6ca1acbaeabbd47d4
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrange
2013-02-11 15:58:47 +00:00
parent f262c435f4
commit 3e4637e8e7
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
run_tests.sh
View File

@@ -93,7 +93,7 @@ function run_tests {
testrargs=`echo "$testrargs" | sed -e's/^\s*\(.*\)\s*$/\1/'` testrargs=`echo "$testrargs" | sed -e's/^\s*\(.*\)\s*$/\1/'`
TESTRTESTS="$TESTRTESTS --testr-args='--subunit $testropts $testrargs'" TESTRTESTS="$TESTRTESTS --testr-args='--subunit $testropts $testrargs'"
echo "Running \`${wrapper} $TESTRTESTS\`" echo "Running \`${wrapper} $TESTRTESTS\`"
bash -c "${wrapper} $TESTRTESTS | subunit2pyunit" bash -c "${wrapper} $TESTRTESTS | ${wrapper} subunit2pyunit"
RESULT=$? RESULT=$?
set -e set -e