From 3fab43786bbdc01087004b973bb0912505150864 Mon Sep 17 00:00:00 2001 From: Sylvain Bauza Date: Mon, 5 Jun 2023 18:22:09 +0200 Subject: [PATCH] cpu: fix the privsep issue when offlining the cpu In Icb913ed9be8d508de35e755a9c650ba25e45aca2 we forgot to add a privsep decorator for the set_offline() method. Change-Id: I769d35907ab9466fe65b942295fd7567a757087a Closes-Bug: #2022955 --- nova/virt/libvirt/cpu/core.py | 1 + releasenotes/notes/bug-2022955-eac8b0c8e42e3696.yaml | 7 +++++++ 2 files changed, 8 insertions(+) create mode 100644 releasenotes/notes/bug-2022955-eac8b0c8e42e3696.yaml diff --git a/nova/virt/libvirt/cpu/core.py b/nova/virt/libvirt/cpu/core.py index 782f028fee3c..8274236850cc 100644 --- a/nova/virt/libvirt/cpu/core.py +++ b/nova/virt/libvirt/cpu/core.py @@ -60,6 +60,7 @@ def set_online(core: int) -> bool: return get_online(core) +@nova.privsep.sys_admin_pctxt.entrypoint def set_offline(core: int) -> bool: filesystem.write_sys(os.path.join(gen_cpu_path(core), 'online'), data='0') return not get_online(core) diff --git a/releasenotes/notes/bug-2022955-eac8b0c8e42e3696.yaml b/releasenotes/notes/bug-2022955-eac8b0c8e42e3696.yaml new file mode 100644 index 000000000000..35d8514a3c3f --- /dev/null +++ b/releasenotes/notes/bug-2022955-eac8b0c8e42e3696.yaml @@ -0,0 +1,7 @@ +--- +fixes: + - | + The `CPU power management`_ feature has been fixed to use privsep to avoid + a FileNotFound error when offlining CPUs. + + .. _CPU power management: https://docs.openstack.org/nova/latest/admin/cpu-topologies.html#configuring-cpu-power-management-for-dedicated-cores