From 436e525a970bb991e147a0b4c3ce389a815252c2 Mon Sep 17 00:00:00 2001 From: songjie Date: Mon, 25 Dec 2023 16:59:36 +0800 Subject: [PATCH] libvirt: stop enabling hyperv feature reenlightenment MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The 'reenlightenment' hyperv enlightenment will cause instances live-migration to fail (KVM currently doesn’t fully support reenlightenment notifications, see www.qemu.org/docs/master/system/i386/hyperv.html), so don't enable it now. Change-Id: I6821819450bc96e4304125ea3b76a0e462e6e33f Closes-Bug: #2046549 Related-Bug: #2009280 (cherry picked from commit e618e78edc6293d248a5fa2eb63b3fa636250fca) --- nova/tests/unit/virt/libvirt/test_driver.py | 4 +++- nova/virt/libvirt/driver.py | 1 - 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/nova/tests/unit/virt/libvirt/test_driver.py b/nova/tests/unit/virt/libvirt/test_driver.py index a28df59ecbdb..b5405211fc7f 100644 --- a/nova/tests/unit/virt/libvirt/test_driver.py +++ b/nova/tests/unit/virt/libvirt/test_driver.py @@ -27934,7 +27934,9 @@ class LibvirtDriverTestCase(test.NoDBTestCase, TraitsComparisonMixin): self.assertTrue(hv.synic) self.assertTrue(hv.reset) self.assertTrue(hv.frequencies) - self.assertTrue(hv.reenlightenment) + # NOTE(jie) reenlightenment will cause instances live-migration + # failure, so don't enable it now. See bug 2046549. + self.assertFalse(hv.reenlightenment) self.assertTrue(hv.tlbflush) self.assertTrue(hv.ipi) self.assertTrue(hv.evmcs) diff --git a/nova/virt/libvirt/driver.py b/nova/virt/libvirt/driver.py index 804aef22b4d1..6d97808c96e8 100644 --- a/nova/virt/libvirt/driver.py +++ b/nova/virt/libvirt/driver.py @@ -6227,7 +6227,6 @@ class LibvirtDriver(driver.ComputeDriver): hv.synic = True hv.reset = True hv.frequencies = True - hv.reenlightenment = True hv.tlbflush = True hv.ipi = True hv.evmcs = True