From 453c11e05d10db01805363dfe68138d9f4d03043 Mon Sep 17 00:00:00 2001 From: melanie witt Date: Thu, 24 Feb 2022 19:45:42 +0000 Subject: [PATCH] Follow up for nova-manage image property commands This a follow up for change Ic8783053778cf4614742186e94059d5675121db1 and corrects the 'image_property set --property' arg format in the hw_machine_type doc. Newline formats in the nova-manage CLI doc is cleaned up to be consistent throughout and unnecessary () is removed from the ImagePropertyCommands class. Related to blueprint libvirt-device-bus-model-update Change-Id: I5b67e9ae5125f6dad68cae7ac0601ac5b02e74b3 --- doc/source/admin/hw-machine-type.rst | 3 ++- doc/source/cli/nova-manage.rst | 6 ++++++ nova/cmd/manage.py | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/doc/source/admin/hw-machine-type.rst b/doc/source/admin/hw-machine-type.rst index abbed019701c..7b6af4e410ee 100644 --- a/doc/source/admin/hw-machine-type.rst +++ b/doc/source/admin/hw-machine-type.rst @@ -165,4 +165,5 @@ To update the stored image properties of an instance: .. code-block:: shell - $ nova-manage image_property set $instance_uuid --property $property + $ nova-manage image_property set \ + $instance_uuid --property $property_name=$property_value diff --git a/doc/source/cli/nova-manage.rst b/doc/source/cli/nova-manage.rst index 9d58e7ebf51b..8aacf965b4c7 100644 --- a/doc/source/cli/nova-manage.rst +++ b/doc/source/cli/nova-manage.rst @@ -521,6 +521,7 @@ This command should be run before ``nova-manage db sync``. .. _man-page-cells-v2: + Cells v2 Commands ================= @@ -1144,6 +1145,7 @@ Delete a host by the given host name and the given cell UUID. * - 4 - The host with the specified name has instances (host not empty). + Placement Commands ================== @@ -1531,6 +1533,7 @@ command. * - 6 - Instance is not attached to volume + Libvirt Commands ================ @@ -1668,6 +1671,7 @@ within an environment. * - 3 - Instances found without ``hw_machine_type`` set + Image Property Commands ======================= @@ -1754,12 +1758,14 @@ for example. * - 5 - The provided image property value is invalid + See Also ======== :doc:`nova-policy(1) `, :doc:`nova-status(1) ` + Bugs ==== diff --git a/nova/cmd/manage.py b/nova/cmd/manage.py index f704a42698e0..5ee30ccff53c 100644 --- a/nova/cmd/manage.py +++ b/nova/cmd/manage.py @@ -3192,7 +3192,7 @@ class VolumeAttachmentCommands(object): return 1 -class ImagePropertyCommands(): +class ImagePropertyCommands: @action_description(_("Show the value of an instance image property.")) @args(