openstack/nova
Code Issues Proposed changes

Add a 50 char git title limit test to hacking.

Browse Source 
* add N802 to hacking.py

Change-Id: I8262531b4b3f8f3a1a2a37679904cf4864cae7b6
This commit is contained in:
Joe Gordon 2012-08-02 14:36:58 -07:00
parent 28a03d9ade
commit 47a1bbe311
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
HACKING.rst
View File

@ -219,7 +219,8 @@ Commit Messages
Using a common format for commit messages will help keep our git history Using a common format for commit messages will help keep our git history
readable. Follow these guidelines: readable. Follow these guidelines:
First, provide a brief summary (limited to 50 chars). First, provide a brief summary (it is recommended to keep the commit title
under 50 chars).
The first line of the commit message should provide an accurate The first line of the commit message should provide an accurate
description of the change, not just a reference to a bug or description of the change, not just a reference to a bug or

4
tools/hacking.py
View File

@ -431,6 +431,7 @@ def once_git_check_commit_title():
nova HACKING recommends not referencing a bug or blueprint in first line, nova HACKING recommends not referencing a bug or blueprint in first line,
it should provide an accurate description of the change it should provide an accurate description of the change
N801 N801
N802 Title limited to 50 chars
""" """
#Get title of most recent commit #Get title of most recent commit
@ -453,6 +454,9 @@ def once_git_check_commit_title():
print ("N801: git commit title ('%s') should provide an accurate " print ("N801: git commit title ('%s') should provide an accurate "
"description of the change, not just a reference to a bug " "description of the change, not just a reference to a bug "
"or blueprint" % title.strip()) "or blueprint" % title.strip())
if len(title.decode('utf-8')) > 72:
print ("N802: git commit title ('%s') should be under 50 chars"
% title.strip())
if __name__ == "__main__": if __name__ == "__main__":
#include nova path #include nova path