openstack/nova
Code Issues Proposed changes

Remove DictCompat from DNSDomain

Browse Source 
This changes over all occurrences of dictionary syntax on the DNSDomain
object to use object syntax.

Change-Id: Ice2c55650645346e0593bd6ba204ca64b60b82d4
Partially-Implements: bp rm-object-dict-compat
This commit is contained in:
Ryan Rossiter
2016-01-11 16:38:06 +00:00
parent f1da349a4f
commit 4b3b8f8c2e
2 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
nova/objects/dns_domain.py
View File

@@ -18,10 +18,8 @@ from nova.objects import base
from nova.objects import fields from nova.objects import fields
# TODO(berrange): Remove NovaObjectDictCompat
@base.NovaObjectRegistry.register @base.NovaObjectRegistry.register
class DNSDomain(base.NovaPersistentObject, base.NovaObject, class DNSDomain(base.NovaPersistentObject, base.NovaObject):
base.NovaObjectDictCompat):
# Version 1.0: Initial version # Version 1.0: Initial version
VERSION = '1.0' VERSION = '1.0'
@@ -35,7 +33,7 @@ class DNSDomain(base.NovaPersistentObject, base.NovaObject,
@staticmethod @staticmethod
def _from_db_object(context, vif, db_vif): def _from_db_object(context, vif, db_vif):
for field in vif.fields: for field in vif.fields:
vif[field] = db_vif[field] setattr(vif, field, db_vif[field])
vif._context = context vif._context = context
vif.obj_reset_changes() vif.obj_reset_changes()
return vif return vif

2
nova/tests/unit/objects/test_dns_domain.py
View File

@@ -35,7 +35,7 @@ class _TestDNSDomain(object):
@staticmethod @staticmethod
def _compare(test, db, obj): def _compare(test, db, obj):
for field, value in db.items(): for field, value in db.items():
test.assertEqual(db[field], obj[field]) test.assertEqual(db[field], getattr(obj, field))
def test_get_by_domain(self): def test_get_by_domain(self):
with mock.patch.object(db, 'dnsdomain_get') as get: with mock.patch.object(db, 'dnsdomain_get') as get: