openstack/nova
Code Issues Proposed changes

Skip network.test_manager.LdapDNSTestCase on Python 3

Browse Source 
ldapdns module is used for nova-network which was depecated, and
Python-ldap sometimes behaves poorly when receiving unicode strings,
so we can just skip tests if using Python3.

Partially-Implements: blueprint goal-python35

Change-Id: I9fa0b6b0d397318b52f0fe3784d6e7047aefaab2
This commit is contained in:
ChangBo Guo(gcb) 2016-12-20 10:49:58 +08:00
parent d0df4333a8
commit 4c05cb0913
2 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
nova/tests/unit/network/test_manager.py
View File

@ -3439,6 +3439,7 @@ domain1 = "example.org"
domain2 = "example.com"
@testtools.skipIf(six.PY3, 'python-ldap is not compatible for Python 3.')
class LdapDNSTestCase(test.NoDBTestCase):
"""Tests nova.network.ldapdns.LdapDNS."""
def setUp(self):

1
tests-py3.txt
View File

@ -10,7 +10,6 @@ nova.tests.unit.compute.test_compute.ComputeAPITestCase.test_create_with_base64_
nova.tests.unit.compute.test_compute_cells.CellsComputeAPITestCase.test_create_with_base64_user_data
nova.tests.unit.compute.test_compute_mgr.ComputeManagerUnitTestCase.test_run_pending_deletes
nova.tests.unit.compute.test_host_api.ComputeHostAPICellsTestCase
nova.tests.unit.network.test_manager.LdapDNSTestCase
nova.tests.unit.test_matchers.TestDictMatches.test__str__
nova.tests.unit.test_wsgi.TestWSGIServerWithSSL
nova.tests.unit.virt.libvirt.storage.test_rbd.RbdTestCase