openstack/nova
Code Issues Proposed changes

Fix semantics for migration test environment var

Browse Source 
Change-Id: I483f29d826fe1e1d1478e714524661aaf20c1cf3
This commit is contained in:
Mark Washenberger
2012-05-04 09:08:08 -04:00
parent 6dc62775d7
commit 4e20178783
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
nova/tests/test_migrations.py
+6 -5
View File
@@ -68,10 +68,11 @@ def _is_mysql_avail(user="openstack_citest",
return True
def _missing_mysql():
if "NOVA_TEST_MYSQL_PRESENT" in os.environ:
return True
return not _is_mysql_avail()
def _have_mysql():
present = os.environ.get('NOVA_TEST_MYSQL_PRESENT')
if present is None:
return _is_mysql_avail()
return present.lower() in ('', 'true')
class TestMigrations(test.TestCase):
@@ -215,7 +216,7 @@ class TestMigrations(test.TestCase):
if _is_mysql_avail(user="openstack_cifail"):
self.fail("Shouldn't have connected")
@test.skip_if(_missing_mysql(), "mysql not available")
@test.skip_unless(_have_mysql(), "mysql not available")
def test_mysql_innodb(self):
"""
Test that table creation on mysql only builds InnoDB tables