openstack/nova
Code Issues Proposed changes

Add a hacking rule for string interpolation at logging

Browse Source 
String interpolation should be delayed to be handled
by the logging code, rather than being done
at the point of the logging call.
So add the following hacking rule for it.

- [N354] String interpolation should be delayed at logging calls.

See the oslo i18n guideline.

* http://docs.openstack.org/developer/oslo.i18n/guidelines.html

Change-Id: Ief6d3ee3539c0857098fffdb7acfeec3e0fed6eb
Closes-Bug: #1596829
This commit is contained in:
Takashi NATSUME
2016-06-28 16:42:31 +09:00
parent 3d7ff766a7
commit 4eb89c206e
24 changed files with 134 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
HACKING.rst
View File

@@ -64,6 +64,7 @@ Nova Specific Commandments
- [N351] Do not use the oslo_policy.policy.Enforcer.enforce() method.
- [N352] LOG.warn is deprecated. Enforce use of LOG.warning.
- [N353] Validate that context objects is not passed in logging calls.
- [N354] String interpolation should be delayed at logging calls.
Creating Unit Tests
-------------------