openstack/nova
Code Issues Proposed changes

Remove duplicated negative factors in keypair test

Browse Source 
In test_keypair_create_fail_policy, there are two negative factors.
One is a policy violation, and another is a bad request body.
The purpose of the test is checking the policy violation, so a bad
request body is not right for this test.
This patch removes a bad request body from the test.

Change-Id: Ia165e08410b0576950efe83e5ab6a92c9c7f6a50
This commit is contained in:
Ken'ichi Ohmichi 2014-08-27 04:50:23 +00:00
parent 3ab81c9b3e
commit 509ed96c6f
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
nova/tests/api/openstack/compute/contrib/test_keypairs.py
View File

@ -373,6 +373,7 @@ class KeypairPolicyTest(test.TestCase):
self.assertIn('keypair', res)
def test_keypair_create_fail_policy(self):
body = {'keypair': {'name': 'create_test'}}
rules = {'compute_extension:keypairs:create':
common_policy.parse_rule('role:admin')}
policy.set_rules(rules)
@ -380,7 +381,7 @@ class KeypairPolicyTest(test.TestCase):
req.method = 'POST'
self.assertRaises(exception.Forbidden,
self.KeyPairController.create,
req, {})
req, body)
def test_keypair_create_pass_policy(self):
body = {'keypair': {'name': 'create_test'}}