openstack/nova
Code Issues Proposed changes

Adding hugepage and NUMA support check for aarch64

Browse Source 
Nova ignores aarch64 while verifying for hugepage and NUMA support.
AARCH64 also supports hugepage and NUMA on the same libvirt versions as of x86.
Hence adding this chek for aarch64 also.

Change-Id: I7b5ae1dbdca4fdd0aee2eefd4099c4c4953b609a
Closes-bug: #1623871
This commit is contained in:
VeenaSL 2016-09-19 13:36:53 +05:30 committed by Veena
parent 29e2c41092
commit 50e0106d35
3 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
nova/tests/unit/virt/libvirt/test_driver.py
View File

@ -2910,7 +2910,8 @@ class LibvirtConnTestCase(test.NoDBTestCase):
return_value=True)
@mock.patch.object(host.Host, "get_capabilities")
def test_does_want_hugepages(self, mock_caps, mock_hp, mock_numa):
for each_arch in [arch.I686, arch.X86_64, arch.PPC64LE, arch.PPC64]:
for each_arch in [arch.I686, arch.X86_64, arch.PPC64LE, arch.PPC64,
arch.AARCH64]:
self._test_does_want_hugepages(
mock_caps, mock_hp, mock_numa, each_arch)

6
nova/virt/libvirt/driver.py
View File

@ -5108,7 +5108,8 @@ class LibvirtDriver(driver.ComputeDriver):
self._bad_libvirt_numa_version_warn = True
return False
support_matrix = {(arch.I686, arch.X86_64): MIN_LIBVIRT_NUMA_VERSION,
support_matrix = {(arch.I686, arch.X86_64,
arch.AARCH64): MIN_LIBVIRT_NUMA_VERSION,
(arch.PPC64,
arch.PPC64LE): MIN_LIBVIRT_NUMA_VERSION_PPC}
caps = self._host.get_capabilities()
@ -5124,7 +5125,8 @@ class LibvirtDriver(driver.ComputeDriver):
def _has_hugepage_support(self):
# This means that the host can support multiple values for the size
# field in LibvirtConfigGuestMemoryBackingPage
supported_archs = [arch.I686, arch.X86_64, arch.PPC64LE, arch.PPC64]
supported_archs = [arch.I686, arch.X86_64, arch.PPC64LE, arch.PPC64,
arch.AARCH64]
caps = self._host.get_capabilities()
return ((caps.host.cpu.arch in supported_archs) and
self._host.has_min_version(MIN_LIBVIRT_HUGEPAGE_VERSION,

4
releasenotes/notes/add-numa-hugepage-support-for-aarch64-14279c307e44b147.yaml Normal file
View File

@ -0,0 +1,4 @@
---
features:
- Adding aarch64 to the list of supported architectures for NUMA and hugepage features.
This requires libvirt>=1.2.7 for NUMA, libvirt>=1.2.8 for hugepage and qemu v2.1.0 for both.