From 51345d57a1b726dad08445a5c5a47c4e640c2a43 Mon Sep 17 00:00:00 2001
From: Lee Yarwood <lyarwood@redhat.com>
Date: Mon, 30 Jul 2018 11:19:15 +0100
Subject: [PATCH] Add regression test for bug#1784353

Related-Bug: #1784353
Change-Id: I46511b5f3e3c850ba61add41e8ca053897618be6
(cherry picked from commit a8629e5800ed95c0e6bac04ca711e835606370bf)
(cherry picked from commit c013a276fffa612bf8742de502f698279f7ec54b)
---
 .../regressions/test_bug_1784353.py           | 88 +++++++++++++++++++
 1 file changed, 88 insertions(+)
 create mode 100644 nova/tests/functional/regressions/test_bug_1784353.py

diff --git a/nova/tests/functional/regressions/test_bug_1784353.py b/nova/tests/functional/regressions/test_bug_1784353.py
new file mode 100644
index 000000000000..16c4ce444e5d
--- /dev/null
+++ b/nova/tests/functional/regressions/test_bug_1784353.py
@@ -0,0 +1,88 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+from nova import test
+from nova.tests import fixtures as nova_fixtures
+from nova.tests.functional import integrated_helpers
+from nova.tests.unit import fake_network
+import nova.tests.unit.image.fake
+from nova.tests.unit import policy_fixture
+from nova.virt import fake
+
+
+class TestRescheduleWithVolumesAttached(
+        test.TestCase, integrated_helpers.InstanceHelperMixin):
+    """Regression test for bug 1784353 introduced in Queens.
+
+    This regression test asserts that volume backed instances fail to start
+    when rescheduled due to their volume attachments being deleted by cleanup
+    code within the compute layer after an initial failure to spawn.
+    """
+
+    def setUp(self):
+        super(TestRescheduleWithVolumesAttached, self).setUp()
+
+        # Use the new attach flow fixture for cinder
+        cinder_fixture = nova_fixtures.CinderFixtureNewAttachFlow(self)
+        self.cinder = self.useFixture(cinder_fixture)
+        self.useFixture(policy_fixture.RealPolicyFixture())
+        self.useFixture(nova_fixtures.NeutronFixture(self))
+
+        fake_network.set_stub_network_methods(self)
+
+        self.useFixture(nova_fixtures.PlacementFixture())
+
+        api_fixture = self.useFixture(nova_fixtures.OSAPIFixture(
+            api_version='v2.1'))
+        self.api = api_fixture.admin_api
+
+        nova.tests.unit.image.fake.stub_out_image_service(self)
+        self.addCleanup(nova.tests.unit.image.fake.FakeImageService_reset)
+
+        self.flags(compute_driver='fake.FakeRescheduleDriver')
+
+        self.start_service('conductor')
+        self.start_service('scheduler')
+
+        # Start two computes to allow the instance to be rescheduled
+        fake.set_nodes(['host1'])
+        self.addCleanup(fake.restore_nodes)
+        self.host1 = self.start_service('compute', host='host1')
+
+        fake.set_nodes(['host2'])
+        self.addCleanup(fake.restore_nodes)
+        self.host2 = self.start_service('compute', host='host2')
+
+        self.image_id = self.api.get_images()[0]['id']
+        self.flavor_id = self.api.get_flavors()[0]['id']
+
+    def test_reschedule_with_volume_attached(self):
+        # Boot a volume backed instance
+        volume_id = nova_fixtures.CinderFixture.IMAGE_BACKED_VOL
+        server_request = {
+            'name': 'server',
+            'flavorRef': self.flavor_id,
+            'block_device_mapping_v2': [{
+                'boot_index': 0,
+                'uuid': volume_id,
+                'source_type': 'volume',
+                'destination_type': 'volume'}],
+        }
+        server_response = self.api.post_server({'server': server_request})
+        server_id = server_response['id']
+
+        # FIXME(lyarwood): Assert that the instance ends up in an ERROR state
+        # with no attachments present in the fixture. The instance should be
+        # ACTIVE with a single attachment associated to the volume.
+        self._wait_for_state_change(self.api, server_response, 'ERROR')
+        self.assertNotIn(volume_id,
+                         self.cinder.volume_ids_for_instance(server_id))