From cc615d0957cf81ff05bbe377152edde538f6ac70 Mon Sep 17 00:00:00 2001 From: Sean Mooney Date: Thu, 13 Jun 2019 00:29:23 +0100 Subject: [PATCH] update comment on ignore_basepython_conflict the current comment implies that setting ignore_basepython_conflict simply silences the warning emitted if the base python version set in the gloabl [testenv] section conflicts with the automatic python version selected form the test env name .e.g. py27 this is not correct as the upstream documentation states setting ignore_basepython_conflict=true allow enforcing this rule that py37 implies python3.7 however when its is not set basepython from [testenv] override the implied version form the env name. https://tox.readthedocs.io/en/latest/config.html#conf-ignore_basepython_conflict This change updates the comment to reflect that. Change-Id: Ieab65a2a9c6309021d5ee91e56ac07889a9e9bc4 Related-Bug: #1832652 --- tox.ini | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tox.ini b/tox.ini index 65effb9b175a..04905a89e0cb 100644 --- a/tox.ini +++ b/tox.ini @@ -1,9 +1,9 @@ [tox] minversion = 3.1.1 envlist = py{27,36,37},functional,pep8 -# Automatic envs (pyXX) will use the python version appropriate to that -# env and ignore basepython inherited from [testenv]. That's what we -# want, and we don't need to be warned about it. +# Automatic envs (pyXX) will only use the python version appropriate to that +# env and ignore basepython inherited from [testenv] if we set +# ignore_basepython_conflict. ignore_basepython_conflict = True [testenv]