openstack/nova
Code Issues Proposed changes

Stop using mox in test_firewall

Browse Source 
This change replaces use of mox with mock
in virt/libvirt/test_firewall.py

Change-Id: Ic179274f8e71a41df991861c045f5d997b7a2bc4
Implements: blueprint remove-mox-newton
This commit is contained in:
Pushkar Umaranikar 2016-04-15 14:49:08 +00:00
parent 7243f122d6
commit 531b40160b
1 changed files with 22 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
nova/tests/unit/virt/libvirt/test_firewall.py
View File

@ -20,10 +20,8 @@ from xml.dom import minidom
from eventlet import greenthread from eventlet import greenthread
from lxml import etree from lxml import etree
import mock import mock
from mox3 import mox
from oslo_concurrency.fixture import lockutils as lock_fixture from oslo_concurrency.fixture import lockutils as lock_fixture
from nova.compute import utils as compute_utils
from nova import exception from nova import exception
from nova.network import linux_net from nova.network import linux_net
from nova import objects from nova import objects
@ -248,7 +246,7 @@ class IptablesFirewallTestCase(test.NoDBTestCase):
linux_net.iptables_manager.execute = fake_iptables_execute linux_net.iptables_manager.execute = fake_iptables_execute
self.stubs.Set(compute_utils, 'get_nw_info_for_instance', self.stub_out('nova.compute.utils.get_nw_info_for_instance',
lambda instance: network_model) lambda instance: network_model)
self.fw.prepare_instance_filter(instance_ref, network_model) self.fw.prepare_instance_filter(instance_ref, network_model)
@ -351,32 +349,32 @@ class IptablesFirewallTestCase(test.NoDBTestCase):
self.assertEqual(ipv6_network_rules, self.assertEqual(ipv6_network_rules,
ipv6_rules_per_addr * ipv6_addr_per_network * networks_count) ipv6_rules_per_addr * ipv6_addr_per_network * networks_count)
def test_do_refresh_security_group_rules(self): @mock.patch.object(firewall.IptablesFirewallDriver, 'instance_rules')
@mock.patch.object(firewall.IptablesFirewallDriver,
'add_filters_for_instance')
@mock.patch.object(linux_net.IptablesTable, 'has_chain')
def test_do_refresh_security_group_rules(self, mock_has_chain,
mock_add_filters, mock_instance_rules):
instance_ref = self._create_instance_ref() instance_ref = self._create_instance_ref()
self.mox.StubOutWithMock(self.fw,
'instance_rules')
self.mox.StubOutWithMock(self.fw,
'add_filters_for_instance',
use_mock_anything=True)
self.mox.StubOutWithMock(self.fw.iptables.ipv4['filter'],
'has_chain')
self.fw.instance_rules(instance_ref, mock_instance_rules.return_value = (None, None)
mox.IgnoreArg()).AndReturn((None, None)) mock_has_chain.return_value = True
self.fw.add_filters_for_instance(instance_ref, mox.IgnoreArg(),
mox.IgnoreArg(), mox.IgnoreArg())
self.fw.instance_rules(instance_ref,
mox.IgnoreArg()).AndReturn((None, None))
self.fw.iptables.ipv4['filter'].has_chain(mox.IgnoreArg()
).AndReturn(True)
self.fw.add_filters_for_instance(instance_ref, mox.IgnoreArg(),
mox.IgnoreArg(), mox.IgnoreArg())
self.mox.ReplayAll()
self.fw.prepare_instance_filter(instance_ref, mox.IgnoreArg()) self.fw.prepare_instance_filter(instance_ref, mock.ANY)
self.fw.instance_info[instance_ref['id']] = (instance_ref, None) self.fw.instance_info[instance_ref['id']] = (instance_ref, None)
self.fw.do_refresh_security_group_rules("fake") self.fw.do_refresh_security_group_rules("fake")
expected_rules_calls = [mock.call(instance_ref, None),
mock.call(instance_ref, None)]
expected_filter_calls = [mock.call(instance_ref, mock.ANY, mock.ANY,
mock.ANY),
mock.call(instance_ref, mock.ANY, mock.ANY,
mock.ANY)]
self.assertEqual(mock_instance_rules.mock_calls,
expected_rules_calls)
self.assertEqual(mock_add_filters.mock_calls, expected_filter_calls)
mock_has_chain.assert_called_once_with(mock.ANY)
def test_do_refresh_security_group_rules_instance_gone(self): def test_do_refresh_security_group_rules_instance_gone(self):
instance1 = objects.Instance(None, id=1, uuid='fake-uuid1') instance1 = objects.Instance(None, id=1, uuid='fake-uuid1')
instance2 = objects.Instance(None, id=2, uuid='fake-uuid2') instance2 = objects.Instance(None, id=2, uuid='fake-uuid2')