bug 968452
Update test-requires to use pep8>=1.0. Removed PEP8 warning suppression around 3-arg raises. Change-Id: Ib4ed42adc167aa1e8078619a36b409b76b9f5d73
This commit is contained in:
parent
93874bacf7
commit
549616d122
1
Authors
1
Authors
@ -25,6 +25,7 @@ Bilal Akhtar <bilalakhtar@ubuntu.com>
|
|||||||
Brad Hall <brad@nicira.com>
|
Brad Hall <brad@nicira.com>
|
||||||
Brad McConnell <bmcconne@rackspace.com>
|
Brad McConnell <bmcconne@rackspace.com>
|
||||||
Brendan Maguire <B_Maguire@Dell.com>
|
Brendan Maguire <B_Maguire@Dell.com>
|
||||||
|
Brian Elliott <brian.elliott@rackspace.com>
|
||||||
Brian Lamar <brian.lamar@rackspace.com>
|
Brian Lamar <brian.lamar@rackspace.com>
|
||||||
Brian Schott <bschott@isi.edu>
|
Brian Schott <bschott@isi.edu>
|
||||||
Brian Waldon <brian.waldon@rackspace.com>
|
Brian Waldon <brian.waldon@rackspace.com>
|
||||||
|
18
run_tests.sh
18
run_tests.sh
@ -112,27 +112,13 @@ function run_pep8 {
|
|||||||
echo "Running pep8 ..."
|
echo "Running pep8 ..."
|
||||||
# Just run PEP8 in current environment
|
# Just run PEP8 in current environment
|
||||||
#
|
#
|
||||||
# NOTE(sirp): W602 (deprecated 3-arg raise) is being ignored for the
|
pep8_opts="--repeat"
|
||||||
# following reasons:
|
|
||||||
#
|
|
||||||
# 1. It's needed to preserve traceback information when re-raising
|
|
||||||
# exceptions; this is needed b/c Eventlet will clear exceptions when
|
|
||||||
# switching contexts.
|
|
||||||
#
|
|
||||||
# 2. There doesn't appear to be an alternative, "pep8-tool" compatible way of doing this
|
|
||||||
# in Python 2 (in Python 3 `with_traceback` could be used).
|
|
||||||
#
|
|
||||||
# 3. Can find no corroborating evidence that this is deprecated in Python 2
|
|
||||||
# other than what the PEP8 tool claims. It is deprecated in Python 3, so,
|
|
||||||
# perhaps the mistake was thinking that the deprecation applied to Python 2
|
|
||||||
# as well.
|
|
||||||
pep8_opts="--ignore=W602 --repeat"
|
|
||||||
${wrapper} pep8 ${pep8_opts} ${srcfiles}
|
${wrapper} pep8 ${pep8_opts} ${srcfiles}
|
||||||
}
|
}
|
||||||
|
|
||||||
function run_hacking {
|
function run_hacking {
|
||||||
echo "Running hacking compliance testing..."
|
echo "Running hacking compliance testing..."
|
||||||
hacking_opts="--ignore=E202,W602 --repeat"
|
hacking_opts="--ignore=E202 --repeat"
|
||||||
${wrapper} python tools/hacking.py ${hacking_opts} ${srcfiles}
|
${wrapper} python tools/hacking.py ${hacking_opts} ${srcfiles}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -6,5 +6,5 @@ mox==0.5.3
|
|||||||
nose
|
nose
|
||||||
nosexcover
|
nosexcover
|
||||||
openstack.nose_plugin
|
openstack.nose_plugin
|
||||||
pep8==0.6.1
|
pep8>=1.0
|
||||||
sphinx>=1.1.2
|
sphinx>=1.1.2
|
||||||
|
Loading…
Reference in New Issue
Block a user