From 54d3e7096ca3b68af3cf5f0d30f7c0949e87c6d9 Mon Sep 17 00:00:00 2001 From: Takashi NATSUME Date: Mon, 2 Jul 2018 13:59:19 +0900 Subject: [PATCH] Fix missing versioned notification examples Python 3 is used in executing 'tox -e docs' by default currently. When Python 3 is used, there are some missing notification examples. In python 3, map function returns an iterator instead of a list, and importlib.import_module is not executed in the document generation. So it causes missing versioned notification examples in the nova docs. This patch fixes it. Change-Id: Ie4f3f9be0ca7f94ce00a14f3d825a067a807eb12 Closes-Bug: #1779606 --- doc/ext/versioned_notifications.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/ext/versioned_notifications.py b/doc/ext/versioned_notifications.py index fe450bb715ed..7972b8727709 100644 --- a/doc/ext/versioned_notifications.py +++ b/doc/ext/versioned_notifications.py @@ -56,9 +56,9 @@ jQuery(document).ready(function(){ return self._build_markup(notifications) def _import_all_notification_packages(self): - map(lambda module: importlib.import_module(module), - ('nova.notifications.objects.' + name for _, name, _ in - pkgutil.iter_modules(nova.notifications.objects.__path__))) + list(map(lambda module: importlib.import_module(module), + ('nova.notifications.objects.' + name for _, name, _ in + pkgutil.iter_modules(nova.notifications.objects.__path__)))) def _collect_notifications(self): self._import_all_notification_packages()