Browse Source

Functional test for UnexpectedDeletingTaskStateError

Adds a regression-style test for two cleanup bugs when
'UnexpectedDeletingTaskStateError' is raised during build.

Change-Id: Ief1dfbb6cc9d67b73dfab4c7b63358e76e12866b
Related-Bug: #1848666
Related-Bug: #1831771
(cherry picked from commit 10434bd229)
(cherry picked from commit 24600430a2)
(cherry picked from commit ff21016543)
Matthew Booth 8 months ago
committed by Stephen Finucane
2 changed files with 105 additions and 1 deletions
  1. +1
  2. +104

+ 1
- 1
nova/tests/functional/ View File

@@ -276,7 +276,7 @@ class InstanceHelperMixin(object):
return server

def _wait_until_deleted(self, server):
initially_in_error = (server['status'] == 'ERROR')
initially_in_error = server.get('status') == 'ERROR'
for i in range(40):
server = self.api.get_server(server['id'])

+ 104
- 0
nova/tests/functional/regressions/ View File

@@ -0,0 +1,104 @@
# Copyright 2019, Red Hat, Inc. All Rights Reserved.
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.

import collections

import mock

from nova.compute import task_states
from nova.compute import vm_states
from nova import objects
from nova import test
from nova.tests.functional import integrated_helpers
from nova.tests.unit.image import fake as fake_image

class TestDelete(integrated_helpers.ProviderUsageBaseTestCase):
compute_driver = 'fake.MediumFakeDriver'

def test_delete_during_create(self):
compute = self._start_compute('compute1')

def delete_race(instance):
{'id': instance.uuid},
{'OS-EXT-STS:task_state': task_states.DELETING},

orig_save =

# an in-memory record of the current instance task state as persisted
# to the db.
db_task_states = collections.defaultdict(str)
active_after_deleting_error = [False]

# A wrapper round which allows us to inject a race
# under specific conditions before calling the original
def wrap_save(instance, *wrap_args, **wrap_kwargs):
# We're looking to inject the race before:
# towards the end of _build_and_run_instance.
# At this point the driver has finished creating the instance, but
# we're still on the compute host and still holding the compute
# host instance lock.
# This is just a convenient interception point. In order to race
# the delete could have happened at any point prior to this since
# the previous
expected_task_state = wrap_kwargs.get('expected_task_state')
if (
expected_task_state == task_states.SPAWNING

orig_save(instance, *wrap_args, **wrap_kwargs)

if (
db_task_states[instance.uuid] == task_states.DELETING and
instance.vm_state == vm_states.ACTIVE and
instance.task_state is None
# the instance was in the DELETING task state in the db, and we
# overwrote that to set it to ACTIVE with no task state.
# Bug 1848666.
active_after_deleting_error[0] = True

db_task_states[instance.uuid] = instance.task_state

with test.nested(
mock.patch('', wrap_save),
mock.patch.object(compute.driver, 'spawn'),
mock.patch.object(compute.driver, 'unplug_vifs'),
) as (_, mock_spawn, mock_unplug_vifs):
# the compute manager doesn't set the ERROR state in cleanup since
# it might race with delete, therefore we'll be left in BUILDING
server_req = self._build_minimal_create_server_request(
self.api, 'sample-server',
created_server = self.api.post_server({'server': server_req})

# assert that we spawned the instance, and unplugged vifs on
# cleanup
# FIXME(mdbooth): We should have called unplug_vifs in cleanup, but
# we didn't due to bug 1831771
# FIXME(mdbooth): Bug 1848666